[Bug 684537] New: Do not use deprecated API

system-monitor

unread,

Sep 21, 2012, 5:47:23 AM9/21/12

to tel.conn...@gmail.com

https://bugzilla.gnome.org/show_bug.cgi?id=684537
system-monitor | general | unspecified

Summary: Do not use deprecated API
Classification: Core
Product: system-monitor
Version: unspecified
OS/Version: All
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: general
AssignedTo: system-mon...@gnome.bugs
ReportedBy: stefano....@gmail.com
QAContact: system-mon...@gnome.bugs
GNOME version: ---

Applies on top of patch attached to bug 684536

--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

system-monitor

unread,

Sep 21, 2012, 5:47:30 AM9/21/12

to tel.conn...@gmail.com

https://bugzilla.gnome.org/show_bug.cgi?id=684537
system-monitor | general | unspecified

--- Comment #1 from Stefano Facchini <stefano....@gmail.com> 2012-09-21 09:47:25 UTC ---
Created an attachment (id=224914)
View: https://bugzilla.gnome.org/attachment.cgi?id=224914
Review: https://bugzilla.gnome.org/review?bug=684537&attachment=224914

Do not use deprecated API

Namely, we make the following replacements:
* GtkStyle -> GtkStyleContext
* GdkColor -> GdkRGBA
* GtkColorSelectionDialog -> GtkColorChooserDialog

Also, explicitly include librsvg/rsvg-cairo.h in gsm_color_button.c

system-monitor

unread,

Sep 21, 2012, 8:48:21 PM9/21/12

to tel.conn...@gmail.com

https://bugzilla.gnome.org/show_bug.cgi?id=684537
system-monitor | general | unspecified

system-monitor

unread,

Sep 22, 2012, 4:58:52 AM9/22/12

to tel.conn...@gmail.com

system-monitor

unread,

Sep 22, 2012, 5:21:53 PM9/22/12

to tel.conn...@gmail.com

https://bugzilla.gnome.org/show_bug.cgi?id=684537
system-monitor | general | 3.5.x

Robert Roth <evfool> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |DUPLICATE

--- Comment #2 from Robert Roth <evf...@yahoo.com> 2012-09-22 21:21:49 UTC ---
Thanks for the bug report. This particular bug has already been reported into
our bug tracking system, but please feel free to report any further bugs you
find.

*** This bug has been marked as a duplicate of bug 664524 ***

system-monitor

unread,

Sep 22, 2012, 5:26:11 PM9/22/12

to tel.conn...@gmail.com

https://bugzilla.gnome.org/show_bug.cgi?id=684537
system-monitor | general | 3.5.x

Robert Roth <evfool> changed:

What |Removed |Added
----------------------------------------------------------------------------

Attachment #224914|none |needs-work
status| |

--- Comment #3 from Robert Roth <evf...@yahoo.com> 2012-09-22 21:26:08 UTC ---
Review of attachment 224914:
--> (https://bugzilla.gnome.org/review?bug=684537&attachment=224914)

Nice work. I have marked the bug as a duplicate of bug 664524 (build system
monitor without warnings) as similar work has been started there. Your patch
however seems a lot better than my branch linked there, so I like it, however
it creates another warning in the build process :
In file included from gsm_color_button.c:35:0:
/usr/include/librsvg-2.0/librsvg/rsvg-cairo.h:27:2: warning: #warning
"Including <librsvg/rsvg-cairo.h> directly is deprecated." [-Wcpp]
So I guess including rsvg-cairo.h explicitly is not a good idea, it's enough to
include rsvg.h. With that minor change, it's likely that I'll accept it, as it
works as expected.

Reply all

Reply to author

Forward