[Bug 681685] New: Allow setting shortcut based only on a combination of two modifier keys, eg. Alt+Shift

1 view
Skip to first unread message

gnome-control-center

unread,
Aug 12, 2012, 9:34:43 AM8/12/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

Summary: Allow setting shortcut based only on a combination of
two modifier keys, eg. Alt+Shift
Classification: Core
Product: gnome-control-center
Version: 3.5.x
OS/Version: Linux
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: Keyboard
AssignedTo: control-ce...@gnome.bugs
ReportedBy: el...@fedoraproject.org
QAContact: control-ce...@gnome.bugs
GNOME version: ---


This was not a problem a while ago, when GNOME allowed X to handle keyboard
layout switching, but it is an issue now, because the most popular shortcut to
switch keyboard layouts, alt+shift, can't be configured now since GNOME moved
keyboard layout switching shortcut to be handled by the keyboard shortcut
control panel.

This bug will effect a lot of users who are used to this shortcut to switch
keyboard layout. Another popular switching combination is shift+capslock which
also doesn't work since 3.5.x

--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

gnome-control-center

unread,
Aug 12, 2012, 9:39:56 AM8/12/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

--- Comment #1 from Elad Alfassa <el...@fedoraproject.org> 2012-08-12 13:39:51 UTC ---
note that without this kind of a keyboard shortcut, I can't seem to find any
two-key combination which will be an easy replacement, thus making layout
switching (which I need a lot) to be a cumbersome task.

gnome-control-center

unread,
Aug 12, 2012, 9:58:38 AM8/12/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

Shlomi Israely <sijproject> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |sijpr...@gmail.com

--- Comment #2 from Shlomi Israely <sijpr...@gmail.com> 2012-08-12 13:58:32 UTC ---
I agree with Elad. this would be a big drawback of the desktop's usability for
multilang users.

gnome-control-center

unread,
Aug 12, 2012, 10:07:26 AM8/12/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

Allan Day <allanpday> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |alla...@gmail.com

gnome-control-center

unread,
Aug 12, 2012, 10:55:51 AM8/12/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

Christophe Fergeau <teuf> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |te...@gnome.org

gnome-control-center

unread,
Aug 13, 2012, 3:39:13 AM8/13/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

Rui Matos <tiagomatos> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |tiago...@gmail.com

gnome-control-center

unread,
Aug 13, 2012, 9:35:14 AM8/13/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

André Klapper <a9016009> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |a901...@gmx.de

--- Comment #3 from André Klapper <a901...@gmx.de> 2012-08-13 13:35:11 UTC ---
Also see discussion in bug 666393; and especially bug 669742 comment 2.
Probably a duplicate.

gnome-control-center

unread,
Aug 18, 2012, 2:35:00 PM8/18/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

Bastien Nocera <bugzilla> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
CC| |bugz...@hadess.net
Resolution| |DUPLICATE

--- Comment #4 from Bastien Nocera <bugz...@hadess.net> 2012-08-18 18:34:55 UTC ---
Thanks for the bug report. This particular bug has already been reported into
our bug tracking system, but please feel free to report any further bugs you
find.

*** This bug has been marked as a duplicate of bug 682069 ***

gnome-control-center

unread,
Sep 12, 2012, 8:52:50 AM9/12/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

Elad Alfassa <elad> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |UNCONFIRMED
Resolution|DUPLICATE |

--- Comment #5 from Elad Alfassa <el...@fedoraproject.org> 2012-09-12 12:52:48 UTC ---
This is not a duplicate of bug 68069.

Bug #68069 is about adding options such as compose key to the keyboard setting
window, and that is indeed fixed. however, this bug is about something
completely different: allowing keyboard shortcuts such as alt+shift,
shift+capslock and so forth to switch between keyboard layouts.

There is no way to do so in GNOME3. Even super+space which was proposed by
developers in #fedora-desktop is not working (and it's very uncomfortable). If
this bug is not fixed before the 3.6 release, multilingual users will have no
easy solution to switch between languages in gnome, thus making 3.6 very
painful for them.

gnome-control-center

unread,
Sep 12, 2012, 9:33:17 AM9/12/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

--- Comment #6 from Elad Alfassa <el...@fedoraproject.org> 2012-09-12 13:33:15 UTC ---
And yes, I am aware that until https://bugs.freedesktop.org/show_bug.cgi?id=865
is fixed, there won't be a way to fix this issue cleanly. But you must remember
that perfect is the enemy of the good. Most GNOME users type in more than one
language.

Even if you can't read English, you still need English for usernames and
passwords everywhere, so you'd end up having two layouts: English and your own
language (be it Chinese, Japanese, Arabic, Hebrew, or anything else that does
not use the Latin alphabet, and there are many of these).

Switching keyboard layouts is something multilingual users do a lot. sometimes
even in the same sentence. Having to take the hands off the keyboard, grab the
mouse, then clicking on two tiny click targets is slow, inefficient, and hard.

Not fixing this bug in time will clearly hurt every user who uses languages
other than English in their daily computer use.

I think, personally, that this bug should be prioritized, otherwise the whole
"Input Sources" feature will become counterproductive.

Of course, I do not want to be one of those people who starts flamewars,
otherwise I'd publish a link to this bug in mailing lists and social networks.
I don't want to do that because I value your time as a developer of GNOME,
which is by whole an awesome, very well built and designed project.

This long comment was only written to expand on why I think this bug is
critical, I hope nobody is offended or angered by it.

I would be happy to get a detailed answer (or better, a fix) to this. Thank you
for reading this comment.

gnome-control-center

unread,
Sep 12, 2012, 9:43:29 AM9/12/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

Bastien Nocera <bugzilla> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |mcl...@redhat.com

--- Comment #7 from Bastien Nocera <bugz...@hadess.net> 2012-09-12 13:43:23 UTC ---
*** Bug 682349 has been marked as a duplicate of this bug. ***

gnome-control-center

unread,
Sep 12, 2012, 9:53:39 AM9/12/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

Yanko Kaneti <yaneti> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |yan...@declera.com

gnome-control-center

unread,
Sep 12, 2012, 9:59:19 AM9/12/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

--- Comment #8 from Rui Matos <tiago...@gmail.com> 2012-09-12 13:59:14 UTC ---
(In reply to comment #6)

Just so that you don't feel ignored, I'm aware of this and will try to fix it
for 3.6.

gnome-control-center

unread,
Sep 15, 2012, 4:24:51 AM9/15/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

Alexandre Rostovtsev <tetromino> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |gn...@gentoo.org

--- Comment #9 from Alexandre Rostovtsev <tetr...@gentoo.org> 2012-09-15 08:24:46 UTC ---
This should be a blocker for 3.6.

gnome-control-center

unread,
Sep 15, 2012, 10:36:31 AM9/15/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

Matthias Clasen <mclasen> changed:

What |Removed |Added
----------------------------------------------------------------------------
GNOME target|--- |3.6

gnome-control-center

unread,
Sep 16, 2012, 5:23:44 PM9/16/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

nikita.vetoshkin changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |nikita.v...@gmail.com

--- Comment #10 from nikita.v...@gmail.com 2012-09-16 21:23:41 UTC ---
Sorry for meaningless comment, but that's a horrible drawback. Please fix this.
P.S. Maybe it's time to change status at least?

gnome-control-center

unread,
Sep 18, 2012, 12:54:33 PM9/18/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

artkun changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |art...@guitarplayer.ru

gnome-control-center

unread,
Sep 18, 2012, 12:57:38 PM9/18/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

--- Comment #11 from art...@guitarplayer.ru 2012-09-18 16:57:34 UTC ---
This should be considered as a blocker bug. I really liked this dialog.

gnome-control-center

unread,
Sep 18, 2012, 5:27:55 PM9/18/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

Bastien Nocera <bugzilla> changed:

What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |ASSIGNED
Ever Confirmed|0 |1

--- Comment #12 from Bastien Nocera <bugz...@hadess.net> 2012-09-18 21:27:50 UTC ---
If you want to CC: yourself on the changes, you don't need to add any comments.
Especially if they are as pointless and aggravating as the ones above.

(Changing the status to please people who don't know we barely ever use them.)

gnome-control-center

unread,
Sep 18, 2012, 10:38:25 PM9/18/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

Arschlöch <o63582> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |o63...@rtrtr.com

--- Comment #13 from Arschlöch <o63...@rtrtr.com> 2012-09-19 02:38:18 UTC ---
> pointless and aggravating as the ones above

If reports on regressions (i.e., removing features that people have been using
for years, without providing adequate replacement) are "pointless and
aggravating" for you, then I pity you.

> to please people who don't know we barely ever use them

How the heck do we know you don't use them? If you don't use 'em, remove 'em,
huh?

gnome-control-center

unread,
Sep 19, 2012, 3:12:47 AM9/19/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

--- Comment #14 from André Klapper <a901...@gmx.de> 2012-09-19 07:12:45 UTC ---
o63582: You missed the point. The initial comment is useful. Recent "me too!"
comments that don't provide any info except for personal wishes are useless.

gnome-control-center

unread,
Sep 19, 2012, 4:37:17 AM9/19/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

Pavel Vasin <rat4vier> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |rat4...@gmail.com

gnome-control-center

unread,
Sep 19, 2012, 4:53:04 AM9/19/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

--- Comment #15 from nikita.v...@gmail.com 2012-09-19 08:53:01 UTC ---
(In reply to comment #14)
> o63582: You missed the point. The initial comment is useful. Recent "me too!"
> comments that don't provide any info except for personal wishes are useless.

Someone could have changed status from UNCONFIRMED, written that it's a
regression, will be fixed in 3.6 and thanked for the report. That's it :)

gnome-control-center

unread,
Sep 19, 2012, 5:42:40 AM9/19/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

Sergey V. Udaltsov <svu> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |s...@gnome.org

--- Comment #16 from Sergey V. Udaltsov <s...@gnome.org> 2012-09-19 09:42:34 UTC ---
Rui, Bastien, this is really highest-priority blocker for Russian users (at
least - but I suspect other languages are affected)

gnome-control-center

unread,
Sep 19, 2012, 5:55:43 AM9/19/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

--- Comment #17 from Bastien Nocera <bugz...@hadess.net> 2012-09-19 09:55:41 UTC ---
(In reply to comment #16)
> Rui, Bastien, this is really highest-priority blocker for Russian users (at
> least - but I suspect other languages are affected)

How does adding a comment like that help at all? It's already a blocker. What
else do you expect us to do? You're taking time that could be used to fix the
problem.

gnome-control-center

unread,
Sep 19, 2012, 6:01:00 AM9/19/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

--- Comment #18 from Sergey V. Udaltsov <s...@gnome.org> 2012-09-19 10:00:57 UTC ---
The Importance of that bug is still "Normal"/"normal". That's what caused my
previous comment.
Apologies for not looking into blocker list @ddl

gnome-control-center

unread,
Sep 19, 2012, 6:22:31 AM9/19/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

--- Comment #19 from Bastien Nocera <bugz...@hadess.net> 2012-09-19 10:22:29 UTC ---
(In reply to comment #18)
> The Importance of that bug is still "Normal"/"normal". That's what caused my
> previous comment.

You should know better than anyone that we don't use most of those fields on a
day-to-day.

> Apologies for not looking into blocker list @ddl

"GNOME target: 3.6"
in the bug status itself. It's also listed at the top of:
https://bugzilla.gnome.org/browse.cgi?product=gnome-control-center

gnome-control-center

unread,
Sep 19, 2012, 6:29:27 AM9/19/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-control-center | Keyboard | 3.5.x

--- Comment #20 from Sergey V. Udaltsov <s...@gnome.org> 2012-09-19 10:29:21 UTC ---
Thank you! The Russian community got agitated by that regression, now at least
people can be relieved, their voice is heard.

gnome-settings-daemon

unread,
Sep 20, 2012, 3:50:24 PM9/20/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

Rui Matos <tiagomatos> changed:

What |Removed |Added
----------------------------------------------------------------------------
Component|Keyboard |keyboard
Version|3.5.x |unspecified
AssignedTo|control-center-maint@gnome. |gnome-settings-daemon-maint
|bugs |@gnome.bugs
Product|gnome-control-center |gnome-settings-daemon
QAContact|control-center-maint@gnome. |gnome-settings-daemon-maint
|bugs |@gnome.bugs

gnome-settings-daemon

unread,
Sep 20, 2012, 3:52:11 PM9/20/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #21 from Rui Matos <tiago...@gmail.com> 2012-09-20 19:52:03 UTC ---
Created an attachment (id=224856)
View: https://bugzilla.gnome.org/attachment.cgi?id=224856
Review: https://bugzilla.gnome.org/review?bug=681685&attachment=224856

keyboard: Add modifiers-only shortcuts to switch input sources

--

This adds the necessary plumbing in g-s-d. At this point we can't do
an official UI in g-c-c but it will be possible to set the shortcut in
gsettings and I'll try to do a patch for gnome-tweak-tool.

gnome-settings-daemon

unread,
Sep 20, 2012, 3:58:26 PM9/20/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #22 from Elad Alfassa <el...@fedoraproject.org> 2012-09-20 19:58:22 UTC ---
> This adds the necessary plumbing in g-s-d.

Fantastic! Thanks for working on this!

> at this point we can't do an official UI in g-c-c

"this point" being the 3.6 release cycle? This means there will be no
(official) UI for this until GNOME 3.8?

I wish it was possible to do without UI changes (ie. like you set any other
keyboard shortcut) but I guess that's a problem with X and not with GNOME.

gnome-settings-daemon

unread,
Sep 20, 2012, 4:36:32 PM9/20/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #23 from Bastien Nocera <bugz...@hadess.net> 2012-09-20 20:36:25 UTC ---
(In reply to comment #22)
> > at this point we can't do an official UI in g-c-c
>
> "this point" being the 3.6 release cycle? This means there will be no
> (official) UI for this until GNOME 3.8?

Yep, only gnome-tweak-tool.

> I wish it was possible to do without UI changes (ie. like you set any other
> keyboard shortcut) but I guess that's a problem with X and not with GNOME.

The problem is that it's so hacky to do outside of the X server that we can
only implement it separately from the other key handling, which means that the
UI has to go through hoops as well. It won't be pretty...

gnome-settings-daemon

unread,
Sep 20, 2012, 4:39:16 PM9/20/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #24 from Elad Alfassa <el...@fedoraproject.org> 2012-09-20 20:39:10 UTC ---
Will it be less hacky to do so if/when
https://bugs.freedesktop.org/show_bug.cgi?id=865 is fixed?

gnome-settings-daemon

unread,
Sep 20, 2012, 10:40:52 PM9/20/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

Rui Matos <tiagomatos> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #224856|0 |1
is obsolete| |

--- Comment #25 from Rui Matos <tiago...@gmail.com> 2012-09-21 02:40:44 UTC ---
Created an attachment (id=224887)
View: https://bugzilla.gnome.org/attachment.cgi?id=224887
Review: https://bugzilla.gnome.org/review?bug=681685&attachment=224887

keyboard: Add modifiers-only shortcuts to switch input sources

This adds an out of process helper similar to gsd-locate-pointer to
allow for grabbing of certain pre-defined modifier-only shortcut
combos.
--

Ray pointed on IRC that we need to grab every on every combination of
ignored modifiers besides the ones we actually want so that the
sohrtcut works when CapsLock or NumLock or both are on, and that this
is exactly what the code in gsd-keygrab.c already does.

So, I modified this patch to call that code instead of doing the grab
explicitly here and that also implied switching to XI2 for the event
handling on the filter.

This uncovered 2 limitations in gsd-keygrab.c, but the following 2
patches fix them. The other only consumer of this API, the media-keys
plugin, seems to work just as well with these changes as far as I
tested.

gnome-settings-daemon

unread,
Sep 20, 2012, 10:41:05 PM9/20/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #26 from Rui Matos <tiago...@gmail.com> 2012-09-21 02:40:57 UTC ---
Created an attachment (id=224888)
View: https://bugzilla.gnome.org/attachment.cgi?id=224888
Review: https://bugzilla.gnome.org/review?bug=681685&attachment=224888

keygrab: Do a synchronous grab on the master device

This allows us to replay events that might be interesting to other
applications.

gnome-settings-daemon

unread,
Sep 20, 2012, 10:41:14 PM9/20/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #27 from Rui Matos <tiago...@gmail.com> 2012-09-21 02:41:10 UTC ---
Created an attachment (id=224889)
View: https://bugzilla.gnome.org/attachment.cgi?id=224889
Review: https://bugzilla.gnome.org/review?bug=681685&attachment=224889

keygrab: Remove Shift from modifiers if it's the key we want to match

This allows us to match and thus have shortcuts consisting of a
modified Shift.

gnome-settings-daemon

unread,
Sep 20, 2012, 10:45:17 PM9/20/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #28 from Rui Matos <tiago...@gmail.com> 2012-09-21 02:45:14 UTC ---
(In reply to comment #24)
> Will it be less hacky to do so if/when
> https://bugs.freedesktop.org/show_bug.cgi?id=865 is fixed?

No, I'm not using that mechanism at all. I could if we did the key grabbing in
gnome-shell though, so for 3.8 we'll probably revisit this and that patch might
be helpful (not sure, didn't look at it).

gnome-settings-daemon

unread,
Sep 21, 2012, 8:37:22 AM9/21/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #29 from Elad Alfassa <el...@fedoraproject.org> 2012-09-21 12:37:19 UTC ---
Maybe when this patch is applied, you could change g-c-s to enable alt+shift
layout switching automatically when you add a new keyboard layout?

gnome-settings-daemon

unread,
Sep 21, 2012, 11:30:09 AM9/21/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

Kamil Páral <kparal> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |kpa...@redhat.com

--- Comment #30 from Kamil Páral <kpa...@redhat.com> 2012-09-21 15:30:04 UTC ---
Hello, does this bug also concern the ability to switch layout using just
CapsLock key, or does it concern just two-keys combinations (Alt+Shift and
similar)?

From GNOME 2 to GNOME 3.4 I've been using CapsLock to switch the layout and the
keyboard indicator marked currently active layout (off = English, on = Czech).
I mention this because I am used to switch layouts several times in a single
sentence, thus e.g. dozen times per minute. Single key press (CapsLock) is much
better for me than multiple key press (Alt+Shift) and I would be very sad to
see it go away.

Is there any way to use the old configuration dialog in GNOME 3.6 instead of
the new one?

If this is not in the scope of this bug, tell me and I'll create a separate
one.

gnome-settings-daemon

unread,
Sep 21, 2012, 11:40:41 AM9/21/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #31 from Sergey V. Udaltsov <s...@gnome.org> 2012-09-21 15:40:32 UTC ---
Kamil, you can specify XKB options in gsettings. No GUI for that so far.

No you cannot use anything from 3.4 since Input Methods configuration was
heavily redesigned.

gnome-settings-daemon

unread,
Sep 21, 2012, 11:41:47 AM9/21/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #32 from Sergey V. Udaltsov <s...@gnome.org> 2012-09-21 15:41:26 UTC ---
Rui, BTW, if you are going to fix it for Caps, could you please add switching
by RCtrl - that is what I am using.

gnome-settings-daemon

unread,
Sep 21, 2012, 11:58:12 AM9/21/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #33 from Elad Alfassa <el...@fedoraproject.org> 2012-09-21 15:57:59 UTC ---
(In reply to comment #30)
> Is there any way to use the old configuration dialog in GNOME 3.6 instead of
> the new one?
We should open a new bug (after these patches are reviewed and pushed) to get
some sort of a UI for that into gnome-tweak-tool, should be simple enough to
do, one combo-box with all the possible options.

gnome-settings-daemon

unread,
Sep 21, 2012, 12:00:25 PM9/21/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #34 from Sergey V. Udaltsov <s...@gnome.org> 2012-09-21 16:00:18 UTC ---
One combo??? There are multiple GROUPS of options. Some of them allow multiple
selection, some don't.

gnome-settings-daemon

unread,
Sep 21, 2012, 12:17:37 PM9/21/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #36 from Sergey V. Udaltsov <s...@gnome.org> 2012-09-21 16:17:34 UTC ---
sorry I meant all xkb options that were available in 3.4

gnome-settings-daemon

unread,
Sep 21, 2012, 12:18:49 PM9/21/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #37 from Kamil Páral <kpa...@redhat.com> 2012-09-21 16:18:47 UTC ---
(In reply to comment #31)
> Kamil, you can specify XKB options in gsettings. No GUI for that so far.

If the old gsetting values ("org.gnome.libgnomekbd.keyboard options") are still
honored even in GNOME 3.6, I'm totally happy. It's an advanced stuff and I
understand there might be no GUI for it, that's fine.

gnome-settings-daemon

unread,
Sep 21, 2012, 12:06:41 PM9/21/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #35 from Elad Alfassa <el...@fedoraproject.org> 2012-09-21 16:06:38 UTC ---
(In reply to comment #34)
> One combo??? There are multiple GROUPS of options. Some of them allow multiple
> selection, some don't.
Yes, one. I think you can fit all these states:
+ GSD_INPUT_SOURCES_SWITCHER_OFF,
+ GSD_INPUT_SOURCES_SWITCHER_ALT_SHIFT_L,
+ GSD_INPUT_SOURCES_SWITCHER_ALT_SHIFT_R,
+ GSD_INPUT_SOURCES_SWITCHER_CTRL_SHIFT_L,
+ GSD_INPUT_SOURCES_SWITCHER_CTRL_SHIFT_R

(from the patch) in one combo box

gnome-settings-daemon

unread,
Sep 21, 2012, 12:26:28 PM9/21/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

artkun changed:

What |Removed |Added
----------------------------------------------------------------------------
CC|art...@guitarplayer.ru |

gnome-settings-daemon

unread,
Sep 21, 2012, 12:47:52 PM9/21/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #38 from Matthias Clasen <mcl...@redhat.com> 2012-09-21 16:47:46 UTC ---
(In reply to comment #36)
> sorry I meant all xkb options that were available in 3.4

Even if it is a tweak tool, I don't think we should put _all_ options in there.
The options that we've discussed for showing in the tweak tool are listed in
bug 678171. That bug also contains a discussion about migrating
org.gnome.libgnomekbd settings over.

gnome-settings-daemon

unread,
Sep 21, 2012, 8:29:52 PM9/21/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #39 from Matthias Clasen <mcl...@redhat.com> 2012-09-22 00:29:47 UTC ---
I've tested this now, and I guess it works as well as can be expected
from this kind of approach.

What takes a little getting used to is that one has to release the
keys in the right order. E.g. with the setting 'alt-shift-l', I have
to generate the sequence press Alt - press Shift - release Shift -
release Alt. If I just hit the keys together quickly, I often end up
generating an order where I release Alt before Shift, in which case we
get a key release event for the Shift key without the Alt modifier,
thus not triggering the switch. Can we grab these combinations both
ways, ie look for an Alt release with the Shift modifier as well ? I
think that would make this much less frustrating.

It doesn't seem to work in the overview though. Wasn't that supposed
to be the advantage of this approach over ISO_Next_Source ?

gnome-settings-daemon

unread,
Sep 22, 2012, 6:30:21 AM9/22/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #40 from nikita.v...@gmail.com 2012-09-22 10:30:15 UTC ---
(In reply to comment #39)
> It doesn't seem to work in the overview though.
It doesn't work if Synapse(launcher) window is active either.

gnome-settings-daemon

unread,
Sep 22, 2012, 7:12:24 AM9/22/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #41 from Elad Alfassa <el...@fedoraproject.org> 2012-09-22 11:12:18 UTC ---
Other combinations (unrealted to this patch) and media-keys don't work in the
overview either, see bug #643111

gnome-settings-daemon

unread,
Sep 22, 2012, 4:28:07 PM9/22/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

Rui Matos <tiagomatos> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #224888|0 |1
is obsolete| |

--- Comment #42 from Rui Matos <tiago...@gmail.com> 2012-09-22 20:28:04 UTC ---
Created an attachment (id=224998)
View: https://bugzilla.gnome.org/attachment.cgi?id=224998
Review: https://bugzilla.gnome.org/review?bug=681685&attachment=224998

keygrab: Do a synchronous grab on the master device

--
Just rebased.

gnome-settings-daemon

unread,
Sep 22, 2012, 4:39:52 PM9/22/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

Rui Matos <tiagomatos> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #224887|0 |1
is obsolete| |
Attachment #224889|0 |1
is obsolete| |

--- Comment #43 from Rui Matos <tiago...@gmail.com> 2012-09-22 20:39:47 UTC ---
Created an attachment (id=224999)
View: https://bugzilla.gnome.org/attachment.cgi?id=224999
Review: https://bugzilla.gnome.org/review?bug=681685&attachment=224999

keyboard: Add modifiers-only shortcuts to switch input sources

--
(In reply to comment #39)
> What takes a little getting used to is that one has to release the
> keys in the right order. E.g. with the setting 'alt-shift-l', I have
> to generate the sequence press Alt - press Shift - release Shift -
> release Alt. If I just hit the keys together quickly, I often end up
> generating an order where I release Alt before Shift, in which case we
> get a key release event for the Shift key without the Alt modifier,
> thus not triggering the switch. Can we grab these combinations both
> ways, ie look for an Alt release with the Shift modifier as well ? I
> think that would make this much less frustrating.

Yep, I've re-worked the patch to do that now. Seems much better
indeed.

I had to do adjustments to how we match the keys though because when a
modifier is released, the event state includes the modifier
itself. Doing this I realised that my previous patch to
match_xi2_key() is no longer needed and instead I can do all the
fudging before calling into it which should make this patch even safer
since the behavior of match_xi2_key() isn't changed at all now.

I also had to add some extra effort for the right Alt case since in
many keyboard layouts right Alt is actually the ISO_Level3_Shift key.

> It doesn't seem to work in the overview though. Wasn't that supposed
> to be the advantage of this approach over ISO_Next_Source ?

No, the advantage of not using ISO_Next_Source is that ISO_Next_Source
would be confusing if used in the overview because it would actually
change the XKB group (which we use undercover sometimes) but since we
wouldn't be able to catch it there, the input source wouldn't change.

gnome-settings-daemon

unread,
Sep 22, 2012, 4:41:00 PM9/22/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #44 from Rui Matos <tiago...@gmail.com> 2012-09-22 20:40:55 UTC ---
Created an attachment (id=225000)
View: https://bugzilla.gnome.org/attachment.cgi?id=225000
Review: https://bugzilla.gnome.org/review?bug=681685&attachment=225000

keygrab: Allow unmodified grabs if explicitly requested

Unmodified grabs are sometimes useful. This adds the option for
calling code to be able to request a grab bypassing the whitelisting
of allowed unmodified keysyms.

--
This is only needed if we want to add single modifier shortcuts like
Right Alt alone. See next patch.

gnome-settings-daemon

unread,
Sep 22, 2012, 4:41:09 PM9/22/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #45 from Rui Matos <tiago...@gmail.com> 2012-09-22 20:41:03 UTC ---
Created an attachment (id=225001)
View: https://bugzilla.gnome.org/attachment.cgi?id=225001
Review: https://bugzilla.gnome.org/review?bug=681685&attachment=225001

keyboard: Add single modifier shortcuts to the input sources switcher

gnome-settings-daemon

unread,
Sep 22, 2012, 5:26:03 PM9/22/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

Matthias Clasen <mclasen> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #224998|none |needs-work
status| |

--- Comment #46 from Matthias Clasen <mcl...@redhat.com> 2012-09-22 21:26:00 UTC ---
Review of attachment 224998:
--> (https://bugzilla.gnome.org/review?bug=681685&attachment=224998)

I think this is a problem for the other uses of grab_key_unsafe in the media
keys plugin. Try hitting one of the grabbed media keys, and observe that you
will loose all keyboard input from then on.

How about changing the key grab api a bit more to

GsdKeyGrabFlags {
GSD_KEY_GRAB_ALLOW_UNMODIFIED,
GSD_KEY_GRAB_SYNCHRONOUS
}

grab_key_unsafe (Key *key, GsdKeyGrabFlags flags, GSList *screens)
ungrab_key_unsafe (Key *key, GSList *screens)

This addresses a number of other issues I have with the api and your changes to
it:

- Calling the enum GsdKeygrabMode invites confusion with the X concept of
GrabMode

- Much better to have separate functions for grab and ungrab, imo

gnome-settings-daemon

unread,
Sep 22, 2012, 5:29:44 PM9/22/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

Matthias Clasen <mclasen> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #225000|none |reviewed
status| |

--- Comment #47 from Matthias Clasen <mcl...@redhat.com> 2012-09-22 21:29:39 UTC ---
Review of attachment 225000:
--> (https://bugzilla.gnome.org/review?bug=681685&attachment=225000)

See my earlier api comments

gnome-settings-daemon

unread,
Sep 22, 2012, 5:34:28 PM9/22/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

Matthias Clasen <mclasen> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #224999|none |reviewed
status| |

--- Comment #48 from Matthias Clasen <mcl...@redhat.com> 2012-09-22 21:34:21 UTC ---
Review of attachment 224999:
--> (https://bugzilla.gnome.org/review?bug=681685&attachment=224999)

This looks fine to me

gnome-settings-daemon

unread,
Sep 22, 2012, 5:34:46 PM9/22/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

Matthias Clasen <mclasen> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #225001|none |reviewed
status| |

--- Comment #49 from Matthias Clasen <mcl...@redhat.com> 2012-09-22 21:34:42 UTC ---
Review of attachment 225001:
--> (https://bugzilla.gnome.org/review?bug=681685&attachment=225001)

Looks fine to me

gnome-settings-daemon

unread,
Sep 22, 2012, 5:38:05 PM9/22/12
to tel.conn...@gmail.com
https://bugzilla.gnome.org/show_bug.cgi?id=681685
gnome-settings-daemon | keyboard | unspecified

--- Comment #50 from Matthias Clasen <mcl...@redhat.com> 2012-09-22 21:38:01 UTC ---
The behaviour is good now. Grabbing 'both ways' makes it much better. And the
single-modifier options work fine too.

Now we just need to fix the sync grab issue.
Reply all
Reply to author
Forward
0 new messages