[Bug 664524] System-monitor should build without warnings

[system-monitor]

https://bugzilla.gnome.org/show_bug.cgi?id=664524
system-monitor | general | HEAD

Bug 664524 depends on bug 663736, which changed state.

Bug 663736 Summary: GtkGrid should be used for layout in system-monitor
https://bugzilla.gnome.org/show_bug.cgi?id=663736

What |Old Value |New Value
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Status|ASSIGNED |RESOLVED
Resolution| |FIXED

--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

[system-monitor]

https://bugzilla.gnome.org/show_bug.cgi?id=664524
system-monitor | general | HEAD

Robert Roth <evfool> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |evf...@yahoo.com

--- Comment #3 from Robert Roth <evf...@yahoo.com> 2012-08-01 08:49:52 UTC ---
@Chris: Could you please check if with the current master you still get any
warnings, as I don't anymore, so this might be a good candidate to mark as
fixed.

[system-monitor]

https://bugzilla.gnome.org/show_bug.cgi?id=664524
system-monitor | general | HEAD

Robert Roth <evfool> changed:

What |Removed |Added
----------------------------------------------------------------------------

Attachment #205786|0 |1
is obsolete| |
Status|NEW |ASSIGNED
AssignedTo|system-monitor-maint@gnome. |evf...@yahoo.com
|bugs |

--- Comment #4 from Robert Roth <evf...@yahoo.com> 2012-08-01 18:39:12 UTC ---
Created an attachment (id=220093)
View: https://bugzilla.gnome.org/attachment.cgi?id=220093
Review: https://bugzilla.gnome.org/review?bug=664524&attachment=220093

Proposed patch

Found a warning on 64 bit systems only (no warning on 32 bit systems) about
incorrect conversion from gint to gpointer (gpointer is 64 bits long on a 64
bit system, but 32 bit on 32 bit systems, while gint is always 32 bits, I
guess.) using the GINT_TO_GPOINTER glib macro

[system-monitor]

https://bugzilla.gnome.org/show_bug.cgi?id=664524
system-monitor | general | HEAD

--- Comment #5 from Chris Kühl <bli...@gmail.com> 2012-08-04 14:08:29 UTC ---
I still get a number of warning about the color picker api being deprecated.
So, not qiute out of the woods yet.

[system-monitor]

https://bugzilla.gnome.org/show_bug.cgi?id=664524
system-monitor | general | HEAD

--- Comment #6 from Robert Roth <evf...@yahoo.com> 2012-08-04 19:53:02 UTC ---
OK, found that, color_selection dialog has been deprecated in 3.5, and I'm
still at 3.4, and did not manage to install Arch linux yet to test the latest.
Regardless, I have migrated the color selection dialog to color chooser,
gdkcolor to gdkrgba, you can see that on my deprecations branch.
The only problem I can see is that on System Monitor startup the colorbuttons
are not correctly colored, they only appear as colored after the first color
selection. I could not figure out why on startup these do not get initialized
properly. @Chris: Could you please take a look when you have the time to see if
you can find why this doesn't work.

[1] http://git.gnome.org/browse/gnome-system-monitor/log/?h=deprecations

[system-monitor]

https://bugzilla.gnome.org/show_bug.cgi?id=664524
system-monitor | general | HEAD

Robert Roth <evfool> changed:

What |Removed |Added
----------------------------------------------------------------------------

CC| |stefano....@gmail.com

--- Comment #7 from Robert Roth <evf...@yahoo.com> 2012-09-22 21:21:49 UTC ---
*** Bug 684537 has been marked as a duplicate of this bug. ***