[Bug 684620] New: Make fallback warning less annoying

[gnome-session]

https://bugzilla.gnome.org/show_bug.cgi?id=684620
gnome-session | gnome-session | 3.4.x

Summary: Make fallback warning less annoying
Classification: Core
Product: gnome-session
Version: 3.4.x
OS/Version: Linux
Status: UNCONFIRMED
Severity: normal
Priority: Normal
Component: gnome-session
AssignedTo: gnome-ses...@gnome.bugs
ReportedBy: jo...@malsain.org
QAContact: gnome-ses...@gnome.bugs
GNOME version: ---


Created an attachment (id=224974)
View: https://bugzilla.gnome.org/attachment.cgi?id=224974
Review: https://bugzilla.gnome.org/review?bug=684620&attachment=224974

Use libnotify to display fallback warning

The fallback warning can get annoying, especially when using live systems. This
is why Ubuntu has chosen to disable it, but at the risk of users wondering why
the desktop looks different on a different machine.

It is much less annoying to use a notification with libnotify instead, when
available.

--
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching all bug changes.

[gnome-session]

https://bugzilla.gnome.org/show_bug.cgi?id=684620
gnome-session | gnome-session | 3.4.x

Matthias Clasen <mclasen> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |mcl...@redhat.com

--- Comment #1 from Matthias Clasen <mcl...@redhat.com> 2012-09-22 17:26:06 UTC ---
Just depend on libnotify. No point in ifdeffing this.

[gnome-session]

https://bugzilla.gnome.org/show_bug.cgi?id=684620
gnome-session | gnome-session | 3.4.x

Josselin Mouette <joss> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #224974|0 |1
is obsolete| |

--- Comment #2 from Josselin Mouette <jo...@malsain.org> 2012-09-22 17:52:02 UTC ---
Created an attachment (id=224989)
View: https://bugzilla.gnome.org/attachment.cgi?id=224989
Review: https://bugzilla.gnome.org/review?bug=684620&attachment=224989

Use libnotify to display fallback warning

Well if you prefer it this way, it’s simpler of course.

[gnome-session]

https://bugzilla.gnome.org/show_bug.cgi?id=684620
gnome-session | gnome-session | 3.4.x

Colin Walters <walters> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #224989|none |reviewed
status| |

--- Comment #3 from Colin Walters <wal...@verbum.org> 2012-09-22 21:59:51 UTC ---
Review of attachment 224989:
--> (https://bugzilla.gnome.org/review?bug=684620&attachment=224989)

This could use designer input.

::: gnome-session/gsm-manager.c
@@ +1371,3 @@
+ notif = notify_notification_new (title, description,
GSM_ICON_COMPUTER_FAIL);
+ notify_notification_set_timeout (notif, 15*1000);
+ notify_notification_add_action (notif, "link-click", link_text,
NOTIFY_ACTION_CALLBACK (on_link_clicked), (gpointer) uri, NULL);

Your cast here is subverting what the compiler was likely telling you - passing
a const char * here is wrong since the string may have been freed. You need to
g_strdup().

@@ +1372,3 @@
+ notify_notification_set_timeout (notif, 15*1000);
+ notify_notification_add_action (notif, "link-click", link_text,
NOTIFY_ACTION_CALLBACK (on_link_clicked), (gpointer) uri, NULL);
+ /* Give the notification daemon a chance to finish initialization */

Sigh =( Notifications popping up before the UI is initialized have always been
a very embarassing part of GNOME 2.

Oh well.