Does a dynamic creation of attributes make sense?

[Erik Schilling]

Hi,

currently the server warns with:
LOG_WARN("Being: Creation of new attributes dynamically is not "
"implemented yet!");

If you try to set a invalid attribute.

This does not make a lot of sense, right?

Either the attribute was designed for the right scope and is available,
or it is not and should not be in that scope.

Also allowing to define attributes that are not defined in the
attributes.xml could lead to conflicts later if you add more attributes.

So do we really implement dynamic creation of those attributes? I would
rather adding a bool return to the setAttribute function and making lua
scripts which try this erroring.

Regards,
Erik Schilling

[Thorbjørn Lindeijer]

On Thu, May 9, 2013 at 4:23 PM, Erik Schilling
<ablu.erik...@gmail.com> wrote:
> Hi,
>
> currently the server warns with:
> LOG_WARN("Being: Creation of new attributes dynamically is not "
> "implemented yet!");
>
> If you try to set a invalid attribute.
>
> This does not make a lot of sense, right?
>
> Either the attribute was designed for the right scope and is available, or
> it is not and should not be in that scope.

Yes, I think you're right! Also I agree trying to set (and maybe also
get?) the value of an invalid attribute should raise an error on the
Lua side.

Regards,
Bjørn