Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[Samba] smbget returns wrong exit code

66 views
Skip to first unread message

Jason Schaefer

unread,
Mar 7, 2010, 2:02:05 PM3/7/10
to
smbget -Rr smb://localhost/share

[all files and folders are copied successfully!]

echo $?
1

On the other hand, when smbget is introduced with an error

smbget -Rr smb://localhost/shar
Can't open directory smb://localhost/shar: No such file or directory

echo $?
0

This is breaking my error checking in backup scripts. I can't find any
place to file a bug report, I hope this is the right list

Thanks
Jason
--
To unsubscribe from this list go to the following URL and read the
instructions: https://lists.samba.org/mailman/options/samba

Joerg Thuemmler

unread,
Mar 8, 2010, 1:32:26 AM3/8/10
to
Jason Schaefer schrieb:

> smbget -Rr smb://localhost/share
>
> [all files and folders are copied successfully!]
>
> echo $?
> 1
>
> On the other hand, when smbget is introduced with an error
>
> smbget -Rr smb://localhost/shar
> Can't open directory smb://localhost/shar: No such file or directory
>
> echo $?
> 0
>
> This is breaking my error checking in backup scripts. I can't find any
> place to file a bug report, I hope this is the right list
>
> Thanks
> Jason

Hi,

found the same behavior using smbget with errornous parameters. Maybe it
should do so: return not the error code but the count of files it got?
Although that would be really strange...

cu jth

Jason Schaefer

unread,
Mar 8, 2010, 12:55:37 PM3/8/10
to
> found the same behavior using smbget with errornous parameters. Maybe it
> should do so: return not the error code but the count of files it got?
> Although that would be really strange...
>
> cu jth

No, its just that the exit status is reversed from the standard.
Successful completion should return 0 and unsuccessful should return
1. I see it as a bug. Exit status only has values of 0-255. So file
count is out :-)

Jeremy Allison

unread,
Mar 10, 2010, 6:11:48 PM3/10/10
to
On Mon, Mar 08, 2010 at 10:55:37AM -0700, Jason Schaefer wrote:
> > found the same behavior using smbget with errornous parameters. Maybe it
> > should do so: return not the error code but the count of files it got?
> > Although that would be really strange...
> >
> > cu jth
>
> No, its just that the exit status is reversed from the standard.
> Successful completion should return 0 and unsuccessful should return
> 1. I see it as a bug. Exit status only has values of 0-255. So file
> count is out :-)

I think I've fixed this one recently (someone definitely logged
a bug on this with a patch :-).

Jeremy

0 new messages