Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] smbcontrol.c: fix a bug of drvupgrade

2 views
Skip to first unread message

Peng Haitao

unread,
May 22, 2013, 4:50:11 AM5/22/13
to
When message-type is drvupgrade, MSG_DEBUG should be replaced with MSG_PRINTER_DRVUPGRADE.

Signed-off-by: Peng Haitao <pen...@cn.fujitsu.com>
---
source3/utils/smbcontrol.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source3/utils/smbcontrol.c b/source3/utils/smbcontrol.c
index 47884ff..00b23f7 100644
--- a/source3/utils/smbcontrol.c
+++ b/source3/utils/smbcontrol.c
@@ -928,7 +928,7 @@ static bool do_drvupgrade(struct tevent_context *ev_ctx,
return False;
}

- return send_message(msg_ctx, pid, MSG_DEBUG, argv[1],
+ return send_message(msg_ctx, pid, MSG_PRINTER_DRVUPGRADE, argv[1],
strlen(argv[1]) + 1);
}

--
1.8.1.4

Jeremy Allison

unread,
May 22, 2013, 2:26:28 PM5/22/13
to
On Wed, May 22, 2013 at 04:50:11PM +0800, Peng Haitao wrote:
> When message-type is drvupgrade, MSG_DEBUG should be replaced with MSG_PRINTER_DRVUPGRADE.
>
> Signed-off-by: Peng Haitao <pen...@cn.fujitsu.com>

+1

Reviewed-by: Jeremy Allison <j...@samba.org>

> ---
> source3/utils/smbcontrol.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/source3/utils/smbcontrol.c b/source3/utils/smbcontrol.c
> index 47884ff..00b23f7 100644
> --- a/source3/utils/smbcontrol.c
> +++ b/source3/utils/smbcontrol.c
> @@ -928,7 +928,7 @@ static bool do_drvupgrade(struct tevent_context *ev_ctx,
> return False;
> }
>
> - return send_message(msg_ctx, pid, MSG_DEBUG, argv[1],
> + return send_message(msg_ctx, pid, MSG_PRINTER_DRVUPGRADE, argv[1],
> strlen(argv[1]) + 1);
> }
>
> --
> 1.8.1.4

Second Team +1 and I'll push, thanks !

Jeremy.

Michael Adam

unread,
May 22, 2013, 4:55:29 PM5/22/13
to
On 2013-05-22 at 11:26 -0700, Jeremy Allison wrote:
> On Wed, May 22, 2013 at 04:50:11PM +0800, Peng Haitao wrote:
> > When message-type is drvupgrade, MSG_DEBUG should be replaced with MSG_PRINTER_DRVUPGRADE.
> >
> > Signed-off-by: Peng Haitao <pen...@cn.fujitsu.com>
>
> +1
>
> Reviewed-by: Jeremy Allison <j...@samba.org>

Reviewed-by: Michael Adam <ob...@samba.org>

Cheers - Michael

signature.asc
0 new messages