Re: [PATCH v6] vfs_glusterfs: Samba VFS module for glusterfs

[Andrew Bartlett]

On Sat, 2013-05-25 at 05:30 -0400, Anand Avati wrote:
> Implement a Samba VFS plugin for glusterfs based on gluster's gfapi.
> This is a "bottom" vfs plugin (not something to be stacked on top of
> another module), and translates (most) calls into closest actions
> on gfapi.

> + if conf.CHECK_HEADERS('api/glfs.h'):
> + conf.DEFINE('HAVE_GLUSTERFS', '1')
> +
> default_static_modules.extend(TO_LIST('''pdb_smbpasswd pdb_tdbsam pdb_wbc_sam
> auth_sam auth_unix auth_winbind auth_wbc
> auth_domain auth_builtin vfs_default
> @@ -1797,6 +1800,9 @@ main() {
> if conf.CONFIG_SET("HAVE_CEPH"):
> default_shared_modules.extend(TO_LIST('vfs_ceph'))
>
> + if conf.CONFIG_SET('HAVE_GLUSTERFS'):
> + default_shared_modules.extend(TO_LIST('vfs_glusterfs'))
> +
> explicit_shared_modules = TO_LIST(Options.options.shared_modules, delimiter=',')
> explicit_static_modules = TO_LIST(Options.options.static_modules, delimiter=',')

I installed glusterfs-devel on my Fedora 18 system, but didn't get
api/glfs.h anywhere. It also seems unlikely that such header name would
be in the default search path, so I'm wondering should we be using some
pkg-config search to find where that would be?

I wanted to at least compile this locally before I put my review
blessing on it, which I was otherwise ready to do, as my other concerns
are addressed.

Thanks,

Andrew Bartlett

--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org