RE: [SCM] Samba Shared Repository - branch v3-3-test updated -release-3-2-0pre2-3053-gd89f9d4

[Jim Brown]

Jeremy

I think you also need to change 'i' from an unsigned to a signed integer
(e.g. int32_t). The loop will decrement through 0 and never stop with 'i'
unsigned.

Jim

-----Original Message-----
From: samba-cvs-bounces+jim.brown=miam...@lists.samba.org
[mailto:samba-cvs-bounces+jim.brown=miam...@lists.samba.org] On Behalf Of
Jeremy Allison
Sent: Tuesday, July 01, 2008 10:29 PM
To: samb...@samba.org
Subject: [SCM] Samba Shared Repository - branch v3-3-test updated
-release-3-2-0pre2-3053-gd89f9d4

The branch, v3-3-test has been updated
via d89f9d404f478fc9887bb6e67ce28a61464bcf93 (commit)
from 534a445df450c681be7da2c9dd65f7294f942b08 (commit)

http://gitweb.samba.org/?p=samba.git;a=shortlog;h=v3-3-test

- Log -----------------------------------------------------------------
commit d89f9d404f478fc9887bb6e67ce28a61464bcf93
Author: Jeremy Allison <j...@samba.org>
Date: Tue Jul 1 15:28:13 2008 -0700

Fix problem noticed by Jim Brown <jim....@miami.edu>. When reverse
searching decrement index,
not increment. Michael please check !
Jeremy.

-----------------------------------------------------------------------

Summary of changes:
source/lib/smbconf/smbconf_util.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

Changeset truncated at 500 lines:

diff --git a/source/lib/smbconf/smbconf_util.c
b/source/lib/smbconf/smbconf_util.c
index b2e253d..aa16369 100644
--- a/source/lib/smbconf/smbconf_util.c
+++ b/source/lib/smbconf/smbconf_util.c
@@ -138,7 +138,7 @@ bool smbconf_reverse_find_in_array(const char *string,
char **list,
return false;
}

- for (i = num_entries - 1; i >= 0; i++) {
+ for (i = num_entries - 1; i >= 0; i--) {
if (strequal(string, list[i])) {
if (entry != NULL) {
*entry = i;

--
Samba Shared Repository

[Jeremy Allison]

On Tue, Jul 01, 2008 at 10:34:52PM -0000, Jim Brown wrote:
>
> Jeremy
>
> I think you also need to change 'i' from an unsigned to a signed integer
> (e.g. int32_t). The loop will decrement through 0 and never stop with 'i'
> unsigned.

Yep, got it - thanks !

Jeremy.