[Bug 5324] Reduce the performance penalty of --xattrs on Mac OS X

0 views
Skip to first unread message

samba...@samba.org

unread,
Jun 6, 2016, 11:03:01 AM6/6/16
to
https://bugzilla.samba.org/show_bug.cgi?id=5324

--- Comment #5 from Björn Jacke <bja...@samba.org> ---
how about adding an option like "--use-ctime-before-xattr-compares", which only
reads and compares EAs for files where the ctime on the source side is newer
than the ctime on the target side. EA modifications update the ctime ususally.
This would be a way to speed up syncing with EAs quite a lot I think.

--
You are receiving this mail because:
You are the QA Contact for the bug.

--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

samba...@samba.org

unread,
Jul 22, 2016, 1:51:22 PM7/22/16
to
https://bugzilla.samba.org/show_bug.cgi?id=5324

--- Comment #6 from Stefan Metzmacher <me...@samba.org> ---
Created attachment 12285
--> https://bugzilla.samba.org/attachment.cgi?id=12285&action=edit
A first work in progress patch to add a hashtable

I need to clean this up and do more tests.

But with 1000 unique xattrs I got 50% less cpu instruction in callgrind.

samba...@samba.org

unread,
Jul 25, 2016, 3:09:46 AM7/25/16
to
https://bugzilla.samba.org/show_bug.cgi?id=5324

Stefan Metzmacher <me...@samba.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #12285|0 |1
is obsolete| |

--- Comment #7 from Stefan Metzmacher <me...@samba.org> ---
Created attachment 12286
--> https://bugzilla.samba.org/attachment.cgi?id=12286&action=edit
valgrind clean work in progress patch

samba...@samba.org

unread,
Jul 25, 2016, 11:20:51 AM7/25/16
to
https://bugzilla.samba.org/show_bug.cgi?id=5324

Stefan Metzmacher <me...@samba.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Attachment #12286|0 |1
is obsolete| |
CC| |way...@samba.org
Attachment #12287| |review?(way...@samba.org)
Flags| |

--- Comment #8 from Stefan Metzmacher <me...@samba.org> ---
Created attachment 12287
--> https://bugzilla.samba.org/attachment.cgi?id=12287&action=edit
Possible patch for master

I hope this is an acceptable patchset to fix the problem for rsync master.
Reply all
Reply to author
Forward
0 new messages