[Bug 12029] Makefile missing dep gives parallel race for rounding.h

0 views
Skip to first unread message

samba...@samba.org

unread,
Jul 20, 2016, 3:22:49 AM7/20/16
to
https://bugzilla.samba.org/show_bug.cgi?id=12029

--- Comment #1 from Greg Whiteley <greg.w...@gmail.com> ---
Created attachment 12280
--> https://bugzilla.samba.org/attachment.cgi?id=12280&action=edit
Patch to depend on generated proto.h for rounding.h

The temporary `rounding` requires rsync.h to be includable, which requires
proto.h to have been pre-generated

Generation of rounding.h seems to be the only exception to the proto.h
dependencies applied by line 96:

> $(OBJS): $(HEADERS)


This is almost certainly a duplicate of bug 10910, however without context in
that error report I cannot be sure.

If they are duplicate then the patch attached to bug 10910 is not correct as
proto.h rsync.h is source and not generated by make, and thus its "up-to-date"
status is dependent on checkout ordering.

--
You are receiving this mail because:
You are the QA Contact for the bug.

--
Please use reply-all for most replies to avoid omitting the mailing list.
To unsubscribe or change options: https://lists.samba.org/mailman/listinfo/rsync
Before posting, read: http://www.catb.org/~esr/faqs/smart-questions.html

samba...@samba.org

unread,
Jul 20, 2016, 11:53:47 AM7/20/16
to
https://bugzilla.samba.org/show_bug.cgi?id=12029

Wayne Davison <way...@samba.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEW |RESOLVED

--- Comment #2 from Wayne Davison <way...@samba.org> ---
I've committed your patch to git for the next release. Thanks!

samba...@samba.org

unread,
Jul 20, 2016, 11:54:27 AM7/20/16
to
https://bugzilla.samba.org/show_bug.cgi?id=12029

Wayne Davison <way...@samba.org> changed:

What |Removed |Added
----------------------------------------------------------------------------
CC| |philipp...@open.eurogic
| |iel.org

--- Comment #3 from Wayne Davison <way...@samba.org> ---
*** Bug 10910 has been marked as a duplicate of this bug. ***
Reply all
Reply to author
Forward
0 new messages