Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

Make remote debugging with KGDB possible

0 views
Skip to first unread message

Simon Perreault

unread,
Dec 15, 2009, 12:56:24 PM12/15/09
to
Hello,

This patch makes remote debugging with KGDB possible. It fixes a known bug, see
e.g. http://kerneltrap.org/mailarchive/openbsd-misc/2008/10/7/3537224.

Simon

P.S. This is my first contribution, please tell me if I did anything wrong.

Index: sys/dev/isa/com_isa.c
===================================================================
RCS file: /cvs/src/sys/dev/isa/com_isa.c,v
retrieving revision 1.4
diff -N -u sys/dev/isa/com_isa.c
--- sys/dev/isa/com_isa.c 24 Oct 2005 14:22:34 -0000 1.4
+++ sys/dev/isa/com_isa.c 15 Dec 2009 17:54:34 -0000
@@ -129,7 +129,7 @@
iobase = ia->ia_iobase;
iot = ia->ia_iot;

-#ifdef KGBD
+#ifdef KGDB
if ((iobase != comconsaddr) &&
(iobase != com_kgdb_addr)) {
#else
--
DNS64 open-source --> http://ecdysis.viagenie.ca
STUN/TURN server --> http://numb.viagenie.ca
vCard 4.0 --> http://www.vcarddav.org

Darrin Chandler

unread,
Dec 15, 2009, 1:04:11 PM12/15/09
to
On Tue, Dec 15, 2009 at 12:56:24PM -0500, Simon Perreault wrote:
> Hello,
>
> This patch makes remote debugging with KGDB possible. It fixes a known bug, see
> e.g. http://kerneltrap.org/mailarchive/openbsd-misc/2008/10/7/3537224.
>
> Simon
>
> P.S. This is my first contribution, please tell me if I did anything wrong.

If this doesn't get picked up then use sendbug(1) including a
description of the problem, how to reproduce, and your patch. In fact,
that's probably the best thing to do anyway. :)

> Index: sys/dev/isa/com_isa.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/isa/com_isa.c,v
> retrieving revision 1.4
> diff -N -u sys/dev/isa/com_isa.c
> --- sys/dev/isa/com_isa.c 24 Oct 2005 14:22:34 -0000 1.4
> +++ sys/dev/isa/com_isa.c 15 Dec 2009 17:54:34 -0000
> @@ -129,7 +129,7 @@
> iobase = ia->ia_iobase;
> iot = ia->ia_iot;
>
> -#ifdef KGBD
> +#ifdef KGDB
> if ((iobase != comconsaddr) &&
> (iobase != com_kgdb_addr)) {
> #else
> --
> DNS64 open-source --> http://ecdysis.viagenie.ca
> STUN/TURN server --> http://numb.viagenie.ca
> vCard 4.0 --> http://www.vcarddav.org
>

--
Darrin Chandler | Phoenix BSD User Group | MetaBUG
dwcha...@stilyagin.com | http://phxbug.org/ | http://metabug.org/
http://www.stilyagin.com/ | Daemons in the Desert | Global BUG Federation

David Coppa

unread,
Dec 15, 2009, 2:04:19 PM12/15/09
to
On Tue, Dec 15, 2009 at 6:56 PM, Simon Perreault
<simon.p...@viagenie.ca> wrote:
> Hello,
>
> This patch makes remote debugging with KGDB possible. It fixes a known bug, see
> e.g. http://kerneltrap.org/mailarchive/openbsd-misc/2008/10/7/3537224.
>
> Simon
>
> P.S. This is my first contribution, please tell me if I did anything wrong.

Looks good. It's a damned typo...
devs: please, commit it.

ciao
-dav

Federico G. Schwindt

unread,
Dec 15, 2009, 5:01:20 PM12/15/09
to
On Tue, Dec 15, 2009 at 12:56:24PM -0500, Simon Perreault wrote:
> Hello,
>
> This patch makes remote debugging with KGDB possible. It fixes a known bug, see
> e.g. http://kerneltrap.org/mailarchive/openbsd-misc/2008/10/7/3537224.
>
> Simon
>
> P.S. This is my first contribution, please tell me if I did anything wrong.

Ops, good catch. Commited.
Thanks!

f.-

0 new messages