Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
Re: PTHREAD_STACK_MIN support
3 views
Skip to first unread message
Christos Zoulas
Jun 23, 2016, 11:29:29 AM6/23/16
to
In article <f0ff615a-91e1-db16...@gmx.com>,
Kamil Rytarowski <n...@gmx.com> wrote:
>On 08.06.2016 09:09, Martin Husemann wrote:
>> Maybe a minor nit:
>>
>> case _SC_THREAD_STACK_MIN:
>> - return _getpagesize();
>> + return PTHREAD_STACK_MIN;
>>
>>
>> I would make that the max() of the two values, and also do the same for
>> the EINVAL test in libpthread. Machines with > 8k pages do exist.
>>
>> Also I am still not convinced we should have this symbol, as my reading
>> of the standard is that our current state is perfectly fine.
>>
>> However, MINSIGSTKSZ is wrong on those machines too, so maybe ignore for
>> now (or mark with XXX comments)?
>>
>> Martin
>>
>
>The point is to abstract this work to determine minimal stack size from
>3rd party software.
>
>Is defining it as per-port value correct?
What should we do with that? Is this patch ok?
https://github.com/ycui1984/posixtestsuite/blob/master/patches/PTHREAD/0003-add-PTHREAD_STACK_MIN.patch
christos
Kamil Rytarowski <n...@gmx.com> wrote:
>On 08.06.2016 09:09, Martin Husemann wrote:
>> Maybe a minor nit:
>>
>> case _SC_THREAD_STACK_MIN:
>> - return _getpagesize();
>> + return PTHREAD_STACK_MIN;
>>
>>
>> I would make that the max() of the two values, and also do the same for
>> the EINVAL test in libpthread. Machines with > 8k pages do exist.
>>
>> Also I am still not convinced we should have this symbol, as my reading
>> of the standard is that our current state is perfectly fine.
>>
>> However, MINSIGSTKSZ is wrong on those machines too, so maybe ignore for
>> now (or mark with XXX comments)?
>>
>> Martin
>>
>
>The point is to abstract this work to determine minimal stack size from
>3rd party software.
>
>Is defining it as per-port value correct?
What should we do with that? Is this patch ok?
https://github.com/ycui1984/posixtestsuite/blob/master/patches/PTHREAD/0003-add-PTHREAD_STACK_MIN.patch
christos
Joerg Sonnenberger
Jun 23, 2016, 1:28:05 PM6/23/16
to
PTHREAD_STACK_MIN and the libc+libpthread code was correct before.
Joerg
Christos Zoulas
Jun 23, 2016, 2:03:09 PM6/23/16
to
On Jun 23, 7:27pm, jo...@bec.de (Joerg Sonnenberger) wrote:
-- Subject: Re: PTHREAD_STACK_MIN support
Ok, I will remove it from the patch.
christos
-- Subject: Re: PTHREAD_STACK_MIN support
christos
0 new messages