Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

ZFS TRIM support MFC

1 view
Skip to first unread message

Tom Evans

unread,
Mar 19, 2013, 10:49:02 AM3/19/13
to
Hi all

I was wondering if there was an anticipated date when the ZFS TRIM
support would be MFC'd to a stable branch?

Cheers

Tom
_______________________________________________
freeb...@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-fs
To unsubscribe, send any mail to "freebsd-fs-...@freebsd.org"

Steven Hartland

unread,
Mar 19, 2013, 10:57:33 AM3/19/13
to
----- Original Message -----
From: "Tom Evans" <teva...@googlemail.com>

> I was wondering if there was an anticipated date when the ZFS TRIM
> support would be MFC'd to a stable branch?

That's likely something that I'll do. I've just finished a round of
patches which are in review ATM and will hopefully get committed
in the next week or two.

After those have had time to bed down in HEAD, another few weeks,
then would be the first point at which this should be MFC'ed IMO.

That said we've been running TRIM on 8.3 for months in production
so if your happy with back porting the changes yourself you should
have no problem doing so. If you happen to be on 8 then I could
provide you with our current patch set.

Regards
Steve

================================================
This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it.

In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337
or return the E.mail to postm...@multiplay.co.uk.

Tom Evans

unread,
Mar 19, 2013, 11:00:43 AM3/19/13
to
On Tue, Mar 19, 2013 at 2:57 PM, Steven Hartland
<kil...@multiplay.co.uk> wrote:
> ----- Original Message ----- From: "Tom Evans" <teva...@googlemail.com>
>
>
>> I was wondering if there was an anticipated date when the ZFS TRIM
>> support would be MFC'd to a stable branch?
>
>
> That's likely something that I'll do. I've just finished a round of
> patches which are in review ATM and will hopefully get committed
> in the next week or two.

Excellent news! I didn't want to hassle anyone over this, but noticed
it was coming up to it's 6 month anniversary on HEAD :)

>
> After those have had time to bed down in HEAD, another few weeks,
> then would be the first point at which this should be MFC'ed IMO.
>
> That said we've been running TRIM on 8.3 for months in production
> so if your happy with back porting the changes yourself you should
> have no problem doing so. If you happen to be on 8 then I could
> provide you with our current patch set.

I'm on 9. I saw your big list of patches for 8.3, but I was concerned
that I wouldn't know which ones are necessary, which ones are not, and
which ones had already been merged to 9. I'm happy to wait!

Cheers

Tom

Tom Evans

unread,
May 23, 2013, 10:10:01 AM5/23/13
to
On Tue, Mar 19, 2013 at 2:57 PM, Steven Hartland
<kil...@multiplay.co.uk> wrote:
> ----- Original Message ----- From: "Tom Evans" <teva...@googlemail.com>
>
>
>> I was wondering if there was an anticipated date when the ZFS TRIM
>> support would be MFC'd to a stable branch?
>
>
> That's likely something that I'll do. I've just finished a round of
> patches which are in review ATM and will hopefully get committed
> in the next week or two.
>
> After those have had time to bed down in HEAD, another few weeks,
> then would be the first point at which this should be MFC'ed IMO.
>
> That said we've been running TRIM on 8.3 for months in production
> so if your happy with back porting the changes yourself you should
> have no problem doing so. If you happen to be on 8 then I could
> provide you with our current patch set.
>

Hi Steven

Just wondering if an MFC of these TRIM features to 9 is any closer.

Steven Hartland

unread,
May 23, 2013, 10:26:29 AM5/23/13
to
----- Original Message -----
From: "Tom Evans"
> Hi Steven
>
> Just wondering if an MFC of these TRIM features to 9 is any closer.

Yes, I've created the MFC patches for stable 8 & 9 but we're just looking
to close out an issue reported by Ajit Jain thread "seeing data corruption
with zfs trim functionality" on freebsd-fs@

My current thinking is this is due to either a LSI FW issue, related to a
know WS16 bug or potentially a merge problem, as Ajit wasn't using
our code base directly.

I posted the two main patch sets I'm looking to commit to that thread
this morning, your welcome to test and let us know how you get on.

If you are using LSI mps controllers, either ensure your using P16 FW
or don't manually select Write Same delete methods for your disks
to avoid the know FW bug which will cause corruption.

Regards
Steve

================================================
This e.mail is private and confidential between Multiplay (UK) Ltd. and the person or entity to whom it is addressed. In the event of misdirection, the recipient is prohibited from using, copying, printing or otherwise disseminating it or any information contained in it.

In the event of misdirection, illegible or incomplete transmission please telephone +44 845 868 1337
or return the E.mail to postm...@multiplay.co.uk.

0 new messages