Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

Re: bin/152154: script(1) -k malfunctions with certain shells (e.g. tcsh, bash, zsh)

2 views
Skip to first unread message

Kurt Jaeger

unread,
May 10, 2013, 5:36:10 PM5/10/13
to
Hi!

> http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/152154
>
> It has been suggested to me (by a committer) that I should raise the
> issue of this PR here on these lists, because the problem described
> within the PR remains a real problem, and despite my having proposed
> something that seems to be a perfectly workable fix, no action has
> been taken on this PR for some years now.

Having looked at the PR, may I suggest that you look at sysutils/screen
and screen -L especially instead of script -k -- and add some
input logging to screen ? Or, for the tmux fraction, at sysutils/tmux ?

I'm not sure why you absolutly *need* the input logging -- can you
describe the use case ? Is it some security-audit-issue ?

--
p...@opsec.eu +49 171 3101372 7 years to go !
_______________________________________________
freebsd...@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/freebsd-current
To unsubscribe, send any mail to "freebsd-curre...@freebsd.org"

Ronald F. Guilmette

unread,
May 10, 2013, 4:59:49 PM5/10/13
to

http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/152154

It has been suggested to me (by a committer) that I should raise the
issue of this PR here on these lists, because the problem described
within the PR remains a real problem, and despite my having proposed
something that seems to be a perfectly workable fix, no action has
been taken on this PR for some years now.


Regards,
rfg


P.S. The following additional PRs, also filed by me and also relating to
the script(1) command, supply some additional improvements to efficiency
and code clarity.

http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/152131
http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/152132

Ronald F. Guilmette

unread,
May 10, 2013, 6:10:32 PM5/10/13
to

In message <2013051021...@home.opsec.eu>, you wrote:

>> http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/152154
>>
>> It has been suggested to me (by a committer) that I should raise the
>> issue of this PR here on these lists, because the problem described
>> within the PR remains a real problem, and despite my having proposed
>> something that seems to be a perfectly workable fix, no action has
>> been taken on this PR for some years now.
>
>Having looked at the PR, may I suggest that you look at sysutils/screen
>and screen -L especially instead of script -k -- and add some
>input logging to screen ? Or, for the tmux fraction, at sysutils/tmux ?

Where I come from, we have a very common saying "It's a free country!"

Thus, you may indeed make that suggestion. In fact you are free to
suggest anything you like.

Unfortunately, I currently already have an overflowing TO-DO list and I
am not taking anything more onto my own personal plate at this time.

>I'm not sure why you absolutly *need* the input logging -- can you
>describe the use case ? Is it some security-audit-issue ?

I really do not intend to be at all rude, but...

I'm not sure why you are asking _me_ to defend the existance of the
script -k option. I probably could do so, but that is rather besides
the point, I think. The option exists, and has existed, for quite a
long time. At some time in the ancient past, presumably when dinosaurs
(and perhaps even Richie, Thompson, & Kernighan) roamed the earth,
someone somewhere thought that being able to have script(1) log both
input and output was a Good Idea[tm] and the -k option was born.
Unfortunately, in FreeBSD, that option is buggy. It doesn't work right.
It doesn't work according to specification. I proposed a way (code)
to fix that. That's all. If you want to debate the merits of the
very existance of the script program, or any option thereof, I'll be
more than happy to do so anytime over a beer... as long as you are
buying.

In the meantime may I suggest that the easily verifiable bug that I
originally filed a PR on should be fixed?


Regards,
rfg

Eitan Adler

unread,
May 11, 2013, 6:54:26 PM5/11/13
to
On 10 May 2013 16:59, Ronald F. Guilmette <r...@tristatelogic.com> wrote:
>
> http://www.freebsd.org/cgi/query-pr.cgi?pr=bin/152154
>
> It has been suggested to me (by a committer) that I should raise the
> issue of this PR here on these lists, because the problem described
> within the PR remains a real problem, and despite my having proposed
> something that seems to be a perfectly workable fix, no action has
> been taken on this PR for some years now.

By the way, it will go a long way to helping get some site on these
PRs, if you provide diffs in 'unified diff' form (diff -u) instead of
context diff form.

I have been recently looking for old PRs with patches attached. :)

--
Eitan Adler

Eitan Adler

unread,
May 11, 2013, 6:54:26 PM5/11/13
to
0 new messages