1.0.3-snapshot is dirty

Sven Wesley

unread,

Mar 14, 2012, 12:14:37 PM3/14/12

to magja-...@googlegroups.com

We have a set of files changed in a local branch of 0.0.2, and I planned to move to the master branch and bring the changes. I found references to com.wonder.integration-attributes in MagentoServiceContext.xml, to me the branch is dirty with business logic values that should be kept out of the framework and it doesn't follow the documentation of the framework (props of magento-api.properties have no effect).

Anyone disagree?

Regards,

Sven

Hendy Irawan

unread,

Mar 14, 2012, 12:22:14 PM3/14/12

to magja-...@googlegroups.com

Thank you Sven.

I'd be thankful if you could make the necessary cleanups.

Hendy

Sven Wesley

unread,

Mar 14, 2012, 12:23:47 PM3/14/12

to magja-...@googlegroups.com

Ok. I'll add that to my change list.

Sven Wesley

unread,

Mar 14, 2012, 4:51:13 PM3/14/12

to magja-...@googlegroups.com

If course, i can't push to the master.

Can someone give me permission or were should I push the changes?

Regards,

Sven

2012/3/14 Sven Wesley <svenn...@gmail.com>

Hendy Irawan

unread,

Mar 14, 2012, 4:56:33 PM3/14/12

to magja-...@googlegroups.com

Please create a pull request.

Thank you Sven!

Hendy

Reply all

Reply to author

Forward