Default value of magit-revert-item-confirm

[Rémi Vanicat]

Hello list,

Before doing it, I wonder if we should change the default value of
magit-revert-item-confirm: now the default value is set as to not change
habit of old users, but it failed to protect new user or old user that
don't know the change from accidentally destroying some of their data.

What do you think? (I'm in favor of the second solution).
--
Rémi Vanicat

[Dave Abrahams]

At Sun, 16 Jan 2011 09:53:20 +0100,
Rémi Vanicat wrote:
>
> Rémi Vanicat <van...@debian.org>
> Subject: Default value of magit-revert-item-confirm
> Date: Sun, 16 Jan 2011 09:53:20 +0100
> To: ma...@googlegroups.com
> Message-ID: <87r5cdd...@debian.org>
> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
> List-Post: <http://groups.google.com/group/magit/post?hl=en_US>, <mailto:ma...@googlegroups.com>

+1 on #2

--
Dave Abrahams
BoostPro Computing
http://www.boostpro.com

[Philip Jackson]

At Sun, 16 Jan 2011 09:53:20 +0100,
Rémi Vanicat wrote:

If the second solution is making `magit-revert-item-confirm' t by
default then, yep, go for it.

Cheers,
Phil

[Bradley]

On Jan 16, 8:34 am, Philip Jackson <p...@shellarchive.co.uk> wrote:
> If the second solution is making `magit-revert-item-confirm' t by
> default then, yep, go for it.

I agree. I've been using magit for quite some time, but just got
bitten by this, as I was hitting C-v to scroll through a change,
slipped my finger off the CTRL key, and lost a days' set of a changes
to a file. It was even worse that a ~ backup wasn't even created,
despite having Emacs set up to always create ~ backups. I've now set
magit-revert-item-confirm to t in my .emacs, but I'd encourage it to
be the default.

[Rémi Vanicat]

Bradley <bradl...@gmail.com> writes:

It's already done in magit's git. It will be the default value in the
next release.

--
Rémi Vanicat