Releasing on Friday

[Chris Forsythe]

Folks,

I'm going to be releasing a tarball of the current state of the repo
on Friday, unless anything else needs to make that wait. I fully
intended to let the new psmtab patches block the release, but it's
been a week without any comment on those, so it's not a legitimate
blocker. I'm giving it until Friday to make sure enough time is given
for those patches.

Chris

[Keith Malkin]

Hi Chris, I find it frustrating to hear that the code may be released
without my issues even being evaluated. Recently I have uncovered two
more meaningful, easily reproduced issues. I haven't posted reports
on them yet, but now I have to wonder whether I should bother.

[Chris Forsythe]

If you haven't posted them, you have no right to be angry if they
aren't addressed. If you file the tickets and they are a crasher or
reveal a huge life altering bug, that can block a release. However,
based on your explation in the ticket that hasn't been technically
reviewed yet, this doesn't seem to be the case. I am not a developer,
I am the project manager so I cannot review patches. We have a ticket
system so that all issues can be vetted by the proper developers. If
you fail to file a ticket we will not address an issue. Furthermore at
this time I do not feel that your issues should block a release.

My email to the list is not an end all, be all kind of email, we are
flexible. However, we do need to put out a release, and this will be
the fourth week where I said to someone that we're putting out a
release and it hasn't happened.

I'd prefer if you'd keep posting bugs and patches though, I think it
really helps this project and the mac community in general. I think
the rule is 3 accepted major patches for a commit bit, and you are
well on your way to that.

Chris

[Keith Malkin]

Hi Chris, I will not be angry if issues I don't post are not
addressed. But I am frustrated that issues I have already posted may
not be reviewed before release. I said before that I didn't want to
spend time posting issues if my efforts would not lead to something.
The state of my current issues (1 for 3) does not encourage me to
spend the time to post the new ones. That said, I don't mean to sound
ungrateful. I do appreciate your efforts. Hopefully you can get the
rest of my issues reviewed sometime soon.

[Kent Sutherland]

Keith,

I'm taking a look at issue #21 right now. Also, the background redraw
issue only seems to manifest itself when using the unified tab style.
I can't reproduce it with any of the other styles. It looks like there
is possibly an issue with the patch for #21 also, as visible in http://www.ksuther.com/adium/issue21.mov
.

I never used the unified tab style myself, so I'm not sure if the
separator line is supposed to draw when the window is inactive. It's
obviously there in the code, so my guess is that this is on purpose,
but I'd like to double-check.

The patch for #20 overall seems to make sense to me, but I haven't
gone over the code myself and I'm not going to be the one to merge in
the changes to PSMTabBarControl without someone from Adium making the
change on their side too.

Kent Sutherland

[Keith Malkin]

Hey Kent, thanks for looking at my issues. I'll respond to your
comments on issue #21 in the report itself... Thanks again!

[Chris Forsythe]

Don't get me wrong Keith, but filing a report, even with a patch,
doesn't guarantee that it will be in the next release.

Chris