Hey,
On Friday 12 Apr 2013, Daniel Cabarcas wrote:
> Hi,
>
> I pushed a small change, but here are some issues I wanted to discuss
> before addressing:
>
> Line 295: I think it should be dimension 'n' and not phi(n).
> Moreover, I think we should be consistent in the use of n as the dimension.
> For example in DiscreteGaussianPolynomialSamplerRejection, I think we
> should use n to denote the degree of the cyclotomic and a different letter,
> say N to denote the index of the cyclotomic, i.e. n=phi(N).
> This is important when defining RingLWE, because as it stands right now,
> the underlying lattice dimension is phi(n) instead of n, so the security
> parameter should be phi(n), which creates some confusion.
+1
> line 553: I don't understand why classes RingLWE1 and RingLWE2 are
> necessary
Me neither :)
> line 679: perhaps it is better not to restart i to 0, and instead use
> $i\mod n$ for indexing. The reason is compatibility with the option of
> limiting the number of samples as in the LWE generator.
Good catch.
Go ahead with the fixes of (1) and (3) I'd say.
Cheers,
Martin
--
name: Martin Albrecht
_pgp:
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x8EF0DC99
_otr: 47F43D1A 5D68C36F 468BAEBA 640E8856 D7951CCF
_www:
http://martinralbrecht.wordpress.com/
_jab:
martinr...@jabber.ccc.de