Re: conf/143851: [patch] Some rc.d scripts confuse NO with NONE
lin...@freebsd.org
New Synopsis: [patch] Some rc.d scripts confuse NO with NONE
Responsible-Changed-From-To: freebsd-bugs->freebsd-rc
Responsible-Changed-By: linimon
Responsible-Changed-When: Sat Feb 13 05:09:22 UTC 2010
Responsible-Changed-Why:
Over to maintainer(s).
Markus Hitter
From: Markus Hitter <m...@jump-ing.de>
To: bug-fo...@FreeBSD.org, m...@jump-ing.de
Cc:
Subject: Re: conf/143851: [patch] Some rc.d scripts confuse NO with NONE
Date: Sat, 13 Feb 2010 16:05:13 +0100
--=-ywTpx/vr0wFCqMjxhEQE
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Glen Barber kindly explained what's going on:
> In rc.conf, sendmail="NO" allows outbound-only mail.
> sendmail="NONE" tells sendmail not to send mail out at all.
>
> sendmail="NO" is useful when sending system mail out is
> necessary, but the machine is not intended to receive mail.
Apparently, the comment in line 510 in /etc/defaults/rc.conf has room
for improvement. It should mention all three instead of only two
options. I've added a new patch and hope this can be applied to FreeBSD
8 & 9 as well.
--=-ywTpx/vr0wFCqMjxhEQE
Content-Disposition: attachment; filename="rc.conf.diff"
Content-Type: text/x-patch; name="rc.conf.diff"; charset="UTF-8"
Content-Transfer-Encoding: 7bit
--- /etc/defaults/rc.conf 2009-01-30 18:35:32.000000000 +0200
+++ /etc/defaults/rc.conf.patched 2010-02-13 14:58:05.000000000 +0200
@@ -507,7 +507,8 @@
mta_start_script="/etc/rc.sendmail"
# Script to start your chosen MTA, called by /etc/rc.
# Settings for /etc/rc.sendmail and /etc/rc.d/sendmail:
-sendmail_enable="NO" # Run the sendmail inbound daemon (YES/NO).
+sendmail_enable="NO" # Run the sendmail daemon:
+ # YES=inbound+outbound, NO=outbound only, NONE=neither.
sendmail_pidfile="/var/run/sendmail.pid" # sendmail pid file
sendmail_procname="/usr/sbin/sendmail" # sendmail process name
sendmail_flags="-L sm-mta -bd -q30m" # Flags to sendmail (as a server)
--=-ywTpx/vr0wFCqMjxhEQE--
Garrett Cooper
From: Garrett Cooper <gco...@FreeBSD.org>
To: bug-fo...@FreeBSD.org, m...@jump-ing.de
Cc:
Subject: Re: conf/143851: [patch] Some rc.d scripts confuse NO with NONE
Date: Sat, 13 Feb 2010 10:55:53 -0800
As noted by brucec, the rc.sendmail(8) manpage already mentions NO
vs NONE's use:
sendmail_enable
(str) If set to ``YES'', run the sendmail(8) daemon at system
boot time. If set to ``NO'', do not run a sendmail(8) daemon to
listen for incoming network mail. This does not preclude a
sendmail(8) daemon listening on the SMTP port of the loopback
interface. The ``NONE'' option is deprecated and should not be
used. It will be removed in a future release.
# ...
# MTA
if (${sendmail_enable} == NONE)
# Do nothing
else if (${sendmail_enable} == YES)
start sendmail with ${sendmail_flags}
else if (${sendmail_submit_enable} == YES)
start sendmail with ${sendmail_submit_flags}
else if (${sendmail_outbound_enable} == YES)
start sendmail with ${sendmail_outbound_flags}
endif
# MSP Queue Runner
if (${sendmail_enable} != NONE &&
[ -r /etc/mail/submit.cf] &&
${sendmail_msp_queue_enable} == YES)
start sendmail with ${sendmail_msp_queue_flags}
endif
So the option can be removed eventually, but not today...
Thanks,
-Garrett
Markus Hitter
From: Markus Hitter <m...@jump-ing.de>
To: Garrett Cooper <gco...@FreeBSD.org>
Cc: bug-fo...@FreeBSD.org
Subject: Re: conf/143851: [patch] Some rc.d scripts confuse NO with NONE
Date: Sat, 13 Feb 2010 20:19:23 +0100
Am 13.02.2010 um 19:55 schrieb Garrett Cooper:
> As noted by brucec, the rc.sendmail(8) manpage already mentions NO
> vs NONE's use:
Fully agreed rc.conf isn't the right place for exhaustive
documentation. The current comment for sendmail_enable isn't correct,
though. This variable doesn't offer the choice between YES and NO,
but between YES and NO and NONE. Removing this comment entirely would
be a solution as well.
bru...@freebsd.org
State-Changed-From-To: open->closed
State-Changed-By: brucec
State-Changed-When: Mon Feb 15 15:45:48 UTC 2010
State-Changed-Why:
This is documented behaviour: rc.conf(5) has links to
rc.sendmail(8) which document the sendmail_* variables.
That page documents the "NONE" setting as disabling sendmail
altogether, while the "NO" setting just disables listening for
incoming mail.