Trivial PR, fix shutdown of rc services started with onestart

2 views
Skip to first unread message

Dominic Fandrey

unread,
Apr 10, 2010, 5:33:35 AM4/10/10
to freebsd...@freebsd.org
This morning I took a look at my outstanding PRs. There
is a PR I consider old and trivial:

This one proposes a change that always treats rc script execution
of active services as if <service>_enable="YES" was set.
This ensures, among other things, a clean shutdown procedure for
services started with onestart:
http://www.freebsd.org/cgi/query-pr.cgi?pr=conf/130414

Regards

--
A: Because it fouls the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing on usenet and in e-mail?

John Baldwin

unread,
Apr 12, 2010, 10:53:34 AM4/12/10
to freebsd...@freebsd.org, Dominic Fandrey
On Saturday 10 April 2010 5:33:35 am Dominic Fandrey wrote:
> This morning I took a look at my outstanding PRs. There
> is a PR I consider old and trivial:
>
> This one proposes a change that always treats rc script execution
> of active services as if <service>_enable="YES" was set.
> This ensures, among other things, a clean shutdown procedure for
> services started with onestart:
> http://www.freebsd.org/cgi/query-pr.cgi?pr=conf/130414

You might want to send this to freebsd-rc@ if no one responds.

--
John Baldwin

Dominic Fandrey

unread,
Apr 12, 2010, 11:17:16 AM4/12/10
to John Baldwin, freebsd...@freebsd.org

Considering that they are the responsible party, do they not
get notified by GNATS whenever I submit a follow-up to the PR?

John Baldwin

unread,
Apr 12, 2010, 11:48:07 AM4/12/10
to Dominic Fandrey, freebsd...@freebsd.org
On Monday 12 April 2010 11:17:16 am Dominic Fandrey wrote:
> On 12/04/2010 16:53, John Baldwin wrote:
> > On Saturday 10 April 2010 5:33:35 am Dominic Fandrey wrote:
> >> This morning I took a look at my outstanding PRs. There
> >> is a PR I consider old and trivial:
> >>
> >> This one proposes a change that always treats rc script execution
> >> of active services as if <service>_enable="YES" was set.
> >> This ensures, among other things, a clean shutdown procedure for
> >> services started with onestart:
> >> http://www.freebsd.org/cgi/query-pr.cgi?pr=conf/130414
> >
> > You might want to send this to freebsd-rc@ if no one responds.
> >
>
> Considering that they are the responsible party, do they not
> get notified by GNATS whenever I submit a follow-up to the PR?

Ah, in that case they probably do. Still, if they don't reply to the PR e-
mail that list does seem to respond quickly to direct e-mails in my
experience. :)

--
John Baldwin

Miroslav Lachman

unread,
Apr 12, 2010, 12:45:50 PM4/12/10
to John Baldwin, Dominic Fandrey, freebsd...@freebsd.org
John Baldwin wrote:
> On Monday 12 April 2010 11:17:16 am Dominic Fandrey wrote:
>> On 12/04/2010 16:53, John Baldwin wrote:

[...]

>> Considering that they are the responsible party, do they not
>> get notified by GNATS whenever I submit a follow-up to the PR?
>
> Ah, in that case they probably do. Still, if they don't reply to the PR e-
> mail that list does seem to respond quickly to direct e-mails in my
> experience. :)

I have bad experiences with freebsd-rc mailing list - no responses to my
direct e-mails and no responses for PRs (PR sent more than year ago,
direct e-mails 3 month ago without any reaction).
I don't know who is responsible person for rc system and related PRs,
but it seems there is not enough man power to check/take/commit/or close
PRs related to rc.

Miroslav Lachman

Doug Barton

unread,
Apr 12, 2010, 1:40:28 PM4/12/10
to Miroslav Lachman, Dominic Fandrey, freebsd...@freebsd.org
On 4/12/2010 9:45 AM, Miroslav Lachman wrote:
> I have bad experiences with freebsd-rc mailing list - no responses to my
> direct e-mails and no responses for PRs (PR sent more than year ago,
> direct e-mails 3 month ago without any reaction).
> I don't know who is responsible person for rc system and related PRs,
> but it seems there is not enough man power to check/take/commit/or close
> PRs related to rc.

... like everything else in a volunteer project. :) I personally try to
comment on the 2 tails of the bell-shaped curve, things that look
interesting, or things that I oppose. For everything else in the vast
middle ground I generally wait to see if someone else expresses interest
in it.

Regarding your 2 open PRs, the first is a jail thing, and I have no
experience with jails and don't feel competent to comment. Your cpu
affinity patch looks interesting, but not enough to take my attention
away from the 34 other things that are currently in my queue.

So, please don't take it personally. :) freebsd-rc@ is still the best
place to start a discussion about rc.d-related stuff, but that doesn't
mean that other forums can't be used as well.


hth,

Doug

--

... and that's just a little bit of history repeating.
-- Propellerheads

Improve the effectiveness of your Internet presence with
a domain name makeover! http://SupersetSolutions.com/

Miroslav Lachman

unread,
Apr 12, 2010, 4:43:08 PM4/12/10
to Doug Barton, freebsd...@freebsd.org
Doug Barton wrote:
> On 4/12/2010 9:45 AM, Miroslav Lachman wrote:
>> I have bad experiences with freebsd-rc mailing list - no responses to my
>> direct e-mails and no responses for PRs (PR sent more than year ago,
>> direct e-mails 3 month ago without any reaction).
>> I don't know who is responsible person for rc system and related PRs,
>> but it seems there is not enough man power to check/take/commit/or close
>> PRs related to rc.
>
> ... like everything else in a volunteer project. :) I personally try to
> comment on the 2 tails of the bell-shaped curve, things that look
> interesting, or things that I oppose. For everything else in the vast
> middle ground I generally wait to see if someone else expresses interest
> in it.

If you are the only one person responsible for all rc stuff, then I
understand that you cannot take each of them. I know you are hard
working on other FreeBSD parts, so one person is not enough. :(

> Regarding your 2 open PRs, the first is a jail thing, and I have no
> experience with jails and don't feel competent to comment.

I directly asked BZ with jail related PR if he can take it or close it
with some denying comment, but again without reply.
It is not good that there are old PRs without any response. It tends to
duplicate PRs etc.

> Your cpu
> affinity patch looks interesting, but not enough to take my attention
> away from the 34 other things that are currently in my queue.

As I wrote above, I understand that one person cannot do it all.

There are other persons with similar patches to bring some new features
in to rc.subr

http://lists.freebsd.org/pipermail/freebsd-rc/2010-January/001816.html
http://lists.freebsd.org/pipermail/freebsd-rc/2010-March/001877.html

> So, please don't take it personally. :) freebsd-rc@ is still the best
> place to start a discussion about rc.d-related stuff, but that doesn't
> mean that other forums can't be used as well.

I tried to start some discussion about that things. I would like to
learn more about FreeBSD rc stuff, but it is hard if nobody replied to
my proposals / questions [1] / ideas.

I also sent some proposal of iSCSI initiator rc script [2]. iSCSI
initiator kernel module and userland binaries are in FreeBSD for a long
time, but it is "useless" without rc scipt - again, without any response.
I would like to write the script right and finish it to the commitable
state, but it is hard without support of somebody skilled / without
comments and discussion.

[1] bgfsck vs. background-fsck
http://lists.freebsd.org/pipermail/freebsd-rc/2010-January/001814.html

[2] rc script for iSCSI initiator
http://lists.freebsd.org/pipermail/freebsd-rc/2010-January/001841.html

Miroslav Lachman

Reply all
Reply to author
Forward
0 new messages