Some thoughts.
Digy
Just some thoughts about the codes in trunk.
* lucere.definition.toolkit.cache
-this could have more .NET-like interface
void Add(TKey key, TValue value);
TValue this[TKey key] { get; set; }
* lucere.stream.diagnostic.IStatus
-Names seem like a method names, rather than properties.
* lucere.stream.diagnostic.IFieldNormStatus
-TotFields --> TotalFields
-Error --> a method like SetError sounds better.
*
lucere.definition.stream.IByteBlockPool.cs
lucere.definition.stream.IByteSliceReader
lucere.definition.stream.IByteSliceWriter
lucere.definition.stream.IByteBlockPool
lucere.definition.stream.ICharBlockPool
-They are not base classes. No need for interfaces
* lucere.definition.stream.ITermEnum
instead of having a method like "bool Next()"
it could be something like
"public interface ITermEnum : IEnumerator<ITerm>"
DIGY
Troy Howard
Thanks for the feedback. I went ahead and applied those changes and
updated a few more things based on them. All very good suggestions!
Regarding "IByteBlockPool ... They are not base classes. No need for
interfaces":
We are currently creating interfaces for every class, even if it is
not a base class. The goal is to have the entire object model
abstracted into interfaces so that we can test and refactor against
that abstraction without concern for the details of implementation. It
facilitates easier refactoring and mocking during unit testing to
improve the quality of those tests.
There will be a lot of seemingly useless interfaces because of this.
Thanks,
Troy
> --
> You received this message because you are subscribed to the Google Groups
> "Lucere" group.
> To post to this group, send email to luc...@googlegroups.com.
> To unsubscribe from this group, send email to
> lucere+un...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/lucere?hl=en.
>