Experiences from the lastest pull-requests

[Kristian Klausen]

Hi!

I have a few comments on the pull-request process that I've had in the previous days.

Would it be a good practice to start the pull-request with the new IMC-messages only (if any), and agree on those before adding the rest of the code?

As a practice, will you let me know if you fetch the branch? So I can rebase-force push for a cleaner log.


Thank you for your help along the way, Ricardo and João!

[Ricardo Martins]

Hi,

On Wed, Feb 12, 2014 at 2:12 PM, Kristian Klausen <kkn...@gmail.com> wrote:
> Hi!
>
> I have a few comments on the pull-request process that I've had in the
> previous days.
>
> Would it be a good practice to start the pull-request with the new
> IMC-messages only (if any), and agree on those before adding the rest of the
> code?

Yes. I would prefer that. Start with a pull request to the IMC
repository, then you can discuss the messages a little bit and go from
there. We want to have an expressive set of messages, but keeping them
as generic as possible, otherwise things will go awry very quickly.

>
> As a practice, will you let me know if you fetch the branch? So I can
> rebase-force push for a cleaner log.

I'm merging the branch as we speak. I'll do it manually because I'm
also reviewing your changes. In the future I would recommend you don't
commit IMC generated files, we can always generate them before merging
and we avoid conflicts that way. I'll tell you when the merge is
complete.

>
>
> Thank you for your help along the way, Ricardo and João!
>

> --
> You received this message because you are subscribed to the Google Groups
> "LSTS Toolchain" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to lsts-toolchai...@googlegroups.com.
> Visit this group at http://groups.google.com/group/lsts-toolchain.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/lsts-toolchain/e889d4c8-15d0-49c2-9dd7-e2fa6b508a63%40googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[Ricardo Martins]

As you may have noticed, I've merge your changes. Thank you very much
for the contributions. We recently changed our commit message style,
check the rules here:

https://github.com/LSTS/dune/wiki/Git%3A-Commit-Messages

Tomorrow at around 11:00 you can check if your changes compiled
successfully on several operating systems/compilers:

http://www.lsts.pt/cdash/index.php?project=DUNE

[Ricardo Martins]

It was almost flawless, but DUNE failed to build on Solaris Studio.
Fixed in 3e98e8370ef063e8ce2d0c545b03696e42a0c0bb and
0d903d4791b0bc6ffb7d87f8bd4e341ecb9e6fdd.

[Kristian Klausen]

Auch, hehe. Well thanks!

[Ricardo Martins]

It's very easy to overlook some details, that's why we have nightly
builds on so many systems. You should look at the tool 'valgrind',
it's great to find memory leaks. With that said, we do have a system
here that requires everyone that breaks a nightly build to pay a round
of beers to the rest of the team ;)

> https://groups.google.com/d/msgid/lsts-toolchain/7322d064-88d0-445b-986d-9f77f651281f%40googlegroups.com.

[Kristian Klausen]

Haha, I'll be sure to buy you guys two rounds the next time I'm in Porto ;)