Problem with terminal settings on leaving loop shell

7 views
Skip to first unread message

Rob Carey

unread,
Jul 29, 2012, 1:28:24 PM7/29/12
to loop...@googlegroups.com
On both Linux and MacOS when I exit the loop shell (I generally use ^D) I find that echo has been turned off in my terminal driver.  I don't know jline.ConsoleReader at all, but making a naive assumption and adding a call to reader.getTerminal().restore() in quit() appears to fix the problem.  Is no one else seeing that behavior?

kfb

unread,
Jul 29, 2012, 4:45:10 PM7/29/12
to looplang
I get the same behaviour on Mac OS X, and your fix also works for me.
Are you going to submit a patch?

Dhanji R. Prasanna

unread,
Jul 29, 2012, 5:00:30 PM7/29/12
to loop...@googlegroups.com
Thanks! I've submitted this fix, if you update and run rerepl.sh you should get a fresh build. I will also do a release in a moment.

kfb

unread,
Jul 29, 2012, 5:42:54 PM7/29/12
to looplang
> Thanks! I've submitted this fix, if you update and run rerepl.sh you should
> get a fresh build. I will also do a release in a moment.

Got it, thanks!

Rob Carey

unread,
Jul 29, 2012, 5:57:59 PM7/29/12
to loop...@googlegroups.com
I think the fix needs to be a level lower to work for both :q and ^D, no?  

Dhanji R. Prasanna

unread,
Jul 29, 2012, 6:05:03 PM7/29/12
to loop...@googlegroups.com
You're right! Done.
Reply all
Reply to author
Forward
0 new messages