[PATCH] Add support for quoted format strings

0 views
Skip to first unread message

John-Mark Bell

unread,
Mar 22, 2010, 11:46:41 AM3/22/10
to log...@googlegroups.com
Hi,

I've been investigating log4erl a little recently and, in doing so,
discovered that quoted format strings were not supported.

For example:

format = "Some log message, containing a comma"

would result in a failure to parse the configuration file.

The attached patch adds support for strings quoted with either double or
single quotes. The body of a quoted string is permitted to be all
characters found in LS along with '{', '}' ',', '=', and whichever quote
character is not being used to quote the string.

I've not made any attempt to support escape sequences.

I hope this is of some use.


John-Mark.

--
TANDBERG Telecom UK Ltd
Registered in England and Wales No: 3390345.
Registered address:
Unit 2 Pine Trees, Chertsey Lane, Staines, Middlesex, TW18 3HR.

01-lex-string.patch

Ahmed Ali

unread,
Mar 22, 2010, 1:02:33 PM3/22/10
to log...@googlegroups.com
Hi Mark,

Thanks a lot for the patch. I was under the imporession that log4erl
currently supported quoted formats. Appearntly, deleted it in the
latest version. Will upload this one to svn and github soon.

Best regards,

Ahmed Al-Issaei

> --
> You received this message because you are subscribed to the Google Groups "Log4erl" group.
> To post to this group, send email to log...@googlegroups.com.
> To unsubscribe from this group, send email to log4erl+u...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/log4erl?hl=en.
>
>

Ahmed Ali

unread,
Apr 16, 2010, 5:21:59 PM4/16/10
to log...@googlegroups.com
Hi John-Mark,

Both of your code patches (the one regarding milliseconds and this
one) are in the github repository now.

Best regards,

Ahmed
Reply all
Reply to author
Forward
0 new messages