Revisiting issue 1485 for large (or long) files

[nc...@icloud.com]

Hey there,

Thank you for jumping on issue #1485 so quickly! The fix in the latest RC 5 definitely works for the general case, but it seems to cause lnav’s Top Of View/Bottom of View commands (g/G) to crash/hang indefinitely in some cases, perhaps larger/longer log files. I have attached my relevant crash log file and included possible repro steps, although to be clear, I’m only guessing that the size or length is responsible here. It might be worth reopening #1485 in the meantime, if that’s useful to you for tracking purposes.

To repro with the latest RC build 5:

• With lnav open for a non-trivial file (~600k lines, ~65M) and time-column enabled (:config /ui/views/log/time-column default), and word-wrap OFF.
• Navigate to the bottom of the file by pressing G.
• Toggle word wrap ON with ctrl+m.
• Observe that you can still navigate up & down one line at a time (via j/k or up/down).
• Try to navigate to the top of the file with g.
• Observe that lnav is now unresponsive. I have tried waiting upwards of a minute, and it seems the only way to recover is to quit with ctrl-c.

Thank you again for working so quickly to solve the issue; it definitely seems close! And time-column has been a really valuable addition, so I’m looking forward to the feature.

Cheers