LLVM Developers mailing list
If there aren't huge objections - I'll probably start this in the next O(weeks).
Hey folks - I'm/we're considering a somewhat laborious/disruptive refactoring for MemoryBuffer's APIs to improve error handling safety. Details here: https://reviews.llvm.org/D109345
Duncan's pointed out that a reasonable migration strategy would be to:(this isn't the only option (some variations discussed on the code review) - but something along these lines that separates the semantic changes from the renaming and makes it easier for folks with stable release branches to still cherry pick pieces of this without other pieces (eg: they can pick any amount of 1-4 without 5, specifically they could take 1-2, do a mass-rename on their branch of "MemoryBuffer:: -> MemoryBufferErrorCodeAPI::" and then be pretty stable/relatively easy to cherry pick things after that)
What do folks think of this? Any major objections (including "the churn doesn't seem worth the benefit" - happy to discuss that further), nuanced situations/tweaks/particular scenarios that we should make an effort to account for?
This looks like a reasonable plan, but what is the timeline for going from 1 to 5?
On top of the extra churn involved, I'd be wary of situations where the two APIs coexisted for too long, so hopefully O(weeks) and not O(months)?