[llvm-dev] How to trigger builds in Phabricator?

Ehud Katz via llvm-dev

unread,

Nov 21, 2019, 3:23:48 AM11/21/19

to llvm...@lists.llvm.org

Hi everyone,

In the reviewing system, after a patch is approved, what should be the following step?

I assume I'll have to make sure the patch hasn't broken anything, before pushing it, so I'll wan't to run a full build+tests, probably in a remote sterile environment (like a jenkins server).

Do we have an integration system like this? Or should I just trust the build+tests on my machine?

Regardless, I have seen in many reviews (in Phabricator) that Builds are triggered for them, in particular: "arc lint + arc unit" and "pre-merge checks" (which sounds like what I am searching for). What is their use and how do I trigger them?

Thanks,

Ehud.

Christian Kühnel via llvm-dev

unread,

Nov 21, 2019, 4:06:18 AM11/21/19

to Ehud Katz, llvm-dev

Hi Ehud,

the pre-merge tests are in prototype state. Once they are ready for testing, I'll announce it on the mailing list

_______________________________________________
LLVM Developers mailing list
llvm...@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

--

Best,

Christian

Jessica Paquette via llvm-dev

unread,

Nov 21, 2019, 12:29:23 PM11/21/19

to Ehud Katz, llvm...@lists.llvm.org

Unless things have changed lately and I missed something, you can just push the change and the bots will pick it up automatically. They will send you emails if it seems like anything is broken.

That being said, before pushing you should do some local tests (e.g. run the lit tests) as an initial sanity check.

If it breaks anything, the standard process is

1) Revert it with an explanation of why in the commit message. (E.g. “This broke this bot” with a link to the build log or a simple example.)

2) Fix the breakage

3) Recommit

- Jessica

Ehud Katz via llvm-dev

unread,

Nov 22, 2019, 2:52:36 PM11/22/19

to Jessica Paquette, llvm...@lists.llvm.org

Thanks. I suspected it to be this way.

Ehud Katz via llvm-dev

unread,

Nov 23, 2019, 5:38:15 AM11/23/19

to Christian Kühnel, llvm-dev

Thanks for the update.

What about "arc lint + arc unit"?

Sourabh Singh Tomar via llvm-dev

unread,

Nov 23, 2019, 2:29:10 PM11/23/19

to llvm...@lists.llvm.org

Hi All,

I also noticed that in phabricator some reviews marked as "arc lint + arc unit Buildable ".

S

canned through Docs for a way to push(from phabricator) for build to llvm build bots or Jenkins. Didn't find one, seems like it's missing feature.

I also realized that even building / pushing "arc lint + arc unit" is also missing from docs ??

Can somebody, help or point me in the right direction? Just to make our lives easier.