Hi all,
At the Barcelona Supercomputing Center, we have been working on
an end-to-end vectorizer using scalable vectors for RISC-V
Vector extension in context of the EPI
Project. We earlier shared a demo of our prototype
implementation (https://repo.hca.bsc.es/epic/z/9eYRIF,
see below) with the folks involved with LLVM SVE/SVE2
development. Since there was an interest in looking at the
source code during the discussions in the subsequent LLVM
SVE/SVE2 sync-up meetings, we are also publishing a public copy
of our repository.
It is available at https://repo.hca.bsc.es/gitlab/rferrer/llvm-epi and will sync with our ongoing development on a weekly basis. Note that this is very much a work in progress and the code in this repository is only for reference purpose. Please see the README file in the repo for details on our approach, design decisions, and limitations.
We welcome any questions and feedback.
Thanks and Regards, Vineet Kumar - vineet...@bsc.es Barcelona Supercomputing Center - Centro Nacional de Supercomputación
Hi all, Following up on the discussion in the last meeting about auto- vectorization for RISC-V Vector extension (scalable vectors) at the Barcelona Supercomputing Center, here are some additional details. We have a working prototype for end-to-end compilation targeting the RISC-V Vector extension. The auto-vectorizer supports two strategies to generate LLVM IR using scalable vectors: 1) Generate a vector loop using VF (vscale x k) = whole vector register width, followed by a scalar tail loop. 2) Generate only a vector loop with active vector length controlled by the RISC-V `vsetvli` instruction and using Vector Predicated intrinsics (https://reviews.llvm.org/D57504). (Of course, intrinsics come with their own limitations but we feel it serves as a good proof of concept for our use case.) We also extend the VPlan to generate VPInstructions that are expanded using predicated intrinsics. We also considered a third hybrid approach of having a vector loop with VF = whole register width, followed by a vector tail loop using predicated intrinsics. For now though, based on project requirements, we favoured the second approach. We have also taken care to not break any fixed-vector implementation. All the scalable vector IR gen is guarded by conditions set by TTI. For shuffles, the most used case is broadcast which is supported by the current semantics of `shufflevector` instruction. For other cases like reverse, concat, etc., we have defined our own intrinsics. Current limitaitons: The cost model for scalable vectors doesn't do much other than always decideing to vectorize with VF based on TargetWidestType/SmallestType. We also do not support interleaving yet. Demo: The current implementation is very much in alpha and eventually, once it's more polished and thoroughly verified, we will put out patches on Phabricator. Till then, we have set up a Compiler Explorer server against our development branch to showcase the generated code. You can see and experiment with the generated LLVM IR and VPlan for a set of examples, with predicated vector loop (`-mprefer-predicate-over- epilog`) at https://repo.hca.bsc.es/epic/z/JB4ZoJ and with a scalar epilog (`-mno-prefer-predicate-over-epilog`) at https://repo.hca.bsc.es/epic/z/0WoDGt. Note that you can remove the `-emit-llvm` option to see the generated RISC-V assembly. We welcome any questions and feedback. Thanks and Regards, Vineet Kumar - vineet...@bsc.es Barcelona Supercomputing Center - Centro Nacional de Supercomputación
_______________________________________________
LLVM Developers mailing list
llvm...@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
Hi Renato,
Thanks a lot for your comments!
(more inline.)
Thanks and Regards,
Vineet
Hi Vineet,
Thanks for sharing! I haven't looked at the code yet, just read the README file you have and it has already answered a lot of questions that I initially had. Some general comments...
I'm very happy to see that Simon's predication changes were useful to your work. It's a nice validation of their work and hopefully will help SVE, too.
Your main approach to strip-mine + fuse tail loop is what I was going to propose for now. It matches well with the bite-sized approach VPlan has and could build on existing vector formats. For example, you always try to strip-mine (for scalable and non-scalable) and then only for scalable, you try to fuse the scalar loops, which would improve the solution and give RVV/SVVE an edge over the other extensions on the same hardware.
There were also in the past proposals to vectorise the tail loop, which could be a similar step. For example, in case the main vector body is 8-way or 16-way, the tail loop would be 7-way or 15-way, which is horribly inefficient. The idea was to further vectorise the 7-way as 4+2+1 ways, same for 15. If those loops are then unrolled, you end up with a nice decaling down pattern. On scalable vectors, this becomes a noop.
There is a separate thread for vectorisation cost model [1] which talks about some of the challenges there, I think we need to include scalable vectors in consideration when thinking about it.
The NEON vs RISCV register shadowing is interesting. It is true we mostly ignored 64-bit vectors in the vectoriser, but LLVM can still generate them with the (SLP) region vectoriser. IIRC, support for that kind of aliasing is not trivial (and why GCC's description of NEON registers sucked for so long), but the motivation of register pressure inside hot loops is indeed important. I'm adding Arai Masaki in CC as this is something he was working on.
Thanks for adding Arai! I will be happy to pick their brain on
the the topic.
One specific place where we have to deal with it is when
computing a feasible max VF. I am currently experimenting with an
approach to have user specify (via a command line flag) a vector
register width multiplier - a factor by which the operating vector
register width would be the multiple of the minimum vector
register width and then based on that, estimate the highest VF
that won't spill registers (relies on TTI for information about
the number of registers in relation to register width). This is
definitely not a generic solution and probably not elegant either
but personally it serves as a starting point to think about the
broader issue.
Otherwise, I think working with the current folks on VPlan and scalable extensions will be a good way to upstreaming all the ideas you guys had in your work.
Fold the epilog loop into the vector body.
- This is done by setting the vector length in each iteration. This induces a predicate/mask over all the vector instructions of the loop (any other predicates/masks in the vector body are needed for control flow).
Hi Sjoerd,
thanks for pointing us to this intrinsic.
I see it returns a mask/predicate type. My understanding is that VPred intrinsics have both a vector length operand and a mask operand. It looks to me that a "popcount" of get.active.lane.mask would correspond to the vector length operand. Then additional "control flow" mask of predicated code would correspond to the mask operand.
My intepretation was that get.active.lane.mask allowed targets that do not have a concept of vector length (such as SVE or MVE) to represent it as a mask. For those targets, the vector length operand can be given a value that means "use the whole register" and then only the mask operand is relevant to them.
But maybe my interpretation is wrong.
@Simon: what is VE going to do here?
For RISC-V V and VE being explicit about %evl is important for performance & correctness and that is what VP does. The get.active.lane.mask intrinsic is used as a hint for the MVE, SVE backends to use hardware tail-predication (the backends reverse engineer that hint by pattern matching for get.active.lane.mask in the mask parameter of "some" masked intrinsics). IMHO, it's more of a hot fix to get some tail-predication working quickly with the existing infrastructure. It is still useful by itself, eg the ExpandVPIntrinsic pass uses it to expand the %evl parameter in VP intrinsics for scalable vector types.
VE uses VP-style SDNodes in the isel layer (upstream patch on Phabricator to follow soon-ish). We simply translate both VP and regular SIMD SDNodes into these custom SDNodes as an intermediate layer. Even the VE machine instructions still have an explicit %evl operand. We have a machine function pass that inserts code to re-configure the VL register in-between vector instructions that have a different %evl value (we had a poster on that at the LLVM US DevMtg '19). This isel strategy has been working well for us.
The goal is to teach LV, VPlan to emit VP intrinsics with a convenient builder class (VPBuilder in the reference patch).
Trying to remember how everything fits together here, but could get.active.lane.mask not create the %mask of the VP intrinsics? Or in other words, in the vectoriser, who's producing the %mask and %evl that is consumed by the VP intrinsics?
Hi Sjoerd,
Trying to remember how everything fits together here, but could get.active.lane.mask not create the %mask of the VP intrinsics? Or in other words, in the vectoriser, who's producing the %mask and %evl that is consumed by the VP intrinsics?
I'm not sure what would be the best way here. I think about the Loop Vectorizer. I imagine at some point we can teach LV to emit VPred for the widening. VPred IR needs two additional operands, as you mentioned, %evl and %mask.
One option is make %evl the max-vector-length of the type being operated and %mask (that is the "outer block mask" in this context) be get.active.lane.mask. This maps well for SVE and MVE not so much for VE and RISC-V (I don't think it is incorrect but it is not an efficient thing to do). Perhaps VE and RISC-V can work in this scenario if at some point they replace the %evl with something like "%n - %base" operands of get.active.lane.mask, and %mask (the outer block mask) is replaced with a splat of "i1 1".
Another option here is make "%n - %base" be the %evl (or at least an operand of some target hook because "computing" the %evl is target-specific, targets without evl could compute the identity here) and %mask (the outer block mask) be a splat of "i1 1". This maps well VE and RISC-V but makes life harder for AVX-512, SVE and MVE (in general any target where TargetTransformInfo::hasActiveVectorLength returns false). Those targets could replace the %evl with the max-vector-length of the operated type and then use get.active.lane.mask(0, %evl) as the outer block mask. My understanding is that Simon used this approach in https://reviews.llvm.org/D78203 but in a more general setting, that would be independent of what Loop Vectorizer does.
Looks to me the second option makes a more effective use of vpred and D78203 shows that we can always soften vpred into a shape that is reasonable for lowering in targets without active vector length.
The whole point about VP is to make sure there is one set of vector-predicated instructions/intrinsics that everybody is using while giving people the freedom to use these as it fits their targets. We can then concentrate on optimizing VP intrinsic code and all targets benefit.
The whole point about VP is to make sure there is one set of vector-predicated instructions/intrinsics that everybody is using while giving people the freedom to use these as it fits their targets. We can then concentrate on optimizing VP intrinsic code and all targets benefit.
Looks to me the second option makes a more effective use of vpred and D78203 shows that we can always soften vpred into a shape that is reasonable for lowering in targets without active vector length.
; Some examples:
; RISC-V V & VE(*):
; %mask = (splat i1 1)
; %evl = min(256, %n - %i)
; MVE/SVE :
; %mask = get.active.lane.mask(%i, %n)
; %evl = call @llvm.vscale()
; AVX:
; %mask = icmp (%i + (seq <8 x i32> 0,1,2,.,)), %n,
; %evl = i32 8
Hello Simon,
Thanks for your replies, very useful. And yes, thanks for the example and making the target differences clear:
; Some examples:
; RISC-V V & VE(*):
; %mask = (splat i1 1)
; %evl = min(256, %n - %i)
; MVE/SVE :
; %mask = get.active.lane.mask(%i, %n)
; %evl = call @llvm.vscale()
; AVX:
; %mask = icmp (%i + (seq <8 x i32> 0,1,2,.,)), %n,
; %evl = i32 8
Unless I miss something, the AVX example is semantically the same as get.active.lane.mask:
%m[i] = icmp ult (%base + i), %n
with i = 8.
Just saying this to see if we can have "1 interface" for generating the mask (which is what I was perhaps expecting), and if you just want an all true mask for VE and if we can merge AVX with the other 2 we just have:
; RISC-V V & VE(*):
; %mask = get.active.lane.mask(%i, %i)
; %evl = min(256, %n - %i); MVE/SVE/AVX :
; %mask = get.active.lane.mask(%i, %n)
; %evl = call @llvm.vscale()
I am not sure why MVE (or AVX) would need the vscale(). But if it does, I am wondering if it could be something like:
; RISC-V V & VE(*):
; %mask = get.active.lane.mask(%i, %i)
; %evl = call @llvm.vscale(256, %n - %i); MVE/SVE/AVX :
; %mask = get.active.lane.mask(%i, %n)
; %evl = call @llvm.vscale(... ,..)
- Simon
Cheers,Sjoerd.
For VE, we want to do as much predication as possible through %evl and as little as possible with %mask. This has performance implications on VE and RISC-V - VE does not generate a mask from %evl but %evl is directly mapped to hardware, passing the all-true mask is free.
; RISC-V V & VE(*):
; %mask = get.active.lane.mask(%i, %i)
; %evl = min(256, %n - %i); MVE/SVE/AVX :
; %mask = get.active.lane.mask(%i, %n)
; %evl = call @llvm.vscale()
So for VE, the %evl does all the predication and there is no reason to have anything other than a (splat i1 1) %mask here.
For VE, we want to do as much predication as possible through %evl and as little as possible with %mask. This has performance implications on VE and RISC-V - VE does not generate a mask from %evl but %evl is directly mapped to hardware, passing the all-true mask is free.
; RISC-V V & VE(*):
; %mask = get.active.lane.mask(%i, %i)
; %evl = min(256, %n - %i); MVE/SVE/AVX :
; %mask = get.active.lane.mask(%i, %n)
; %evl = call @llvm.vscale()
So for VE, the %evl does all the predication and there is no reason to have anything other than a (splat i1 1) %mask here.Okay, got it. One way to look at this is that (splat i1 1) is just a special case of get.active.lane.mask, for example get.mask(%i, 0) can trivially be expanded/lowered to a (splat i1 1). This is not terribly important, but shows that get.active.lane.mask could be used for all targets I think; we don't need many cases. And kind of similarly, vscale can be a no-op or do something