[llvm-dev] [RFC] llvm-exegesis: Automatic Measurement of Instruction Latency/Uops

27 views
Skip to first unread message

Guillaume Chatelet via llvm-dev

unread,
Mar 15, 2018, 11:05:12 AM3/15/18
to llvm...@lists.llvm.org
[You can find an easier to read and more complete version of this RFC here.]


Knowing instruction scheduling properties (latency, uops) is the basis for all scheduling work done by LLVM.


Unfortunately, vendors usually release only partial (and sometimes incorrect) information.  Updating the information is painful and requires careful guesswork and analysis. As a result, scheduling information is incomplete for most X86 models (this bug tracks some of these issues). The goal of the tool presented here is to automatically (in)validate the TableDef scheduling models. In the long run we envision automatic generation of the models.


At Google, we have developed a tool that, given an instruction mnemonic, uses the data in `MCInstrInfo` to generate a code snippet that makes execution as serial (resp. as parallel) as possible so that we can measure the latency (resp. uop decomposition) of the instruction. The code snippet is jitted and executed on the host subtarget. The time taken (resp. resource usage) is measured using hardware performance counters. More details can be found in the ‘implementation’ section of the RFC.


For people familiar with the work of Agner Fog, this is essentially an automation of the process of building the code snippets using instruction descriptions from LLVM.

Results

> llvm-exegesis -opcode-name IMUL16rri8 -benchmark-mode latency

---

asm_template:    

 name:            latency IMUL16rri8

cpu_name:        sandybridge

llvm_triple:     x86_64-grtev4-linux-gnu

num_repetitions: 10000

measurements:    

 - { key: latency, value: 4.0115, debug_string: '' }

error:           ''

...


> llvm-exegesis -opcode-name IMUL16rri8 -benchmark-mode uops

---

asm_template:    

 name:            uops IMUL16rri8

cpu_name:        sandybridge

llvm_triple:     x86_64-grtev4-linux-gnu

num_repetitions: 10000

measurements:    

 - { key: '2', value: 0.5232, debug_string: SBPort0 }

 - { key: '3', value: 1.0039, debug_string: SBPort1 }

 - { key: '4', value: 0.0024, debug_string: SBPort4 }

 - { key: '5', value: 0.3693, debug_string: SBPort5 }

error:           ''

...

Running both these commands took ~.2 seconds including printing.





sandybridge

haswell

skylake

mnemonic

llvm-exegesis

TD file

llvm-exegesis

TD file

llvm-exegesis

TD file

SHR32r1

1.01

1.00

1.00

1.00

1.01

1.00

IMUL16rri

4.02

3.00

4.01

3.00

4.01

3.00


  • Some instructions have different implementations depending on which registers are assigned. This is well known for cases like `xor eax, eax` and `xor eax, ebx`, which emits no uops in the first case (this happens during register renaming, see Agner Fog’s “Register Allocation and Renaming”, in microarchitecture.pdf). But we found out that this can go further. For example, SHLD64rri8 takes one cycle and runs on P06 in the `shld rax, rax, 0x1` case, but takes 3 cycles and runs on P1 in the `shld rbx, rax, 0x1` case. To the best of our knowledge, this has not yet been described.

Future Work

  • [easy] Fix Intel Scheduling Models.

  • [easy] Extend to memory operands.

  • [easy] Make the tool work reliably for x87 instructions.

  • [medium] A tool that automatically create patches to TD files.

  • [medium] Measure the effect of immediate/register values: Some instructions have performance characteristics that depends on the values it operates on. We should explore the value space (0, 1, ~1, 2^{8,16,32,64}, inf, nan, denorm...).

  • [medium] Measure the effect of changing registers on instruction implementation (see results section above). Model this in LLVM TD schema.

  • [hard] Make the tool work for instruction that have side effects (e.g. PUSH/POP, JMP, ...). This might involve extending the TD schema with information on how to setup measurements for specific instructions.

  • [??] Make the tool work for other CPUs. This mainly depends on the presence of performance counters.

Open Questions

We depend on libpfm. How do we handle the dependency ?


--
Guillaume Chatelet (gcha...@google.com), Clement Courbet (cou...@google.com) for the Google Compiler Research Team

Guillaume Chatelet via llvm-dev

unread,
Mar 15, 2018, 11:30:49 AM3/15/18
to llvm...@lists.llvm.org
Patch for this RFC is available at https://reviews.llvm.org/D44519.

Hal Finkel via llvm-dev

unread,
Mar 15, 2018, 11:41:28 AM3/15/18
to Guillaume Chatelet, llvm...@lists.llvm.org
This is great!


Future Work

  • [easy] Fix Intel Scheduling Models.

  • [easy] Extend to memory operands.

  • [easy] Make the tool work reliably for x87 instructions.

  • [medium] A tool that automatically create patches to TD files.

  • [medium] Measure the effect of immediate/register values: Some instructions have performance characteristics that depends on the values it operates on. We should explore the value space (0, 1, ~1, 2^{8,16,32,64}, inf, nan, denorm...).

  • [medium] Measure the effect of changing registers on instruction implementation (see results section above). Model this in LLVM TD schema.

  • [hard] Make the tool work for instruction that have side effects (e.g. PUSH/POP, JMP, ...). This might involve extending the TD schema with information on how to setup measurements for specific instructions.

  • [??] Make the tool work for other CPUs. This mainly depends on the presence of performance counters.

Open Questions

We depend on libpfm. How do we handle the dependency ?


Are there options that you have in mind? It's an external MIT-licensed dependency. Wouldn't CMake just detect it when it's available?

 -Hal

--
Guillaume Chatelet (gcha...@google.com), Clement Courbet (cou...@google.com) for the Google Compiler Research Team



_______________________________________________
LLVM Developers mailing list
llvm...@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

-- 
Hal Finkel
Lead, Compiler Technology and Programming Languages
Leadership Computing Facility
Argonne National Laboratory

Clement Courbet via llvm-dev

unread,
Mar 15, 2018, 11:49:41 AM3/15/18
to Hal Finkel, llvm-dev
That's what we've done for now (see code here). We're not sure what the policy is wrt external deps. Right now if the tool is enabled and libpfm is not on the system, we die with an error message. The other options would be to disable the tool in that case (I'm not sure how to do that). Opinions ?

Clement Courbet via llvm-dev

unread,
Mar 15, 2018, 11:53:04 AM3/15/18
to Hal Finkel, llvm-dev
There's also the option where not having libpfm still compiles the tool but returns dummy measurements (though #ifdefs). This has the advantage that everybody can compile the tool (e.g. to check against API changes in LLVM).

Hal Finkel via llvm-dev

unread,
Mar 15, 2018, 11:56:26 AM3/15/18
to Clement Courbet, llvm-dev
Sounds good (we can discuss this further, if necessary, in the code review).

 -Hal

Eric Christopher via llvm-dev

unread,
Mar 15, 2018, 12:12:17 PM3/15/18
to Hal Finkel, llvm-dev
I am, of course, a huge fan of this effort. :)

  • [??] Make the tool work for other CPUs. This mainly depends on the presence of performance counters.

Having these requirements documented will be great. In particular, it's important to document what kind of functionality we need out of the PMU rather than any particular cpu specific counter. Also performance requirements of the counters.


Open Questions

We depend on libpfm. How do we handle the dependency ?


Are there options that you have in mind? It's an external MIT-licensed dependency. Wouldn't CMake just detect it when it's available?

That's what we've done for now (see code here). We're not sure what the policy is wrt external deps. Right now if the tool is enabled and libpfm is not on the system, we die with an error message. The other options would be to disable the tool in that case (I'm not sure how to do that). Opinions ?

Sounds good (we can discuss this further, if necessary, in the code review).

Agreed. :)

-eric 

Clement Courbet via llvm-dev

unread,
Mar 15, 2018, 12:21:00 PM3/15/18
to Eric Christopher, llvm-dev
On Thu, Mar 15, 2018 at 5:12 PM, Eric Christopher <echr...@gmail.com> wrote:
I am, of course, a huge fan of this effort. :)

  • [??] Make the tool work for other CPUs. This mainly depends on the presence of performance counters.

Having these requirements documented will be great. In particular, it's important to document what kind of functionality we need out of the PMU rather than any particular cpu specific counter. Also performance requirements of the counters.

I'll create a bug to track that as soon as the RFC has been accepted. In a nutshell we were thinking of adding a field to `ProcResource` in `TargetSchedule.td` that maps the resource to a (list of) pfm/perf event, and let libpfm abstract the hardware for us.

Philip Reames via llvm-dev

unread,
Mar 15, 2018, 12:30:35 PM3/15/18
to Guillaume Chatelet, llvm...@lists.llvm.org

Sounds like a very useful tool.  Thank you for contributing.

Taking a step back and looking at the big picture, combining this with the recently contributed llvm-mca dramatically improves our scheduling and performance analysis story.  Being able to take a snippet of code on a particular machine, measure latency/throughput/ports for each instruction (this tool), and then analyze the entire code sequence in an actionable way using the measured information (llvm-mca), leads to a very powerful performance analysis workflow. 

Clement Courbet via llvm-dev

unread,
Mar 16, 2018, 4:10:33 AM3/16/18
to Philip Reames, llvm-dev
Thanks Philip, 

That project is part of a global effort to better understand and simulate the performance of our code, so it's not a coincidence that this complements llvm-mca. As a matter of fact, when llvm-mca was announced we were about to release a similar tool, and we're now working with Andrea et al. to integrate our work into llvm-mca. We're happy that many people seem to share the same goals and vision.
BTW we'll be presenting two lightning talks about this work at EuroLLVM, happy to discuss if you happen to attend.

Reply all
Reply to author
Forward
0 new messages