[KJ] another possible project: cleaning up Documentation/ioctl-number.txt

1 view
Skip to first unread message

Robert P. J. Day

unread,
Jul 2, 2007, 11:24:45 AM7/2/07
to Kernel Janitors List

while this is technically cosmetic, a possible project would be to
bring the ioctl-number.txt file up to date as much as possible. at
the moment, it's got a number of general flaws.

first, there's the occasional obvious typo:

'd' 00-FF linux/char/drm/drm/h conflict!

then there are a number of filenames that just aren't correct
for one reason or another:

'U' 00-EF linux/drivers/usb/usb.h

and it would seem that some of the entries aren't even *close* to
listing the files where some of those ioctls are being defined.
taking 'U' as an example, the file says this:

'U' 00-EF linux/drivers/usb/usb.h
'U' F0-FF drivers/usb/auerswald.c

now, on top of *both* of those filenames being wrong, it's easy to
see that there are more files that define ioctls based on that magic
number:

$ grep -rl "_IO.*'U'" *
drivers/bluetooth/hci_uart.h
drivers/usb/misc/auerswald.c
drivers/usb/misc/usbtest.c
fs/compat_ioctl.c
include/linux/usbdevice_fs.h
include/linux/uinput.h
include/sound/asound.h
sound/core/control_compat.c
usr/include/linux/usbdevice_fs.h
usr/include/linux/uinput.h
usr/include/sound/asound.h

granted, that's an extreme example, but there's more like it. is
this a cleanup worth doing? and, if so, is anyone interested in doing
it?

rday
--
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================
_______________________________________________
Kernel-janitors mailing list
Kernel-...@lists.linux-foundation.org
https://lists.linux-foundation.org/mailman/listinfo/kernel-janitors

Reply all
Reply to author
Forward
0 new messages