Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] USB: musb: fix build error introduced by isoc change

0 views
Skip to first unread message

Mike Frysinger

unread,
Mar 8, 2010, 11:30:02 AM3/8/10
to
From: Sonic Zhang <sonic...@analog.com>

The recent commit "usb: musb: Fix for isochronous IN transfer" (f82a689fa)
seems to have been against an older kernel version. It uses the old style
naming of variables. Unfortunately, this breaks building for most MUSB
users out there since "bDesiredMode" has been renamed to "desired_mode".

Signed-off-by: Sonic Zhang <sonic...@analog.com>
Signed-off-by: Mike Frysinger <vap...@gentoo.org>
---
drivers/usb/musb/musb_host.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
index d21fffa..ef29f38 100644
--- a/drivers/usb/musb/musb_host.c
+++ b/drivers/usb/musb/musb_host.c
@@ -1689,7 +1689,7 @@ void musb_host_rx(struct musb *musb, u8 epnum)
dma->desired_mode = 1;
if (rx_count < hw_ep->max_packet_sz_rx) {
length = rx_count;
- dma->bDesiredMode = 0;
+ dma->desired_mode = 0;
} else {
length = urb->transfer_buffer_length;
}
--
1.7.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Gadiyar, Anand

unread,
Mar 8, 2010, 11:40:01 AM3/8/10
to
Mike Frysinger wrote:
>
> From: Sonic Zhang <sonic...@analog.com>
>
> The recent commit "usb: musb: Fix for isochronous IN transfer" (f82a689fa)
> seems to have been against an older kernel version. It uses the old style
> naming of variables. Unfortunately, this breaks building for most MUSB
> users out there since "bDesiredMode" has been renamed to "desired_mode".
>

Looks like this code is under a "#ifdef USE_MODE1" check; that's why
we did not find this during regular builds. Felipe's upcoming patches
would make this code redundant anyway.

Till then, we might as well fix it.

> Signed-off-by: Sonic Zhang <sonic...@analog.com>
> Signed-off-by: Mike Frysinger <vap...@gentoo.org>

Acked-by: Anand Gadiyar <gad...@ti.com>

> ---
> drivers/usb/musb/musb_host.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/musb/musb_host.c b/drivers/usb/musb/musb_host.c
> index d21fffa..ef29f38 100644
> --- a/drivers/usb/musb/musb_host.c
> +++ b/drivers/usb/musb/musb_host.c
> @@ -1689,7 +1689,7 @@ void musb_host_rx(struct musb *musb, u8 epnum)
> dma->desired_mode = 1;
> if (rx_count < hw_ep->max_packet_sz_rx) {
> length = rx_count;
> - dma->bDesiredMode = 0;
> + dma->desired_mode = 0;
> } else {
> length = urb->transfer_buffer_length;
> }
> --

Mike Frysinger

unread,
Mar 8, 2010, 11:50:03 AM3/8/10
to
On Mon, Mar 8, 2010 at 11:31, Gadiyar, Anand wrote:
> Mike Frysinger wrote:
>> From: Sonic Zhang <sonic...@analog.com>
>>
>> The recent commit "usb: musb: Fix for isochronous IN transfer" (f82a689fa)
>> seems to have been against an older kernel version.  It uses the old style
>> naming of variables.  Unfortunately, this breaks building for most MUSB
>> users out there since "bDesiredMode" has been renamed to "desired_mode".
>>
>
> Looks like this code is under a "#ifdef USE_MODE1" check; that's why
> we did not find this during regular builds.

ah, ok. Felipe should tweak the changelog to mention this when merging ;)

> Felipe's upcoming patches would make this code redundant anyway.
>
> Till then, we might as well fix it.

right ... this at least should go into 2.6.33.x
-mike

Felipe Balbi

unread,
Mar 8, 2010, 1:40:02 PM3/8/10
to
On Mon, Mar 08, 2010 at 10:01:45PM +0530, Gadiyar, Anand wrote:
> Mike Frysinger wrote:
> >
> > From: Sonic Zhang <sonic...@analog.com>
> >
> > The recent commit "usb: musb: Fix for isochronous IN transfer" (f82a689fa)
> > seems to have been against an older kernel version. It uses the old style
> > naming of variables. Unfortunately, this breaks building for most MUSB
> > users out there since "bDesiredMode" has been renamed to "desired_mode".
> >
>
> Looks like this code is under a "#ifdef USE_MODE1" check; that's why
> we did not find this during regular builds. Felipe's upcoming patches
> would make this code redundant anyway.
>
> Till then, we might as well fix it.

yes, it was my bad. I should have reviewed the code more carefully. We
will be testing the mode1 support on DaVinci during this and the next
week and when we get it working, we will publish the mode1 dma changes
again which will completely change this code.

> > Signed-off-by: Sonic Zhang <sonic...@analog.com>
> > Signed-off-by: Mike Frysinger <vap...@gentoo.org>
>
> Acked-by: Anand Gadiyar <gad...@ti.com>

Acked-by: Felipe Balbi <felipe...@nokia.com>

--
balbi

Felipe Balbi

unread,
Mar 11, 2010, 8:10:02 AM3/11/10
to
On Mon, Mar 08, 2010 at 05:26:01PM +0100, ext Mike Frysinger wrote:
>From: Sonic Zhang <sonic...@analog.com>
>
>The recent commit "usb: musb: Fix for isochronous IN transfer" (f82a689fa)
>seems to have been against an older kernel version. It uses the old style
>naming of variables. Unfortunately, this breaks building for most MUSB
>users out there since "bDesiredMode" has been renamed to "desired_mode".
>
>Signed-off-by: Sonic Zhang <sonic...@analog.com>
>Signed-off-by: Mike Frysinger <vap...@gentoo.org>

applied, thanks

--
balbi

0 new messages