Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

Bug#993612: [PATCH v2] of/address: Return an error when no valid dma-ranges are found

42 views
Skip to first unread message

Rob Herring

unread,
Jan 30, 2023, 4:50:10 PM1/30/23
to

On Sat, 28 Jan 2023 17:47:50 +0000, Mark Brown wrote:
> Commit 7a8b64d17e35 ("of/address: use range parser for of_dma_get_range")
> converted the parsing of dma-range properties to use code shared with the
> PCI range parser. The intent was to introduce no functional changes however
> in the case where we fail to translate the first resource instead of
> returning -EINVAL the new code we return 0. Restore the previous behaviour
> by returning an error if we find no valid ranges, the original code only
> handled the first range but subsequently support for parsing all supplied
> ranges was added.
>
> This avoids confusing code using the parsed ranges which doesn't expect to
> successfully parse ranges but have only a list terminator returned, this
> fixes breakage with so far as I can tell all DMA for on SoC devices on the
> Socionext Synquacer platform which has a firmware supplied DT. A bisect
> identified the original conversion as triggering the issues there.
>
> Fixes: 7a8b64d17e35 ("of/address: use range parser for of_dma_get_range")
> Signed-off-by: Mark Brown <bro...@kernel.org>
> Cc: Luca Di Stefano <luca.di...@linaro.org>
> Cc: 993...@bugs.debian.org
> Cc: sta...@kernel.org
> ---
> Changes in v2:
> - Don't leak parsed resources.
> - Link to v1: https://lore.kernel.org/r/20230126-synquacer-b...@kernel.org
> ---
> drivers/of/address.c | 21 +++++++++++++++------
> 1 file changed, 15 insertions(+), 6 deletions(-)
>

Applied, thanks!
0 new messages