Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

2.6.32-rc7: compile regression on spitz

1 view
Skip to first unread message

Pavel Machek

unread,
Nov 18, 2009, 8:30:02 AM11/18/09
to

If CONFIG_AKITA is not set, spitz fails to compile. It worked ok in
rc5. Fix is one more ifdef...

Signed-off-by: Pavel Machek <pa...@ucw.cz>

--- a/arch/arm/mach-pxa/spitz.c 2009-11-17 17:10:21.000000000 +0100
+++ b/arch/arm/mach-pxa/spitz.c 2009-11-18 05:55:21.000000000 +0100
@@ -802,10 +802,12 @@
{
spitz_ficp_platform_data.gpio_pwdown = SPITZ_GPIO_IR_ON;

+#ifdef CONFIG_MACH_BORZOI
if (machine_is_borzoi()) {
sharpsl_nand_platform_data.badblock_pattern = &sharpsl_akita_bbt;
sharpsl_nand_platform_data.ecc_layout = &akita_oobinfo;
}
+#endif

platform_scoop_config = &spitz_pcmcia_config;

--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Stanislav Brabec

unread,
Nov 18, 2009, 9:40:04 AM11/18/09
to
Pavel Machek wrote:
> If CONFIG_AKITA is not set, spitz fails to compile. It worked ok in
> rc5. Fix is one more ifdef...

That was my mistake in 5e0fa3f.

> Signed-off-by: Pavel Machek <pa...@ucw.cz>
Acked-by: Stanislav Brabec <u...@penguin.cz>

--
Stanislav Brabec
http://www.penguin.cz/~utx

Pavel Machek

unread,
Nov 22, 2009, 9:20:02 AM11/22/09
to
On Wed 2009-11-18 10:01:00, Pavel Machek wrote:
>
> If CONFIG_AKITA is not set, spitz fails to compile. It worked ok in
> rc5. Fix is one more ifdef...
>
> Signed-off-by: Pavel Machek <pa...@ucw.cz>

Eric, this being after-rc5 regression... it would be nice to actually
fix it for final...
Pavel

Eric Miao

unread,
Nov 22, 2009, 10:50:01 AM11/22/09
to
2009/11/18 Stanislav Brabec <u...@penguin.cz>:

> Pavel Machek wrote:
>> If CONFIG_AKITA is not set, spitz fails to compile. It worked ok in
>> rc5. Fix is one more ifdef...
>
> That was my mistake in 5e0fa3f.
>
>> Signed-off-by: Pavel Machek <pa...@ucw.cz>
> Acked-by: Stanislav Brabec <u...@penguin.cz>
>

Applied to 'fix'.

0 new messages