Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] dell-smo8800: Add more acpi ids and change description of driver

27 views
Skip to first unread message

Pali Rohár

unread,
Sep 29, 2014, 8:50:01 AM9/29/14
to
Signed-off-by: Pali Rohár <pali....@gmail.com>
---
drivers/platform/x86/Kconfig | 4 ++--
drivers/platform/x86/dell-smo8800.c | 10 ++++++++--
2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 3bbcbf1..ba9ee4f 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -128,10 +128,10 @@ config DELL_WMI_AIO
be called dell-wmi-aio.

config DELL_SMO8800
- tristate "Dell Latitude freefall driver (ACPI SMO8800/SMO8810)"
+ tristate "Dell Latitude freefall driver (ACPI SMO88XX)"
depends on ACPI
---help---
- Say Y here if you want to support SMO8800/SMO8810 freefall device
+ Say Y here if you want to support SMO88XX freefall device
on Dell Latitude laptops.

To compile this driver as a module, choose M here: the module will
diff --git a/drivers/platform/x86/dell-smo8800.c b/drivers/platform/x86/dell-smo8800.c
index a653716..0aec4fd 100644
--- a/drivers/platform/x86/dell-smo8800.c
+++ b/drivers/platform/x86/dell-smo8800.c
@@ -1,5 +1,5 @@
/*
- * dell-smo8800.c - Dell Latitude ACPI SMO8800/SMO8810 freefall sensor driver
+ * dell-smo8800.c - Dell Latitude ACPI SMO88XX freefall sensor driver
*
* Copyright (C) 2012 Sonal Santan <sonal....@gmail.com>
* Copyright (C) 2014 Pali Rohár <pali....@gmail.com>
@@ -209,7 +209,13 @@ static int smo8800_remove(struct acpi_device *device)

static const struct acpi_device_id smo8800_ids[] = {
{ "SMO8800", 0 },
+ { "SMO8801", 0 },
{ "SMO8810", 0 },
+ { "SMO8811", 0 },
+ { "SMO8820", 0 },
+ { "SMO8821", 0 },
+ { "SMO8830", 0 },
+ { "SMO8831", 0 },
{ "", 0 },
};

@@ -228,6 +234,6 @@ static struct acpi_driver smo8800_driver = {

module_acpi_driver(smo8800_driver);

-MODULE_DESCRIPTION("Dell Latitude freefall driver (ACPI SMO8800/SMO8810)");
+MODULE_DESCRIPTION("Dell Latitude freefall driver (ACPI SMO88XX)");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Sonal Santan, Pali Rohár");
--
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Darren Hart

unread,
Sep 29, 2014, 5:00:03 PM9/29/14
to
On Mon, Sep 29, 2014 at 02:45:48PM +0200, Pali Rohár wrote:

Please see Documentation/SubmittingPatches, 15) The canonical patch format, and
provide a complete message body.

Have you validated each of the 6 ACPI IDs added to the driver?


> Signed-off-by: Pali Rohár <pali....@gmail.com>
> ---
> drivers/platform/x86/Kconfig | 4 ++--
> drivers/platform/x86/dell-smo8800.c | 10 ++++++++--
> 2 files changed, 10 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index 3bbcbf1..ba9ee4f 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -128,10 +128,10 @@ config DELL_WMI_AIO
> be called dell-wmi-aio.
>
> config DELL_SMO8800
> - tristate "Dell Latitude freefall driver (ACPI SMO8800/SMO8810)"
> + tristate "Dell Latitude freefall driver (ACPI SMO88XX)"
> depends on ACPI
> ---help---
> - Say Y here if you want to support SMO8800/SMO8810 freefall device
> + Say Y here if you want to support SMO88XX freefall device

"devices" now that multiple are supported.

Thanks,

--
Darren Hart
Intel Open Source Technology Center

Pali Rohár

unread,
Nov 22, 2014, 9:40:05 PM11/22/14
to
Oops, I lost this mail somewhere...

I copied these ids from windows driver inf file. I did not tested
them because I do not have machine which reports these ids. It
looks like all SMOXX devices have same acpi structure (one IRQ).
So adding ids could not break anything (if acpi device will not
have for some reason IRQ specified, device probe function will
fail).
Pali Rohár
pali....@gmail.com
signature.asc

Darren Hart

unread,
Dec 4, 2014, 10:40:06 PM12/4/14
to
On Sun, Nov 23, 2014 at 03:38:26AM +0100, Pali Rohár wrote:
> Oops, I lost this mail somewhere...
>
> I copied these ids from windows driver inf file. I did not tested
> them because I do not have machine which reports these ids. It
> looks like all SMOXX devices have same acpi structure (one IRQ).
> So adding ids could not break anything (if acpi device will not
> have for some reason IRQ specified, device probe function will
> fail).

Please resend with a complete message body and the typo fix below.

Pali Rohár

unread,
Dec 5, 2014, 7:10:07 AM12/5/14
to
This patch adds other ACPI ids from Windows inf driver which should be handled
by dell-smo8800 driver. ACPI devices have same structure -- one IRQ number.

This patch also updates description of module.

Signed-off-by: Pali Rohár <pali....@gmail.com>
---
drivers/platform/x86/Kconfig | 4 ++--
drivers/platform/x86/dell-smo8800.c | 10 ++++++++--
2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index 3bbcbf1..4614f35 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -128,10 +128,10 @@ config DELL_WMI_AIO
be called dell-wmi-aio.

config DELL_SMO8800
- tristate "Dell Latitude freefall driver (ACPI SMO8800/SMO8810)"
+ tristate "Dell Latitude freefall driver (ACPI SMO88XX)"
depends on ACPI
---help---
- Say Y here if you want to support SMO8800/SMO8810 freefall device
+ Say Y here if you want to support SMO88XX freefall devices

Darren Hart

unread,
Dec 5, 2014, 11:40:05 PM12/5/14
to
On Fri, Dec 05, 2014 at 01:05:46PM +0100, Pali Rohár wrote:
> This patch adds other ACPI ids from Windows inf driver which should be handled
> by dell-smo8800 driver. ACPI devices have same structure -- one IRQ number.
>
> This patch also updates description of module.
>
> Signed-off-by: Pali Rohár <pali....@gmail.com>

Queued to testing, thanks Pali.

--
Darren Hart
Intel Open Source Technology Center
0 new messages