Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss
[PATCH] pinctrl: capri: add dependency on OF
0 views
Skip to first unread message
Linus Walleij
Jan 16, 2014, 5:50:02 PM1/16/14
to
As this driver is using pinconf_generic_dt_node_to_map_pin() it
needs to depend on OF so as not to cause build problems on
archs that do not support OF.
Cc: Sherman Yin <sy...@broadcom.com>
Signed-off-by: Linus Walleij <linus....@linaro.org>
---
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index f1dda4d9de13..be361b7cd30f 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -106,6 +106,7 @@ config PINCTRL_BCM2835
config PINCTRL_CAPRI
bool "Broadcom Capri pinctrl driver"
+ depends on OF
select PINMUX
select PINCONF
select GENERIC_PINCONF
--
1.8.4.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
needs to depend on OF so as not to cause build problems on
archs that do not support OF.
Cc: Sherman Yin <sy...@broadcom.com>
Signed-off-by: Linus Walleij <linus....@linaro.org>
---
drivers/pinctrl/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
index f1dda4d9de13..be361b7cd30f 100644
--- a/drivers/pinctrl/Kconfig
+++ b/drivers/pinctrl/Kconfig
@@ -106,6 +106,7 @@ config PINCTRL_BCM2835
config PINCTRL_CAPRI
bool "Broadcom Capri pinctrl driver"
+ depends on OF
select PINMUX
select PINCONF
select GENERIC_PINCONF
--
1.8.4.2
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Sherman Yin
Jan 17, 2014, 3:00:03 PM1/17/14
to
On 14-01-16 02:45 PM, Linus Walleij wrote:
> As this driver is using pinconf_generic_dt_node_to_map_pin() it
> needs to depend on OF so as not to cause build problems on
> archs that do not support OF.
>
> Cc: Sherman Yin <sy...@broadcom.com>
> Signed-off-by: Linus Walleij <linus....@linaro.org>
> ---
> drivers/pinctrl/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index f1dda4d9de13..be361b7cd30f 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -106,6 +106,7 @@ config PINCTRL_BCM2835
>
> config PINCTRL_CAPRI
> bool "Broadcom Capri pinctrl driver"
> + depends on OF
> select PINMUX
> select PINCONF
> select GENERIC_PINCONF
>
Thanks for the fix, Linus. While we're visiting this config, should we
> As this driver is using pinconf_generic_dt_node_to_map_pin() it
> needs to depend on OF so as not to cause build problems on
> archs that do not support OF.
>
> Cc: Sherman Yin <sy...@broadcom.com>
> Signed-off-by: Linus Walleij <linus....@linaro.org>
> ---
> drivers/pinctrl/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> index f1dda4d9de13..be361b7cd30f 100644
> --- a/drivers/pinctrl/Kconfig
> +++ b/drivers/pinctrl/Kconfig
> @@ -106,6 +106,7 @@ config PINCTRL_BCM2835
>
> config PINCTRL_CAPRI
> bool "Broadcom Capri pinctrl driver"
> + depends on OF
> select PINMUX
> select PINCONF
> select GENERIC_PINCONF
>
add "depends on MACH_BCM_MOBILE" as well?
Thanks,
Sherman
Linus Walleij
Jan 17, 2014, 6:20:01 PM1/17/14
to
On Sat, Jan 18, 2014 at 12:12 AM, Linus Walleij
<linus....@linaro.org> wrote:
But maybe you can experiment with that special option that only
turns on the driver on other platforms to do compile test.
Yours,
Linus Walleij
<linus....@linaro.org> wrote:
> On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <sy...@broadcom.com> wrote:
>
>> Thanks for the fix, Linus. While we're visiting this config, should we add
>> "depends on MACH_BCM_MOBILE" as well?
>
> No, it's nice to get the compile coverage.
>
>> Thanks for the fix, Linus. While we're visiting this config, should we add
>> "depends on MACH_BCM_MOBILE" as well?
>
But maybe you can experiment with that special option that only
turns on the driver on other platforms to do compile test.
Yours,
Linus Walleij
Linus Walleij
Jan 17, 2014, 6:20:01 PM1/17/14
to
> Thanks for the fix, Linus. While we're visiting this config, should we add
> "depends on MACH_BCM_MOBILE" as well?
> "depends on MACH_BCM_MOBILE" as well?
No, it's nice to get the compile coverage.
Yours,
Linus Walleij
Stephen Warren
Jan 17, 2014, 6:30:01 PM1/17/14
to
On 01/17/2014 04:13 PM, Linus Walleij wrote:
> On Sat, Jan 18, 2014 at 12:12 AM, Linus Walleij
> <linus....@linaro.org> wrote:
>> On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <sy...@broadcom.com> wrote:
>>
>>> Thanks for the fix, Linus. While we're visiting this config, should we add
>>> "depends on MACH_BCM_MOBILE" as well?
>>
>> No, it's nice to get the compile coverage.
>
> But maybe you can experiment with that special option that only
> turns on the driver on other platforms to do compile test.
a/k/a
> On Sat, Jan 18, 2014 at 12:12 AM, Linus Walleij
> <linus....@linaro.org> wrote:
>> On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <sy...@broadcom.com> wrote:
>>
>>> Thanks for the fix, Linus. While we're visiting this config, should we add
>>> "depends on MACH_BCM_MOBILE" as well?
>>
>> No, it's nice to get the compile coverage.
>
> But maybe you can experiment with that special option that only
> turns on the driver on other platforms to do compile test.
depends on XXX || COMPILE_TEST
Linus Walleij
Jan 20, 2014, 3:20:02 AM1/20/14
to
On Sat, Jan 18, 2014 at 12:27 AM, Stephen Warren <swa...@wwwdotorg.org> wrote:
> On 01/17/2014 04:13 PM, Linus Walleij wrote:
>> On Sat, Jan 18, 2014 at 12:12 AM, Linus Walleij
>> <linus....@linaro.org> wrote:
>>> On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <sy...@broadcom.com> wrote:
>>>
>>>> Thanks for the fix, Linus. While we're visiting this config, should we add
>>>> "depends on MACH_BCM_MOBILE" as well?
>>>
>>> No, it's nice to get the compile coverage.
>>
>> But maybe you can experiment with that special option that only
>> turns on the driver on other platforms to do compile test.
>
> a/k/a
> depends on XXX || COMPILE_TEST
Yep, thanks Stephen :-)
> On 01/17/2014 04:13 PM, Linus Walleij wrote:
>> On Sat, Jan 18, 2014 at 12:12 AM, Linus Walleij
>> <linus....@linaro.org> wrote:
>>> On Fri, Jan 17, 2014 at 8:51 PM, Sherman Yin <sy...@broadcom.com> wrote:
>>>
>>>> Thanks for the fix, Linus. While we're visiting this config, should we add
>>>> "depends on MACH_BCM_MOBILE" as well?
>>>
>>> No, it's nice to get the compile coverage.
>>
>> But maybe you can experiment with that special option that only
>> turns on the driver on other platforms to do compile test.
>
> a/k/a
> depends on XXX || COMPILE_TEST
Linus Walleij
0 new messages