Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

usb: gadget: net2280: CONFIG_USB_GADGET_PDEBUG_FILES?

29 views
Skip to first unread message

Paul Bolle

unread,
Jul 4, 2014, 3:40:02 AM7/4/14
to
Commit e56e69cc0ff4 ("usb: gadget: net2280: Use pr_* function") is
included in today's linux-next (ie, next-20140704).

It contains this odd chunk:
@@ -1566,7 +1563,7 @@ static const struct usb_gadget_ops net2280_ops = {

/*-------------------------------------------------------------------------*/

-#ifdef CONFIG_USB_GADGET_DEBUG_FILES
+#ifdef CONFIG_USB_GADGET_PDEBUG_FILES

/* FIXME move these into procfs, and use seq_file.
* Sysfs _still_ doesn't behave for arbitrarily sized files,

(Commit b7ca96655ddd ("usb: gadget: Gadget directory cleanup - group UDC
drivers"), also included in today's linux-next, moved that new check for
CONFIG_USB_GADGET_PDEBUG_FILES to drivers/usb/gadget/udc/net2280.c.)

Using CONFIG_USB_GADGET_PDEBUG_FILES appears to be just an editing
mistake. Would Ricardo like to submit the trivial patch to clean it up
or should I do that?


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Ricardo Ribalda Delgado

unread,
Jul 4, 2014, 5:30:02 AM7/4/14
to
My fault. Thank you very much for reporting it. I have just posted the patch


Regards

On Fri, Jul 4, 2014 at 9:37 AM, Paul Bolle <peb...@tiscali.nl> wrote:
> Commit e56e69cc0ff4 ("usb: gadget: net2280: Use pr_* function") is
> included in today's linux-next (ie, next-20140704).
>
> It contains this odd chunk:
> @@ -1566,7 +1563,7 @@ static const struct usb_gadget_ops net2280_ops = {
>
> /*-------------------------------------------------------------------------*/
>
> -#ifdef CONFIG_USB_GADGET_DEBUG_FILES
> +#ifdef CONFIG_USB_GADGET_PDEBUG_FILES
>
> /* FIXME move these into procfs, and use seq_file.
> * Sysfs _still_ doesn't behave for arbitrarily sized files,
>
> (Commit b7ca96655ddd ("usb: gadget: Gadget directory cleanup - group UDC
> drivers"), also included in today's linux-next, moved that new check for
> CONFIG_USB_GADGET_PDEBUG_FILES to drivers/usb/gadget/udc/net2280.c.)
>
> Using CONFIG_USB_GADGET_PDEBUG_FILES appears to be just an editing
> mistake. Would Ricardo like to submit the trivial patch to clean it up
> or should I do that?
>
>
> Paul Bolle
>



--
Ricardo Ribalda

Ed Tomlinson

unread,
Jul 5, 2014, 11:00:02 AM7/5/14
to
Hi

I have a raspberry PI sending its console to my box via a pl2303

[ 5.184385] usbserial: USB Serial support registered for pl2303
[ 5.184398] pl2303 1-2.6:1.0: pl2303 converter detected
[ 5.185353] usb 1-2.6: pl2303 converter now attached to ttyUSB0

and with the latest fixes from git on 3.16 its now started spamming my logs with:

[55507.155354] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback - nonzero urb status: -71
[55510.736558] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback - nonzero urb status: -71
[55517.238586] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback - nonzero urb status: -71
[55521.099938] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback - nonzero urb status: -71
[55521.778520] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback - nonzero urb status: -71
[55523.229808] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback - nonzero urb status: -71
[55523.229846] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback - nonzero urb status: -71
[55525.074519] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback - nonzero urb status: -71
[55527.270207] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback - nonzero urb status: -71

Please fix.

Thanks
Ed Tomlinson

Greg KH

unread,
Jul 5, 2014, 2:00:02 PM7/5/14
to
On Sat, Jul 05, 2014 at 10:55:57AM -0400, Ed Tomlinson wrote:
> Hi
>
> I have a raspberry PI sending its console to my box via a pl2303

What exact pl2303 is this? Can you provide the output from 'lsusb'?

> [ 5.184385] usbserial: USB Serial support registered for pl2303
> [ 5.184398] pl2303 1-2.6:1.0: pl2303 converter detected
> [ 5.185353] usb 1-2.6: pl2303 converter now attached to ttyUSB0
>
> and with the latest fixes from git on 3.16 its now started spamming my logs with:
>
> [55507.155354] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback - nonzero urb status: -71
> [55510.736558] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback - nonzero urb status: -71
> [55517.238586] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback - nonzero urb status: -71
> [55521.099938] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback - nonzero urb status: -71
> [55521.778520] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback - nonzero urb status: -71
> [55523.229808] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback - nonzero urb status: -71
> [55523.229846] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback - nonzero urb status: -71
> [55525.074519] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback - nonzero urb status: -71
> [55527.270207] pl2303 ttyUSB0: usb_serial_generic_read_bulk_callback - nonzero urb status: -71

That's saying there was one of the following errors in this device:
a) bitstuff error
b) no response packet received within the prescribed bus turn-around
time
c) unknown USB error

All of which point to either a problem in the USB host controller, or
the usb device itself.

Is this an "unpatched" 3.16-rc kernel running on the rpi? If so, odds
are it's a host controller issue...

thanks,

greg k-h

Ed Tomlinson

unread,
Jul 5, 2014, 9:50:02 PM7/5/14
to
Hi,

The kernel in question is running on a i7 with a pi connected via to the i6 via the pl2303 to view the pi's console.

The kernel on the i7 is at level:

commit 77c4cf17ae867ba93233b3832bda3de7adaae326
Merge: 88b5a85 133d452
Author: Linus Torvalds <torv...@linux-foundation.org>
Date: Fri Jul 4 09:37:43 2014 -0700

There is one extra patch applied to fix a problem with the boot stalling
see the patch from Chris Wilson in the thread: [PATCH 5/5] drm/i915: Kick out vga console

Here is a lsusb -v

Bus 001 Device 011: ID 067b:2303 Prolific Technology, Inc. PL2303 Serial Port
Device Descriptor:
bLength 18
bDescriptorType 1
bcdUSB 1.10
bDeviceClass 0 (Defined at Interface level)
bDeviceSubClass 0
bDeviceProtocol 0
bMaxPacketSize0 64
idVendor 0x067b Prolific Technology, Inc.
idProduct 0x2303 PL2303 Serial Port
bcdDevice 3.00
iManufacturer 1 Prolific Technology Inc.
iProduct 2 USB-Serial Controller
iSerial 0
bNumConfigurations 1
Configuration Descriptor:
bLength 9
bDescriptorType 2
wTotalLength 39
bNumInterfaces 1
bConfigurationValue 1
iConfiguration 0
bmAttributes 0x80
(Bus Powered)
MaxPower 100mA
Interface Descriptor:
bLength 9
bDescriptorType 4
bInterfaceNumber 0
bAlternateSetting 0
bNumEndpoints 3
bInterfaceClass 255 Vendor Specific Class
bInterfaceSubClass 0
bInterfaceProtocol 0
iInterface 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x81 EP 1 IN
bmAttributes 3
Transfer Type Interrupt
Synch Type None
Usage Type Data
wMaxPacketSize 0x000a 1x 10 bytes
bInterval 1
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x02 EP 2 OUT
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 0
Endpoint Descriptor:
bLength 7
bDescriptorType 5
bEndpointAddress 0x83 EP 3 IN
bmAttributes 2
Transfer Type Bulk
Synch Type None
Usage Type Data
wMaxPacketSize 0x0040 1x 64 bytes
bInterval 0
Device Status: 0x0000
(Bus Powered)

Thanks
Ed
0 new messages