DMA_ERROR_CODE (was: Re: linux-next: build failure after merge of the final tree)
Geert Uytterhoeven
> After merging the final tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
>
> drivers/mtd/nand/r852.c:22: error: 'enable_dma' redeclared as different kind of symbol
> arch/powerpc/include/asm/dma.h:189: note: previous definition of 'enable_dma' was here
> drivers/mtd/nand/r852.c: In function 'r852_engine_enable':
> drivers/mtd/nand/r852.c:545: error: implicit declaration of function 'msleep'
>
> Caused by commit 67e054e919248fa1db93de727fb9ad49eb700642 ("mtd: nand:
> Add driver for Ricoh xD/SmartMedia reader") from the mtd.
>
> I applied the following patch for today.
>
> From: Stephen Rothwell <s...@canb.auug.org.au>
> Date: Mon, 1 Mar 2010 20:21:06 +1100
> Subject: [PATCH] mtd: nand: fix name space clash
>
> and include delay.h for msleep().
Another issue is that this driver uses DMA_ERROR_CODE, which is currently
defined on powerpc/sparc/x86 only.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- ge...@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
FUJITA Tomonori
Geert Uytterhoeven <ge...@linux-m68k.org> wrote:
> On Mon, Mar 1, 2010 at 10:40, Stephen Rothwell <s...@canb.auug.org.au> wrote:
> > After merging the final tree, today's linux-next build (powerpc
> > allyesconfig) failed like this:
> >
> > drivers/mtd/nand/r852.c:22: error: 'enable_dma' redeclared as different kind of symbol
> > arch/powerpc/include/asm/dma.h:189: note: previous definition of 'enable_dma' was here
> > drivers/mtd/nand/r852.c: In function 'r852_engine_enable':
> > drivers/mtd/nand/r852.c:545: error: implicit declaration of function 'msleep'
> >
> > Caused by commit 67e054e919248fa1db93de727fb9ad49eb700642 ("mtd: nand:
> > Add driver for Ricoh xD/SmartMedia reader") from the mtd.
> >
> > I applied the following patch for today.
> >
> > From: Stephen Rothwell <s...@canb.auug.org.au>
> > Date: Mon, 1 Mar 2010 20:21:06 +1100
> > Subject: [PATCH] mtd: nand: fix name space clash
> >
> > and include delay.h for msleep().
>
> Another issue is that this driver uses DMA_ERROR_CODE, which is currently
> defined on powerpc/sparc/x86 only.
Why can't use dma_mapping_error()?
David Woodhouse
> On Wed, 10 Mar 2010 12:03:37 +0100
> Geert Uytterhoeven <ge...@linux-m68k.org> wrote:
>
> > On Mon, Mar 1, 2010 at 10:40, Stephen Rothwell <s...@canb.auug.org.au> wrote:
> > > After merging the final tree, today's linux-next build (powerpc
> > > allyesconfig) failed like this:
> > >
> > > drivers/mtd/nand/r852.c:22: error: 'enable_dma' redeclared as different kind of symbol
> > > arch/powerpc/include/asm/dma.h:189: note: previous definition of 'enable_dma' was here
> > > drivers/mtd/nand/r852.c: In function 'r852_engine_enable':
> > > drivers/mtd/nand/r852.c:545: error: implicit declaration of function 'msleep'
> > >
> > > Caused by commit 67e054e919248fa1db93de727fb9ad49eb700642 ("mtd: nand:
> > > Add driver for Ricoh xD/SmartMedia reader") from the mtd.
> > >
> > > I applied the following patch for today.
> > >
> > > From: Stephen Rothwell <s...@canb.auug.org.au>
> > > Date: Mon, 1 Mar 2010 20:21:06 +1100
> > > Subject: [PATCH] mtd: nand: fix name space clash
> > >
> > > and include delay.h for msleep().
> >
> > Another issue is that this driver uses DMA_ERROR_CODE, which is currently
> > defined on powerpc/sparc/x86 only.
>
> Why can't use dma_mapping_error()?
http://git.infradead.org/mtd-2.6.git/commitdiff/0c82d3ce
--
David Woodhouse Open Source Technology Centre
David.W...@intel.com Intel Corporation