Re: 5.17.0 boot issue on Miata

[Bob Tracy]

(Adding linux-scsi and linux-kernel, now that bisection is complete.)

On Wed, Apr 06, 2022 at 05:44:01PM -0500, Bob Tracy wrote:
> v5.17-rc2 ok. v5.17-rc3 I get the disk sector errors and hang that I
> reported in the first message in this thread.

This is on an Alpha Miata platform (PWS 433au) with QLogic ISP1020 controller.

Here's the implicated commit:

edb854a3680bacc9ef9b91ec0c5ff6105886f6f3 is the first bad commit
commit edb854a3680bacc9ef9b91ec0c5ff6105886f6f3
Author: Ming Lei <ming...@redhat.com>
Date: Thu Jan 27 23:37:33 2022 +0800

scsi: core: Reallocate device's budget map on queue depth change

We currently use ->cmd_per_lun as initial queue depth for setting up the
budget_map. Martin Wilck reported that it is common for the queue_depth to
be subsequently updated in slave_configure() based on detected hardware
characteristics.

As a result, for some drivers, the static host template settings for
cmd_per_lun and can_queue won't actually get used in practice. And if the
default values are used to allocate the budget_map, memory may be consumed
unnecessarily.

Fix the issue by reallocating the budget_map after ->slave_configure()
returns. At that time the device queue_depth should accurately reflect what
the hardware needs.

Link: https://lore.kernel.org/r/20220127153733.4...@redhat.com
Cc: Bart Van Assche <bvana...@acm.org>
Reported-by: Martin Wilck <martin...@suse.com>
Suggested-by: Martin Wilck <martin...@suse.com>
Tested-by: Martin Wilck <mwi...@suse.com>
Reviewed-by: Martin Wilck <mwi...@suse.com>
Reviewed-by: Bart Van Assche <bvana...@acm.org>
Signed-off-by: Ming Lei <ming...@redhat.com>
Signed-off-by: Martin K. Petersen <martin....@oracle.com>

drivers/scsi/scsi_scan.c | 55 +++++++++++++++++++++++++++++++++++++++++++-----
1 file changed, 50 insertions(+), 5 deletions(-)

Respectfully,
--Bob

[John Garry]

On 19/04/2022 05:53, Bob Tracy wrote:
> (Adding linux-scsi and linux-kernel, now that bisection is complete.)
>
> On Wed, Apr 06, 2022 at 05:44:01PM -0500, Bob Tracy wrote:
>> v5.17-rc2 ok. v5.17-rc3 I get the disk sector errors and hang that I
>> reported in the first message in this thread.
> This is on an Alpha Miata platform (PWS 433au) with QLogic ISP1020 controller.
>
> Here's the implicated commit:
>
> edb854a3680bacc9ef9b91ec0c5ff6105886f6f3 is the first bad commit
> commit edb854a3680bacc9ef9b91ec0c5ff6105886f6f3
> Author: Ming Lei<ming...@redhat.com>
> Date: Thu Jan 27 23:37:33 2022 +0800
>
> scsi: core: Reallocate device's budget map on queue depth change
>

Please try v5.18-rc2 as it should have a fix in commit eaba83b5b850

Thanks,
John

[Bob Tracy]

On Mon, Apr 25, 2022 at 10:26:46AM +0100, John Garry wrote:
> Please try v5.18-rc2 as it should have a fix in commit eaba83b5b850

Up and running on v5.18-rc5 as I type this. Fix confirmed. Thanks!

--Bob