Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] mmc:sdio:guarantee setting card data bus width as 4-bit

56 views
Skip to first unread message

yongd

unread,
May 14, 2012, 4:40:01 AM5/14/12
to
SDIO_CCCR_IF[1:0] in SDIO card is used for card data bus width
setting as below,
00b: 1-bit bus
01b: Reserved
10b: 4-bit bus
11b: 8-bit bus(only for embedded SDIO)
And sdio_enable_wide is for setting data bus width as 4-bit. But
currently, it 1stly read the register, 2ndly OR' 1b with SDIO_CCCR_IF[1],
and then write it back.
As we can see, such way is based on such assumption that the
SDIO_CCCR_IF[0] is always 0. Apparently, this is not right.

Signed-off-by: yongd <yo...@marvell.com>
---
drivers/mmc/core/sdio.c | 6 ++++++
include/linux/mmc/sdio.h | 2 ++
2 files changed, 8 insertions(+)

diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
index 13d0e95..6b6f902 100644
--- a/drivers/mmc/core/sdio.c
+++ b/drivers/mmc/core/sdio.c
@@ -218,6 +218,12 @@ static int sdio_enable_wide(struct mmc_card *card)
if (ret)
return ret;

+ if ((ctrl & SDIO_BUS_WIDTH_MASK)
+ == SDIO_BUS_WIDTH_RESERVED)
+ printk(KERN_WARNING"SDIO_CCCR_IF is invalid: %d\n", ctrl);
+
+ /* set as 4-bit bus width */
+ ctrl &= ~SDIO_BUS_WIDTH_MASK;
ctrl |= SDIO_BUS_WIDTH_4BIT;

ret = mmc_io_rw_direct(card, 1, 0, SDIO_CCCR_IF, ctrl, NULL);
diff --git a/include/linux/mmc/sdio.h b/include/linux/mmc/sdio.h
index c9fe66c..17446d3 100644
--- a/include/linux/mmc/sdio.h
+++ b/include/linux/mmc/sdio.h
@@ -98,7 +98,9 @@

#define SDIO_CCCR_IF 0x07 /* bus interface controls */

+#define SDIO_BUS_WIDTH_MASK 0x03 /* data bus width setting */
#define SDIO_BUS_WIDTH_1BIT 0x00
+#define SDIO_BUS_WIDTH_RESERVED 0x01
#define SDIO_BUS_WIDTH_4BIT 0x02
#define SDIO_BUS_ECSI 0x20 /* Enable continuous SPI interrupt */
#define SDIO_BUS_SCSI 0x40 /* Support continuous SPI interrupt */
--
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Philip Rakity

unread,
May 14, 2012, 10:10:02 AM5/14/12
to

ACK

but see below for printk change
printk(KERN_WARNING("%s: SDIO_CCCR_IF is invalid: %02X\n", mmc_hostname(card->host), ctrl);

please double check mmc_hostname argument.

yongd

unread,
May 15, 2012, 1:20:01 AM5/15/12
to
SDIO_CCCR_IF[1:0] in SDIO card is used for card data bus width
setting as below,
00b: 1-bit bus
01b: Reserved
10b: 4-bit bus
11b: 8-bit bus(only for embedded SDIO)
And sdio_enable_wide is for setting data bus width as 4-bit. But
currently, it 1stly read the register, 2ndly OR' 1b with SDIO_CCCR_IF[1],
and then write it back.
As we can see, such way is based on such assumption that the
SDIO_CCCR_IF[0] is always 0. Apparently, this is not right.

Signed-off-by: yongd <yo...@marvell.com>
---
drivers/mmc/core/sdio.c | 7 +++++++
include/linux/mmc/sdio.h | 2 ++
2 files changed, 9 insertions(+)

diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
index 13d0e95..7b528cf 100644
--- a/drivers/mmc/core/sdio.c
+++ b/drivers/mmc/core/sdio.c
@@ -218,6 +218,13 @@ static int sdio_enable_wide(struct mmc_card *card)
if (ret)
return ret;

+ if ((ctrl & SDIO_BUS_WIDTH_MASK)
+ == SDIO_BUS_WIDTH_RESERVED)
+ printk(KERN_WARNING"%s: SDIO_CCCR_IF is invalid: 0x%02X\n",
+ mmc_hostname(card->host), ctrl);

Philip Rakity

unread,
May 15, 2012, 1:20:02 AM5/15/12
to

ACK

Yong Ding

unread,
May 15, 2012, 1:20:02 AM5/15/12
to
Philip,
Thanks for your comment. And have sent out "[PATCH v2] mmc:sdio:guarantee setting card data bus width as 4-bit " which uses the below printk.

printk(KERN_WARNING("%s: SDIO_CCCR_IF is invalid: 0x%02X\n", mmc_hostname(card->host), ctrl);


Best Wishes,

Yong Ding
Operating Systems Engineering,
Application Processor Systems Engineering

Chris Ball

unread,
May 17, 2012, 8:40:02 AM5/17/12
to
Hi,

On Tue, May 15 2012, yongd wrote:
> SDIO_CCCR_IF[1:0] in SDIO card is used for card data bus width
> setting as below,
> 00b: 1-bit bus
> 01b: Reserved
> 10b: 4-bit bus
> 11b: 8-bit bus(only for embedded SDIO)
> And sdio_enable_wide is for setting data bus width as 4-bit. But
> currently, it 1stly read the register, 2ndly OR' 1b with SDIO_CCCR_IF[1],
> and then write it back.
> As we can see, such way is based on such assumption that the
> SDIO_CCCR_IF[0] is always 0. Apparently, this is not right.
>
> Signed-off-by: yongd <yo...@marvell.com>

Thanks. Can we have your full name, for the copyright record?

- Chris.
--
Chris Ball <c...@laptop.org> <http://printf.net/>
One Laptop Per Child

Yong Ding

unread,
May 17, 2012, 10:00:01 PM5/17/12
to
Chris,
Thanks. And my full name is Yong Ding.

Best Wishes,

Yong Ding
Operating Systems Engineering,
Application Processor Systems Engineering

-----Original Message-----
From: Chris Ball [mailto:c...@laptop.org]
Sent: Thursday, May 17, 2012 8:38 PM
To: Yong Ding

Chris Ball

unread,
Jun 6, 2012, 9:30:03 AM6/6/12
to
Hi,

On Tue, May 15 2012, yongd wrote:
Thanks, pushed to mmc-next for 3.5.

- Chris.
--
Chris Ball <c...@laptop.org> <http://printf.net/>
One Laptop Per Child

Yong Ding

unread,
Jun 6, 2012, 9:40:01 PM6/6/12
to
Chris,
Thanks, and very glad to hear this:-)

Best Wishes,

Yong Ding
Operating Systems Engineering,
Application Processor Systems Engineering

-----Original Message-----
From: Chris Ball [mailto:c...@laptop.org]
Sent: Wednesday, June 06, 2012 9:24 PM
To: Yong Ding
Cc: linu...@vger.kernel.org; Philip Rakity; oh...@wizery.com; linus....@linaro.org; ulf.h...@stericsson.com; linux-...@vger.kernel.org
Subject: Re: [PATCH v2] mmc:sdio:guarantee setting card data bus width as 4-bit

0 new messages