Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH 1/2] ds2781_battery: convert to module_platform_driver

259 views
Skip to first unread message

Devendra Naga

unread,
Jul 30, 2012, 6:50:02 AM7/30/12
to
module_platform_driver can be used to replace the
platform_driver register and unregister functions,
with the calls to module_init and module_exit,

i.e. all the code that is doing like the below

static int __init mymod_init(void)
{
return platform_driver_register(&drv_operations);
}

static void __exit mymod_exit(void)
{
platform_driver_unregister(&drv_operations);
}

module_init(mymod_init);
module_exit(mymod_exit);

can be replaced with
module_platform_driver(drv_operations)...

Signed-off-by: Devendra Naga <develker...@gmail.com>
---
drivers/power/ds2781_battery.c | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)

diff --git a/drivers/power/ds2781_battery.c b/drivers/power/ds2781_battery.c
index 7a1ff4e..8f84ab7 100644
--- a/drivers/power/ds2781_battery.c
+++ b/drivers/power/ds2781_battery.c
@@ -835,19 +835,7 @@ static struct platform_driver ds2781_battery_driver = {
.remove = __devexit_p(ds2781_battery_remove),
};

-static int __init ds2781_battery_init(void)
-{
- return platform_driver_register(&ds2781_battery_driver);
-}
-
-static void __exit ds2781_battery_exit(void)
-{
- platform_driver_unregister(&ds2781_battery_driver);
-}
-
-module_init(ds2781_battery_init);
-module_exit(ds2781_battery_exit);
-
+module_platform_driver(ds2781_battery_driver);

MODULE_LICENSE("GPL");
MODULE_AUTHOR("Renata Sayakhova <ren...@oktetlabs.ru>");
--
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Anton Vorontsov

unread,
Aug 22, 2012, 11:00:01 PM8/22/12
to
On Mon, Jul 30, 2012 at 04:29:10PM +0545, Devendra Naga wrote:
> module_platform_driver can be used to replace the
> platform_driver register and unregister functions,
> with the calls to module_init and module_exit,
>
> i.e. all the code that is doing like the below
>
> static int __init mymod_init(void)
> {
> return platform_driver_register(&drv_operations);
> }
>
> static void __exit mymod_exit(void)
> {
> platform_driver_unregister(&drv_operations);
> }
>
> module_init(mymod_init);
> module_exit(mymod_exit);
>
> can be replaced with
> module_platform_driver(drv_operations)...
>
> Signed-off-by: Devendra Naga <develker...@gmail.com>

Nice! Both patches applied, thank you!
0 new messages