Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH 2/2] Staging: lustre: Fix return does not need parantheses

0 views
Skip to first unread message

MonamAgarwal

unread,
Jan 5, 2014, 3:30:01 PM1/5/14
to
This patch fixes the following checkpatch.pl warning in
lustre/ldlm/interval_tree.c
ERROR: return is not a function, parentheses are not required

Signed-off-by: MonamAgarwal <monamag...@gmail.com>
---
drivers/staging/lustre/lustre/ldlm/interval_tree.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/ldlm/interval_tree.c b/drivers/staging/lustre/lustre/ldlm/interval_tree.c
index f61bf19..9338203 100644
--- a/drivers/staging/lustre/lustre/ldlm/interval_tree.c
+++ b/drivers/staging/lustre/lustre/ldlm/interval_tree.c
@@ -578,8 +578,8 @@ EXPORT_SYMBOL(interval_erase);
static inline int interval_may_overlap(struct interval_node *node,
struct interval_node_extent *ext)
{
- return (ext->start <= node->in_max_high &&
- ext->end >= interval_low(node));
+ return ext->start <= node->in_max_high &&
+ ext->end >= interval_low(node);
}

/*
--
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Greg KH

unread,
Jan 8, 2014, 7:00:02 PM1/8/14
to
On Mon, Jan 06, 2014 at 01:48:07AM +0530, MonamAgarwal wrote:
> This patch fixes the following checkpatch.pl warning in
> lustre/ldlm/interval_tree.c
> ERROR: return is not a function, parentheses are not required
>
> Signed-off-by: MonamAgarwal <monamag...@gmail.com>

I need a semblance of a "real" name, which usually consists of a first
and last name for most places.

thanks,

greg k-h

Monam Agarwal

unread,
Jan 11, 2014, 5:30:02 AM1/11/14
to
This patch fixes the following checkpatch.pl warning in
lustre/ldlm/interval_tree.c
ERROR: return is not a function, parentheses are not required

Signed-off-by: Monam Agarwal <monamag...@gmail.com>
---
drivers/staging/lustre/lustre/ldlm/interval_tree.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/lustre/lustre/ldlm/interval_tree.c b/drivers/staging/lustre/lustre/ldlm/interval_tree.c
index 7c956de..fb64aea 100644
--- a/drivers/staging/lustre/lustre/ldlm/interval_tree.c
+++ b/drivers/staging/lustre/lustre/ldlm/interval_tree.c
@@ -585,8 +585,8 @@ EXPORT_SYMBOL(interval_erase);
static inline int interval_may_overlap(struct interval_node *node,
struct interval_node_extent *ext)
{
- return (ext->start <= node->in_max_high &&
- ext->end >= interval_low(node));
+ return ext->start <= node->in_max_high &&
+ ext->end >= interval_low(node);
}

/*
--
1.7.9.5

Monam Agarwal

unread,
Jan 11, 2014, 6:10:02 AM1/11/14
to
This patch fixes the following checkpatch.pl warning in
lustre/ldlm/interval_tree.c
ERROR: return is not a function, parentheses are not required

Signed-off-by: Monam Agarwal <monamag...@gmail.com>
---

Changes since version 1:
* Incoorect signed-off-by line

Changes since version 2:
* Forgot change log

Monam Agarwal

unread,
Jan 11, 2014, 8:50:03 AM1/11/14
to
This fixes the following checkpatch error in lustre/ldlm/ldlm_flock.c
ERROR: return is not a function, parentheses are not required

Signed-off-by: Monam Agarwal <monamag...@gmail.com>
---
drivers/staging/lustre/lustre/ldlm/ldlm_flock.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c
index c9aae13..07a2c33 100644
--- a/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c
+++ b/drivers/staging/lustre/lustre/ldlm/ldlm_flock.c
@@ -81,18 +81,18 @@ int ldlm_flock_blocking_ast(struct ldlm_lock *lock, struct ldlm_lock_desc *desc,
static inline int
ldlm_same_flock_owner(struct ldlm_lock *lock, struct ldlm_lock *new)
{
- return((new->l_policy_data.l_flock.owner ==
+ return (new->l_policy_data.l_flock.owner ==
lock->l_policy_data.l_flock.owner) &&
- (new->l_export == lock->l_export));
+ (new->l_export == lock->l_export);
}

static inline int
ldlm_flocks_overlap(struct ldlm_lock *lock, struct ldlm_lock *new)
{
- return((new->l_policy_data.l_flock.start <=
+ return (new->l_policy_data.l_flock.start <=
lock->l_policy_data.l_flock.end) &&
(new->l_policy_data.l_flock.end >=
- lock->l_policy_data.l_flock.start));
+ lock->l_policy_data.l_flock.start);
}

static inline void ldlm_flock_blocking_link(struct ldlm_lock *req,

Monam Agarwal

unread,
Jan 11, 2014, 3:10:02 PM1/11/14
to
The patch fixes the following checkpatch.pl error in

Greg KH

unread,
Jan 11, 2014, 3:40:01 PM1/11/14
to
On Sun, Jan 12, 2014 at 01:31:41AM +0530, Monam Agarwal wrote:
> The patch fixes the following checkpatch.pl error in
> lustre/ldlm/ldlm_flock.c
> ERROR: return is not a function, parentheses are not required
>
> Signed-off-by: Monam Agarwal <monamag...@gmail.com>

I'm totally confused here. You have multiple series of patches, sent
with different version numbers, some with the same subjects, and some
not.

I've deleted all of your lustre patches from my queue because of this, I
don't want to apply something incorrectly.

Please step back, take a day, and resend all of your pending patches
that I have not applied for the lustre code, in a single series, so I
know what I should be looking at here.

There's no rush, so please take your time and do your best to keep an
overworked maintainer from getting things wrong.

thanks,

greg k-h
0 new messages