[PATCH] VLYNQ: add missing linux/irq.h include
Florian Fainelli
which will trigger compilation errors on non-AR7
platforms (i.e: TI Davinci).
Reported-by: Rohan Tabish <rohan...@yahoo.co.uk>
Signed-off-by: Regards, Florian Fainelli <flo...@openwrt.org>
---
diff --git a/drivers/vlynq/vlynq.c b/drivers/vlynq/vlynq.c
index 9554ad5..14b1af9 100644
--- a/drivers/vlynq/vlynq.c
+++ b/drivers/vlynq/vlynq.c
@@ -30,6 +30,7 @@
#include <linux/interrupt.h>
#include <linux/delay.h>
#include <linux/io.h>
+#include <linux/irq.h>
#include <linux/vlynq.h>
--
1.6.3.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Christoph Hellwig
> This patch adds the missing linux/irq.h header
> which will trigger compilation errors on non-AR7
> platforms (i.e: TI Davinci).
linux/irq.h should not be included by drivers. It's an internal handler
for the generic hardirq code. All functions for use by drivers are in
linux/interrupt.h
Florian Fainelli
Le lundi 4 janvier 2010 19:12:28, Christoph Hellwig a �crit :
> On Mon, Jan 04, 2010 at 06:38:51PM +0100, Florian Fainelli wrote:
> > This patch adds the missing linux/irq.h header
> > which will trigger compilation errors on non-AR7
> > platforms (i.e: TI Davinci).
>
> linux/irq.h should not be included by drivers. It's an internal handler
> for the generic hardirq code. All functions for use by drivers are in
> linux/interrupt.h
vlynq.c references definitions that are in linux/irq.h and not in
linux/interrupt.h (like IRQ_TYPE_*), thus the include.
--
Best regards, Florian Fainelli
Email: flo...@openwrt.org
Web: http://openwrt.org
IRC: [florian] on irc.freenode.net
-------------------------------