Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[PATCH] rcu: remove lock acquirement when very eary boot

1 view
Skip to first unread message

Lai Jiangshan

unread,
Mar 27, 2010, 11:20:02 PM3/27/10
to

cleanup: remove lock acquirement when very eary boot

Signed-off-by: Lai Jiangshan <la...@cn.fujitsu.com>
---
diff --git a/kernel/rcutree.c b/kernel/rcutree.c
index 112edb5..e6014e1 100644
--- a/kernel/rcutree.c
+++ b/kernel/rcutree.c
@@ -1646,13 +1646,10 @@ EXPORT_SYMBOL_GPL(rcu_barrier_sched);
static void __init
rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
{
- unsigned long flags;
int i;
struct rcu_data *rdp = rsp->rda[cpu];
- struct rcu_node *rnp = rcu_get_root(rsp);

/* Set up local state, ensuring consistent view of global state. */
- raw_spin_lock_irqsave(&rnp->lock, flags);
rdp->grpmask = 1UL << (cpu - rdp->mynode->grplo);
rdp->nxtlist = NULL;
for (i = 0; i < RCU_NEXT_SIZE; i++)
@@ -1662,7 +1659,6 @@ rcu_boot_init_percpu_data(int cpu, struct rcu_state *rsp)
rdp->dynticks = &per_cpu(rcu_dynticks, cpu);
#endif /* #ifdef CONFIG_NO_HZ */
rdp->cpu = cpu;
- raw_spin_unlock_irqrestore(&rnp->lock, flags);
}

/*

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Paul E. McKenney

unread,
Mar 28, 2010, 12:20:01 AM3/28/10
to
On Sun, Mar 28, 2010 at 11:14:13AM +0800, Lai Jiangshan wrote:
>
> cleanup: remove lock acquirement when very eary boot

This is indeed a safe change, however, I am keeping this lock acquisition
and release for documentation purposes. Call me paranoid, but...

Thanx, Paul

0 new messages