Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

next-20151101 - depmod issues with Lustre modules

224 views
Skip to first unread message

Valdis Kletnieks

unread,
Nov 2, 2015, 10:50:07 AM11/2/15
to
next-20151101 compiles fine, but depmod has a cow:

depmod: ERROR: Found 2 modules in dependency cycles!
depmod: ERROR: Cycle detected: lnet -> libcfs -> lnet

Sorry, not sure which commit(s) introduced the issue. next-20151022
was OK.


Linus Torvalds

unread,
Nov 7, 2015, 5:40:07 PM11/7/15
to
On Sat, Nov 7, 2015 at 12:37 PM, Dmitry Safonov <0x7f4...@gmail.com> wrote:
> Reproduced on mainline v4.3-9038-g27eb427bdc0960 with
> Arch Linux default config (attached):
>
> depmod: ERROR: Found 2 modules in dependency cycles!
> depmod: ERROR: Cycle detected: lnet -> libcfs -> lnet
> make: *** [_modinst_post] Error 1

The reason seems to be that

- lnet.ko provides the following functions needed by libcfs.ko:

libcfs_next_nidstring
libcfs_nid2str_r

- libcfs.ko provides the following functions needed by lnet.ko:

libcfs_debug
libcfs_debug_msg
libcfs_deregister_ioctl
libcfs_register_ioctl
libcfs_subsystem_debug
lustre_insert_debugfs

but I may have messed up something.

Anyway, the problem seems to be that - insanely - lnet.ko provides
those libcfs nid handling functions. They should be in libcfs, as far
as I can tell, just judging by the name. Also judging by the use.

The cause seems to be commit 47ca6ec2673e ("staging: lustre: move
nidstring handling to LNet layer") by James Simmons.

I do wonder if linux-next could perhaps do some modprobe testing too?

Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Simmons, James A.

unread,
Nov 9, 2015, 4:50:06 PM11/9/15
to

>Reproduced on mainline v4.3-9038-g27eb427bdc0960 with
>Arch Linux default config (attached):
>
>depmod: ERROR: Found 2 modules in dependency cycles!
>depmod: ERROR: Cycle detected: lnet -> libcfs -> lnet
>make: *** [_modinst_post] Error 1

I submitted a patch (staging: lustre: remove IOC_LIBCFS_PING_TEST ioctl) to fix this.
It should be merged soon.

Stephen Rothwell

unread,
Nov 12, 2015, 5:20:06 PM11/12/15
to
Hi Linus,

On Sat, 7 Nov 2015 14:30:44 -0800 Linus Torvalds <torv...@linux-foundation.org> wrote:
>
> I do wonder if linux-next could perhaps do some modprobe testing too?

I have added an x86_64 allmodconfig modules_install to my
end-of-day-before-release builds. Is that useful/sufficient? It seems
to work fine at the moment.

--
Cheers,
Stephen Rothwell s...@canb.auug.org.au
0 new messages