RE: [PATCH v2 0/4] X86/KVM: enable Intel MPX for KVM

Liu, Jinsong

unread,

Dec 11, 2013, 3:40:01 AM12/11/13

to

Paolo, comments for version 2?

Thanks,
Jinsong

Liu, Jinsong wrote:
> These patches are version 2 to enalbe Intel MPX for KVM.
>
> Version 1:
> * Add some Intel MPX definiation
> * Fix a cpuid(0x0d, 0) exposing bug, dynamic per XCR0 features
> enable/disable
> * vmx and msr handle for MPX support at KVM
> * enalbe MPX feature for guest
>
> Version 2:
> * remove generic MPX definiation, kernel side has add the
> definiation
> * add MSR_IA32_BNDCFGS to msrs_to_save
>
> Thanks,
> Jinsong
>
> Liu Jinsong (4):
> KVM/X86: Fix xsave cpuid exposing bug
> KVM/X86: Intel MPX vmx and msr handle
> KVM/X86: add MSR_IA32_BNDCFGS to msrs_to_save
> KVM/X86: Enable Intel MPX for guest.
>
> arch/x86/include/asm/vmx.h | 4 ++++
> arch/x86/include/asm/xsave.h | 2 ++
> arch/x86/include/uapi/asm/msr-index.h | 1 +
> arch/x86/kvm/cpuid.c | 8 ++++----
> arch/x86/kvm/vmx.c | 18 ++++++++++++++++--
> arch/x86/kvm/x86.c | 12 +++++++++---
> arch/x86/kvm/x86.h | 3 ++-
> 7 files changed, 38 insertions(+), 10 deletions(-)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Paolo Bonzini

unread,

Dec 11, 2013, 5:00:03 AM12/11/13

to

Il 11/12/2013 09:31, Liu, Jinsong ha scritto:
> Paolo, comments for version 2?

I think I commented that it's fine, I'm just waiting for a rebase on top
of the generic patches.

Paolo

Liu, Jinsong

unread,

Dec 12, 2013, 12:50:02 AM12/12/13

to

Paolo Bonzini wrote:
> Il 11/12/2013 09:31, Liu, Jinsong ha scritto:
>> Paolo, comments for version 2?
>
> I think I commented that it's fine, I'm just waiting for a rebase on
> top of the generic patches.
>
> Paolo
>

Thanks! common MPX definiation patches have been checked in tip tree (both Qiaowei and I use that definiations):
http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=191f57c137bcce0e3e9313acb77b2f114d15afbb
http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=e7d820a5e549b3eb6c3f9467507566565646a669

Paolo Bonzini

unread,

Dec 12, 2013, 4:50:02 AM12/12/13

to

Il 12/12/2013 06:47, Liu, Jinsong ha scritto:
> Paolo Bonzini wrote:
>> Il 11/12/2013 09:31, Liu, Jinsong ha scritto:
>>> Paolo, comments for version 2?
>>
>> I think I commented that it's fine, I'm just waiting for a rebase on
>> top of the generic patches.
>>
>> Paolo
>>
>
> Thanks! common MPX definiation patches have been checked in tip tree (both Qiaowei and I use that definiations):
> http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=191f57c137bcce0e3e9313acb77b2f114d15afbb
> http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=e7d820a5e549b3eb6c3f9467507566565646a669

Ok, can you rebase and resend?

Paolo

Liu, Jinsong

unread,

Dec 12, 2013, 6:10:02 AM12/12/13

to

Paolo Bonzini wrote:
> Il 12/12/2013 06:47, Liu, Jinsong ha scritto:
>> Paolo Bonzini wrote:
>>> Il 11/12/2013 09:31, Liu, Jinsong ha scritto:
>>>> Paolo, comments for version 2?
>>>
>>> I think I commented that it's fine, I'm just waiting for a rebase
>>> on top of the generic patches.
>>>
>>> Paolo
>>>
>>
>> Thanks! common MPX definiation patches have been checked in tip tree
>> (both Qiaowei and I use that definiations):
>> http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=191f57c137bcce0e3e9313acb77b2f114d15afbb
>> http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=e7d820a5e549b3eb6c3f9467507566565646a669
>
> Ok, can you rebase and resend?
>
> Paolo

Sure, I have pulled and rebased on git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
No confliction, patches v3 will send out later.

Thanks,
Jinsong--

Paolo Bonzini

unread,

Jan 20, 2014, 9:40:01 AM1/20/14

to

Il 12/12/2013 12:09, Liu, Jinsong ha scritto:
> Paolo Bonzini wrote:
>> Il 12/12/2013 06:47, Liu, Jinsong ha scritto:
>>> Paolo Bonzini wrote:
>>>> Il 11/12/2013 09:31, Liu, Jinsong ha scritto:
>>>>> Paolo, comments for version 2?
>>>>
>>>> I think I commented that it's fine, I'm just waiting for a rebase
>>>> on top of the generic patches.
>>>>
>>>> Paolo
>>>>
>>>
>>> Thanks! common MPX definiation patches have been checked in tip tree
>>> (both Qiaowei and I use that definiations):
>>> http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=191f57c137bcce0e3e9313acb77b2f114d15afbb
>>> http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=e7d820a5e549b3eb6c3f9467507566565646a669
>>
>> Ok, can you rebase and resend?
>>
>> Paolo
>
> Sure, I have pulled and rebased on git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git
> No confliction, patches v3 will send out later.

Didn't see this... You still have a couple of days to send it out and
address the review remarks.

Paolo

Liu, Jinsong

unread,

Jan 21, 2014, 10:30:02 AM1/21/14

to

Paolo Bonzini wrote:
> Il 12/12/2013 12:09, Liu, Jinsong ha scritto:
>> Paolo Bonzini wrote:
>>> Il 12/12/2013 06:47, Liu, Jinsong ha scritto:
>>>> Paolo Bonzini wrote:
>>>>> Il 11/12/2013 09:31, Liu, Jinsong ha scritto:
>>>>>> Paolo, comments for version 2?
>>>>>
>>>>> I think I commented that it's fine, I'm just waiting for a rebase
>>>>> on top of the generic patches.
>>>>>
>>>>> Paolo
>>>>>
>>>>
>>>> Thanks! common MPX definiation patches have been checked in tip
>>>> tree (both Qiaowei and I use that definiations):
>>>> http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=191f57c137bcce0e3e9313acb77b2f114d15afbb
>>>> http://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?id=e7d820a5e549b3eb6c3f9467507566565646a669
>>>
>>> Ok, can you rebase and resend?
>>>
>>> Paolo
>>
>> Sure, I have pulled and rebased on
>> git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git No
>> confliction, patches v3 will send out later.
>
> Didn't see this... You still have a couple of days to send it out and
> address the review remarks.
>
> Paolo

Hmm? I remember I have sent out the rebased patches v3 last month ... If you didn't receive them I'm OK to rebase and resend them. BTW, what's the review remarks? I remember you commented that the patches are fine. Any misunderstanding please point out to me.

Thanks,
Jinsong--

Paolo Bonzini

unread,

Jan 21, 2014, 11:50:02 AM1/21/14

to

Il 21/01/2014 16:25, Liu, Jinsong ha scritto:
> Hmm? I remember I have sent out the rebased patches v3 last month

> If you didn't receive them I'm OK to rebase and resend them. BTW, what's
> the review remarks? I remember you commented that the patches are fine.
> Any misunderstanding please point out to me.

You sent v3 of QEMU, but not of KVM. I don't see any mail from you
after December 12th on k...@vger.kernel.org.

I can see my comment that the patches were fine (apart from needing a
rebase), but the threading was wrong and I cannot find anymore _which_
patches they were. I did find a comment that BNDCFGS must be added to
msrs_to_save, but I don't know if that was v1 or v2 because you didn't
add the version number when sending v2.

Paolo

Liu, Jinsong

unread,

Jan 21, 2014, 12:30:03 PM1/21/14

to

Paolo Bonzini wrote:
> Il 21/01/2014 16:25, Liu, Jinsong ha scritto:
>> Hmm? I remember I have sent out the rebased patches v3 last month
>> If you didn't receive them I'm OK to rebase and resend them. BTW,
>> what's the review remarks? I remember you commented that the patches
>> are fine. Any misunderstanding please point out to me.
>
> You sent v3 of QEMU, but not of KVM. I don't see any mail from you
> after December 12th on k...@vger.kernel.org.
>
> I can see my comment that the patches were fine (apart from needing a
> rebase), but the threading was wrong and I cannot find anymore _which_
> patches they were. I did find a comment that BNDCFGS must be added to
> msrs_to_save, but I don't know if that was v1 or v2 because you didn't
> add the version number when sending v2.
>
> Paolo

So I don't need resend qemu patches, just rebase and resend KVM MPX patches, is that right?

Thanks,
Jinsong--