Google Groups no longer supports new Usenet posts or subscriptions. Historical content remains viewable.
Dismiss

[RFC][PATCH] PM / Runtime: Use alloc_workqueue() for creating PM workqueue

30 views
Skip to first unread message

Rafael J. Wysocki

unread,
Sep 15, 2010, 4:00:01 PM9/15/10
to
From: Rafael J. Wysocki <r...@sisk.pl>
Subject: PM / Runtime: Use alloc_workqueue() for creating PM workqueue

Although we need the PM workqueue to be freezable, we don't need it
to be singlethread. Also, the number of concurrent work items
running on a single CPU need not be constrained. For these reasons
use alloc_workqueue() directly, with suitable arguments, instead of
create_freezeable_workqueue(), to create the runtime PM workqueue.

Signed-off-by: Rafael J. Wysocki <r...@sisk.pl>
---

Tejun,

I'm not sure about that WQ_RESCUER thing. Can you please tell me what
exactly it is for?

Thanks,
Rafael

---
kernel/power/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/kernel/power/main.c
===================================================================
--- linux-2.6.orig/kernel/power/main.c
+++ linux-2.6/kernel/power/main.c
@@ -308,7 +308,7 @@ EXPORT_SYMBOL_GPL(pm_wq);

static int __init pm_start_workqueue(void)
{
- pm_wq = create_freezeable_workqueue("pm");
+ pm_wq = alloc_workqueue("pm", WQ_FREEZEABLE | WQ_RESCUER, 0);

return pm_wq ? 0 : -ENOMEM;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Tejun Heo

unread,
Sep 16, 2010, 4:20:01 AM9/16/10
to
Hello, Rafael.

On 09/15/2010 09:56 PM, Rafael J. Wysocki wrote:
> I'm not sure about that WQ_RESCUER thing. Can you please tell me what
> exactly it is for?

It's to guarantee forward progress for workqueues which process work
items which may be used to reclaim memory. It reserves a rescue
worker thread to be used under memory pressure. I finished workqueue
documentation a few days ago and sent pull request to Linus.

http://git.kernel.org/?p=linux/kernel/git/tj/wq.git;a=blob;f=Documentation/workqueue.txt;h=e4498a2872c37a0b3b156ddc7ad7135d030d224d;hb=c54fce6eff197d9c57c97afbf6c9722ce434fc8f

So, for pm_wq, there's no reason to use WQ_RESUER.
alloc_workqueue("pm", WQ_FREEZEABLE, 0) should do it.

Thanks for doing it.

--
tejun

Rafael J. Wysocki

unread,
Sep 16, 2010, 2:30:02 PM9/16/10
to
On Thursday, September 16, 2010, Tejun Heo wrote:
> Hello, Rafael.
>
> On 09/15/2010 09:56 PM, Rafael J. Wysocki wrote:
> > I'm not sure about that WQ_RESCUER thing. Can you please tell me what
> > exactly it is for?
>
> It's to guarantee forward progress for workqueues which process work
> items which may be used to reclaim memory. It reserves a rescue
> worker thread to be used under memory pressure. I finished workqueue
> documentation a few days ago and sent pull request to Linus.
>
> http://git.kernel.org/?p=linux/kernel/git/tj/wq.git;a=blob;f=Documentation/workqueue.txt;h=e4498a2872c37a0b3b156ddc7ad7135d030d224d;hb=c54fce6eff197d9c57c97afbf6c9722ce434fc8f
>
> So, for pm_wq, there's no reason to use WQ_RESUER.
> alloc_workqueue("pm", WQ_FREEZEABLE, 0) should do it.

Great, thanks!

> Thanks for doing it.

No big deal. Actually I should thank you for making it possible to use
freezable workqueues that are not singlethread. :-)

Updated patch follows.

Thanks,
Rafael

---


From: Rafael J. Wysocki <r...@sisk.pl>

Subject: PM / Runtime: Use alloc_workqueue() for creating the PM workqueue

Although we need the PM workqueue to be freezable, we don't need it
to be singlethread. Also, the number of concurrent work items
running on a single CPU need not be constrained. For these reasons
use alloc_workqueue() directly, with suitable arguments, instead of
create_freezeable_workqueue(), to create the runtime PM workqueue.

Signed-off-by: Rafael J. Wysocki <r...@sisk.pl>
---

kernel/power/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux-2.6/kernel/power/main.c
===================================================================
--- linux-2.6.orig/kernel/power/main.c
+++ linux-2.6/kernel/power/main.c
@@ -308,7 +308,7 @@ EXPORT_SYMBOL_GPL(pm_wq);

static int __init pm_start_workqueue(void)
{
- pm_wq = create_freezeable_workqueue("pm");

+ pm_wq = alloc_workqueue("pm", WQ_FREEZEABLE, 0);



return pm_wq ? 0 : -ENOMEM;
}

Tejun Heo

unread,
Sep 17, 2010, 6:00:02 AM9/17/10
to
On 09/16/2010 08:24 PM, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <r...@sisk.pl>
> Subject: PM / Runtime: Use alloc_workqueue() for creating the PM workqueue
>
> Although we need the PM workqueue to be freezable, we don't need it
> to be singlethread. Also, the number of concurrent work items
> running on a single CPU need not be constrained. For these reasons
> use alloc_workqueue() directly, with suitable arguments, instead of
> create_freezeable_workqueue(), to create the runtime PM workqueue.
>
> Signed-off-by: Rafael J. Wysocki <r...@sisk.pl>

Acked-by: Tejun Heo <t...@kernel.org>

Thanks.

--
tejun

0 new messages