[patch] kobject: free memory if netlink_kernel_create() fails

[Dan Carpenter]

There is a kfree(ue_sk) missing on the error path if
netlink_kernel_create() fails.

Signed-off-by: Dan Carpenter <err...@gmail.com>

diff --git a/lib/kobject_uevent.c b/lib/kobject_uevent.c
index 59c1551..08e15f7 100644
--- a/lib/kobject_uevent.c
+++ b/lib/kobject_uevent.c
@@ -378,6 +378,7 @@ static int uevent_net_init(struct net *net)
if (!ue_sk->sk) {
printk(KERN_ERR
"kobject_uevent: unable to create netlink socket!\n");
+ kfree(ue_sk);
return -ENODEV;
}
mutex_lock(&uevent_sock_mutex);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

[Eric W. Biederman]

Dan Carpenter <err...@gmail.com> writes:

> There is a kfree(ue_sk) missing on the error path if
> netlink_kernel_create() fails.
>
> Signed-off-by: Dan Carpenter <err...@gmail.com>

Reviewed-by: "Eric W. Biederman" <ebie...@xmission.com>

Oops.

[David Miller]

From: ebie...@xmission.com (Eric W. Biederman)
Date: Tue, 25 May 2010 03:25:37 -0700

> Dan Carpenter <err...@gmail.com> writes:
>
>> There is a kfree(ue_sk) missing on the error path if
>> netlink_kernel_create() fails.
>>
>> Signed-off-by: Dan Carpenter <err...@gmail.com>
> Reviewed-by: "Eric W. Biederman" <ebie...@xmission.com>

Greg, I assume you've got this one?

Thanks!

[Greg KH]

On Wed, May 26, 2010 at 12:43:47AM -0700, David Miller wrote:
> From: ebie...@xmission.com (Eric W. Biederman)
> Date: Tue, 25 May 2010 03:25:37 -0700
>
> > Dan Carpenter <err...@gmail.com> writes:
> >
> >> There is a kfree(ue_sk) missing on the error path if
> >> netlink_kernel_create() fails.
> >>
> >> Signed-off-by: Dan Carpenter <err...@gmail.com>
> > Reviewed-by: "Eric W. Biederman" <ebie...@xmission.com>
>
> Greg, I assume you've got this one?

Yes, I'll queue it up in a day or so.

thanks,

greg k-h