linux-next: build failure after merge of the scsi tree

Stephen Rothwell

unread,

Feb 9, 2010, 8:40:02 PM2/9/10

to

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

drivers/scsi/lpfc/lpfc_bsg.c: In function 'lpfc_bsg_diag_mode':
drivers/scsi/lpfc/lpfc_bsg.c:1496: error: implicit declaration of function 'msleep'

Caused by commit 3b5dd52aaffd291edea9f939ed46a960b240bb45 ("[SCSI] lpfc
8.3.8: (BSG4) Add new vendor specific BSG Commands").

Missing include of linux/delay.h?

I have used the version of the scsi tree from next-20100209 for today.
--
Cheers,
Stephen Rothwell s...@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

James Bottomley

unread,

Feb 10, 2010, 5:20:03 PM2/10/10

to

On Wed, 2010-02-10 at 12:33 +1100, Stephen Rothwell wrote:
> Hi James,
>
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> drivers/scsi/lpfc/lpfc_bsg.c: In function 'lpfc_bsg_diag_mode':
> drivers/scsi/lpfc/lpfc_bsg.c:1496: error: implicit declaration of function 'msleep'
>
> Caused by commit 3b5dd52aaffd291edea9f939ed46a960b240bb45 ("[SCSI] lpfc
> 8.3.8: (BSG4) Add new vendor specific BSG Commands").
>
> Missing include of linux/delay.h?

Looks to be exactly the problem. delay.h gets pulled into some of the
generic headers on x86, but not on ppc.

Sorry, my powerstation isn't working (orange warning light) and I can't
seem to get anyone to repair it, so I can't build for ppc anymore (which
is why this didn't get spotted on commit).

James

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Stephen Rothwell

unread,

Feb 10, 2010, 6:20:01 PM2/10/10

to

Hi James,

On Wed, 10 Feb 2010 17:16:16 -0500 James Bottomley <James.B...@HansenPartnership.com> wrote:
>
> Sorry, my powerstation isn't working (orange warning light) and I can't
> seem to get anyone to repair it, so I can't build for ppc anymore (which
> is why this didn't get spotted on commit).

There are some (kernel building only) cross compilers at
http://bakeyournoodle.com/cross/ . (yes, I know they are not PARISC
hosted :-))

That being said, I don't expect every maintainer to cross build very
much, just to react when they get problem reports. ;-)

Stephen Rothwell

unread,

Feb 15, 2010, 7:40:02 PM2/15/10

to

Hi James,

On Wed, 10 Feb 2010 17:16:16 -0500 James Bottomley <James.B...@HansenPartnership.com> wrote:
>

> On Wed, 2010-02-10 at 12:33 +1100, Stephen Rothwell wrote:
> >
> > After merging the scsi tree, today's linux-next build (powerpc
> > ppc64_defconfig) failed like this:
> >
> > drivers/scsi/lpfc/lpfc_bsg.c: In function 'lpfc_bsg_diag_mode':
> > drivers/scsi/lpfc/lpfc_bsg.c:1496: error: implicit declaration of function 'msleep'
> >
> > Caused by commit 3b5dd52aaffd291edea9f939ed46a960b240bb45 ("[SCSI] lpfc
> > 8.3.8: (BSG4) Add new vendor specific BSG Commands").
> >
> > Missing include of linux/delay.h?
>
> Looks to be exactly the problem. delay.h gets pulled into some of the
> generic headers on x86, but not on ppc.
>
> Sorry, my powerstation isn't working (orange warning light) and I can't
> seem to get anyone to repair it, so I can't build for ppc anymore (which
> is why this didn't get spotted on commit).

This is still broken ...