linux-next: build failure after merge of the ext3 tree

Stephen Rothwell

unread,

Mar 1, 2010, 7:40:02 PM3/1/10

to

Hi Jan,

After merging the ext3 tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

fs/jfs/jfs_xtree.c: In function 'xtSplitRoot':
fs/jfs/jfs_xtree.c:1256: error: 'rec' undeclared (first use in this function)

Caused by commit bff3333e868578990f6fe794a7cba0c74bd433ac ("dquot:
cleanup space allocation / freeing routines").

This is annoying ... this file system could be build tested on any
architecture, so why wasn't it?

I have used the version of the ext3 tree from next-20100301 for today.

--
Cheers,
Stephen Rothwell s...@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

Christoph Hellwig

unread,

Mar 2, 2010, 4:10:02 AM3/2/10

to

On Tue, Mar 02, 2010 at 11:36:34AM +1100, Stephen Rothwell wrote:
> Hi Jan,
>
> After merging the ext3 tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/jfs/jfs_xtree.c: In function 'xtSplitRoot':
> fs/jfs/jfs_xtree.c:1256: error: 'rec' undeclared (first use in this function)
>
> Caused by commit bff3333e868578990f6fe794a7cba0c74bd433ac ("dquot:
> cleanup space allocation / freeing routines").
>
> This is annoying ... this file system could be build tested on any
> architecture, so why wasn't it?

I did test the compile, but the version in your tree does not match the
one I submitted.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majo...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Jan Kara

unread,

Mar 2, 2010, 12:30:01 PM3/2/10

to

Hi,

On Tue 02-03-10 11:36:34, Stephen Rothwell wrote:
> After merging the ext3 tree, today's linux-next build (powerpc
> ppc64_defconfig) failed like this:
>
> fs/jfs/jfs_xtree.c: In function 'xtSplitRoot':
> fs/jfs/jfs_xtree.c:1256: error: 'rec' undeclared (first use in this function)
>
> Caused by commit bff3333e868578990f6fe794a7cba0c74bd433ac ("dquot:
> cleanup space allocation / freeing routines").
>
> This is annoying ... this file system could be build tested on any
> architecture, so why wasn't it?

I'm sorry. It's my fault. I've modified Christoph's patch but I forgot to
enable JFS in the test build. Since this isn't the first time something
like this happened to me, I've changed the way I commit patches. They'll
first go to for_testing branch and after a build machine runs them through
allyesconfig and allmodconfig compiles they'll get moved to for_next
branch. So hopefully stupid mistakes like this one should be avoided for
future.

Honza
--
Jan Kara <ja...@suse.cz>
SUSE Labs, CR

Stephen Rothwell

unread,

Mar 2, 2010, 7:50:03 PM3/2/10

to

Hi Jan,

On Tue, 2 Mar 2010 18:27:57 +0100 Jan Kara <ja...@suse.cz> wrote:
>
> I'm sorry. It's my fault. I've modified Christoph's patch but I forgot to
> enable JFS in the test build. Since this isn't the first time something
> like this happened to me, I've changed the way I commit patches. They'll
> first go to for_testing branch and after a build machine runs them through
> allyesconfig and allmodconfig compiles they'll get moved to for_next
> branch. So hopefully stupid mistakes like this one should be avoided for
> future.

Sound like a good plan, thanks.